- Kernel - mailweb.openeuler.org

[openeuler:OLK-6.6 2679/2679] kernel/sched/cpuacct.c:412:18: warning: no previous prototype for function 'bpf_cpuacct_kcpustat_cpu_fetch'
by kernel test robot 14 Aug '25

14 Aug '25

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 43d8c124ec4624389b14d42595e5f0195e3e5a1d commit: 6ed308fc1d6f486c9e3c171b6b80c1c5f0f57df6 [2679/2679] bpf-rvi: cpuacct: Add bpf_cpuacct_kcpustat_cpu_fetch kfunc config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20250814/202508142117.RpbHh5Ge-lkp@…) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250814/202508142117.RpbHh5Ge-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202508142117.RpbHh5Ge-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from kernel/sched/build_utility.c:61: >> kernel/sched/cpuacct.c:412:18: warning: no previous prototype for function 'bpf_cpuacct_kcpustat_cpu_fetch' [-Wmissing-prototypes] 412 | __bpf_kfunc void bpf_cpuacct_kcpustat_cpu_fetch(struct kernel_cpustat *dst, | ^ kernel/sched/cpuacct.c:412:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 412 | __bpf_kfunc void bpf_cpuacct_kcpustat_cpu_fetch(struct kernel_cpustat *dst, | ^ | static In file included from kernel/sched/build_utility.c:73: kernel/sched/debug.c:102:12: warning: no previous prototype for function 'is_prefer_numa' [-Wmissing-prototypes] 102 | int __weak is_prefer_numa(void) | ^ kernel/sched/debug.c:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 102 | int __weak is_prefer_numa(void) | ^ | static In file included from kernel/sched/build_utility.c:113: kernel/sched/bpf_sched.c:186:17: warning: no previous prototype for function 'bpf_sched_entity_is_task' [-Wmissing-prototypes] 186 | __bpf_kfunc int bpf_sched_entity_is_task(struct sched_entity *se) | ^ kernel/sched/bpf_sched.c:186:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 186 | __bpf_kfunc int bpf_sched_entity_is_task(struct sched_entity *se) | ^ | static kernel/sched/bpf_sched.c:194:33: warning: no previous prototype for function 'bpf_sched_entity_to_task' [-Wmissing-prototypes] 194 | __bpf_kfunc struct task_struct *bpf_sched_entity_to_task(struct sched_entity *se) | ^ kernel/sched/bpf_sched.c:194:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 194 | __bpf_kfunc struct task_struct *bpf_sched_entity_to_task(struct sched_entity *se) | ^ | static kernel/sched/bpf_sched.c:202:18: warning: no previous prototype for function 'bpf_sched_tag_of_entity' [-Wmissing-prototypes] 202 | __bpf_kfunc long bpf_sched_tag_of_entity(struct sched_entity *se) | ^ kernel/sched/bpf_sched.c:202:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 202 | __bpf_kfunc long bpf_sched_tag_of_entity(struct sched_entity *se) | ^ | static kernel/sched/bpf_sched.c:213:17: warning: no previous prototype for function 'bpf_sched_set_task_prefer_nid' [-Wmissing-prototypes] 213 | __bpf_kfunc int bpf_sched_set_task_prefer_nid(struct task_struct *task, int nid) | ^ kernel/sched/bpf_sched.c:213:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 213 | __bpf_kfunc int bpf_sched_set_task_prefer_nid(struct task_struct *task, int nid) | ^ | static 6 warnings generated. vim +/bpf_cpuacct_kcpustat_cpu_fetch +412 kernel/sched/cpuacct.c 410 411 #ifdef CONFIG_BPF_RVI > 412 __bpf_kfunc void bpf_cpuacct_kcpustat_cpu_fetch(struct kernel_cpustat *dst, 413 struct cpuacct *ca, int cpu) 414 { 415 memcpy(dst, per_cpu_ptr(ca->cpustat, cpu), sizeof(struct kernel_cpustat)); 416 } 417 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 2679/2679] fs/proc/stat.c:224:17: warning: no previous prototype for function 'bpf_get_idle_time'
by kernel test robot 14 Aug '25

14 Aug '25

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 43d8c124ec4624389b14d42595e5f0195e3e5a1d commit: 70780f6924c9b58d5a745d4e20e08e9ace28e711 [2679/2679] bpf-rvi: proc: add bpf_get_{idle,iowait}_time kfunc config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20250814/202508141929.x8zAFTUd-lkp@…) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250814/202508141929.x8zAFTUd-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202508141929.x8zAFTUd-lkp@intel.com/ All warnings (new ones prefixed by >>): >> fs/proc/stat.c:224:17: warning: no previous prototype for function 'bpf_get_idle_time' [-Wmissing-prototypes] 224 | __bpf_kfunc u64 bpf_get_idle_time(struct kernel_cpustat *kcs, int cpu) | ^ fs/proc/stat.c:224:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 224 | __bpf_kfunc u64 bpf_get_idle_time(struct kernel_cpustat *kcs, int cpu) | ^ | static >> fs/proc/stat.c:229:17: warning: no previous prototype for function 'bpf_get_iowait_time' [-Wmissing-prototypes] 229 | __bpf_kfunc u64 bpf_get_iowait_time(struct kernel_cpustat *kcs, int cpu) | ^ fs/proc/stat.c:229:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 229 | __bpf_kfunc u64 bpf_get_iowait_time(struct kernel_cpustat *kcs, int cpu) | ^ | static 2 warnings generated. vim +/bpf_get_idle_time +224 fs/proc/stat.c 222 223 #ifdef CONFIG_BPF_RVI > 224 __bpf_kfunc u64 bpf_get_idle_time(struct kernel_cpustat *kcs, int cpu) 225 { 226 return get_idle_time(kcs, cpu); 227 } 228 > 229 __bpf_kfunc u64 bpf_get_iowait_time(struct kernel_cpustat *kcs, int cpu) 230 { 231 return get_iowait_time(kcs, cpu); 232 } 233 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 2679/2679] kernel/bpf-rvi/common_kfuncs.c:12:32: warning: no previous prototype for function 'bpf_mem_cgroup_from_task'
by kernel test robot 14 Aug '25

14 Aug '25

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 43d8c124ec4624389b14d42595e5f0195e3e5a1d commit: ebd40bbe89d81531c7df459a827d7608c3de57bc [2679/2679] bpf-rvi: Add bpf_mem_cgroup_from_task() kfunc config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20250814/202508141840.Hfv7lhHI-lkp@…) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250814/202508141840.Hfv7lhHI-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202508141840.Hfv7lhHI-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/bpf-rvi/common_kfuncs.c:12:32: warning: no previous prototype for function 'bpf_mem_cgroup_from_task' [-Wmissing-prototypes] 12 | __bpf_kfunc struct mem_cgroup *bpf_mem_cgroup_from_task(struct task_struct *p) | ^ kernel/bpf-rvi/common_kfuncs.c:12:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 12 | __bpf_kfunc struct mem_cgroup *bpf_mem_cgroup_from_task(struct task_struct *p) | ^ | static 1 warning generated. vim +/bpf_mem_cgroup_from_task +12 kernel/bpf-rvi/common_kfuncs.c 7 8 /* 9 * Common support kfuncs 10 */ 11 > 12 __bpf_kfunc struct mem_cgroup *bpf_mem_cgroup_from_task(struct task_struct *p) 13 { 14 return mem_cgroup_from_task(p); 15 } 16 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 2679/2679] block/genhd.c:100:6: warning: no previous prototype for 'part_stat_read_all'
by kernel test robot 14 Aug '25

14 Aug '25

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 43d8c124ec4624389b14d42595e5f0195e3e5a1d commit: 89fa7dcff5e533bd14396601f40c388cfb6c1e59 [2679/2679] bpf-rvi: block: Add diskstats iterator target config: arm64-randconfig-004-20250814 (https://download.01.org/0day-ci/archive/20250814/202508142059.0te3dxlW-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.4.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250814/202508142059.0te3dxlW-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202508142059.0te3dxlW-lkp@intel.com/ All warnings (new ones prefixed by >>): >> block/genhd.c:100:6: warning: no previous prototype for 'part_stat_read_all' [-Wmissing-prototypes] 100 | void part_stat_read_all(struct block_device *part, struct disk_stats *stat) | ^~~~~~~~~~~~~~~~~~ vim +/part_stat_read_all +100 block/genhd.c 99 > 100 void part_stat_read_all(struct block_device *part, struct disk_stats *stat) 101 { 102 int cpu; 103 104 memset(stat, 0, sizeof(struct disk_stats)); 105 for_each_possible_cpu(cpu) { 106 struct disk_stats *ptr = per_cpu_ptr(part->bd_stats, cpu); 107 int group; 108 109 for (group = 0; group < NR_STAT_GROUPS; group++) { 110 stat->nsecs[group] += ptr->nsecs[group]; 111 stat->sectors[group] += ptr->sectors[group]; 112 stat->ios[group] += ptr->ios[group]; 113 stat->merges[group] += ptr->merges[group]; 114 } 115 116 stat->io_ticks += ptr->io_ticks; 117 } 118 } 119 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 2678/2678] include/linux/fortify-string.h:57:33: warning: '__builtin_memcpy' reading between 65 and 536870912 bytes from a region of size 64
by kernel test robot 14 Aug '25

14 Aug '25

Hi Guo, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 43d8c124ec4624389b14d42595e5f0195e3e5a1d commit: f04c0f3eb9b49427c273cd3e4d5a2ff895855b4b [2678/2678] make OPTIMIZE_INLINING config editable config: arm64-randconfig-004-20250814 (https://download.01.org/0day-ci/archive/20250814/202508141753.fScbJysb-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.4.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250814/202508141753.fScbJysb-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202508141753.fScbJysb-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from include/linux/string.h:294, from include/linux/bitmap.h:11, from include/linux/cpumask.h:12, from include/linux/smp.h:13, from include/linux/lockdep.h:14, from include/linux/spinlock.h:63, from include/linux/swait.h:7, from include/linux/completion.h:12, from kernel/padata.c:14: In function 'bitmap_copy', inlined from 'cpumask_copy' at include/linux/cpumask.h:740:2, inlined from '__padata_set_cpumasks' at kernel/padata.c:709:2: >> include/linux/fortify-string.h:57:33: warning: '__builtin_memcpy' reading between 65 and 536870912 bytes from a region of size 64 [-Wstringop-overread] 57 | #define __underlying_memcpy __builtin_memcpy | ^ include/linux/fortify-string.h:648:9: note: in expansion of macro '__underlying_memcpy' 648 | __underlying_##op(p, q, __fortify_size); \ | ^~~~~~~~~~~~~ include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk' 693 | #define memcpy(p, q, s) __fortify_memcpy_chk(p, q, s, \ | ^~~~~~~~~~~~~~~~~~~~ include/linux/bitmap.h:268:17: note: in expansion of macro 'memcpy' 268 | memcpy(dst, src, len); | ^~~~~~ kernel/padata.c: In function '__padata_set_cpumasks': kernel/padata.c:692:48: note: source object 'pcpumask' of size [0, 64] 692 | cpumask_var_t pcpumask, | ~~~~~~~~~~~~~~^~~~~~~~ In function 'bitmap_copy', inlined from 'cpumask_copy' at include/linux/cpumask.h:740:2, inlined from '__padata_set_cpumasks' at kernel/padata.c:709:2: >> include/linux/fortify-string.h:57:33: warning: '__builtin_memcpy' reading between 65 and 536870912 bytes from a region of size 64 [-Wstringop-overread] 57 | #define __underlying_memcpy __builtin_memcpy | ^ include/linux/fortify-string.h:648:9: note: in expansion of macro '__underlying_memcpy' 648 | __underlying_##op(p, q, __fortify_size); \ | ^~~~~~~~~~~~~ include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk' 693 | #define memcpy(p, q, s) __fortify_memcpy_chk(p, q, s, \ | ^~~~~~~~~~~~~~~~~~~~ include/linux/bitmap.h:268:17: note: in expansion of macro 'memcpy' 268 | memcpy(dst, src, len); | ^~~~~~ kernel/padata.c: In function '__padata_set_cpumasks': kernel/padata.c:692:48: note: source object 'pcpumask' of size [0, 64] 692 | cpumask_var_t pcpumask, | ~~~~~~~~~~~~~~^~~~~~~~ vim +/__builtin_memcpy +57 include/linux/fortify-string.h 78a498c3a227f2 Alexander Potapenko 2022-10-24 46 78a498c3a227f2 Alexander Potapenko 2022-10-24 47 #if defined(__SANITIZE_MEMORY__) 78a498c3a227f2 Alexander Potapenko 2022-10-24 48 /* 78a498c3a227f2 Alexander Potapenko 2022-10-24 49 * For KMSAN builds all memcpy/memset/memmove calls should be replaced by the 78a498c3a227f2 Alexander Potapenko 2022-10-24 50 * corresponding __msan_XXX functions. 78a498c3a227f2 Alexander Potapenko 2022-10-24 51 */ 78a498c3a227f2 Alexander Potapenko 2022-10-24 52 #include <linux/kmsan_string.h> 78a498c3a227f2 Alexander Potapenko 2022-10-24 53 #define __underlying_memcpy __msan_memcpy 78a498c3a227f2 Alexander Potapenko 2022-10-24 54 #define __underlying_memmove __msan_memmove 78a498c3a227f2 Alexander Potapenko 2022-10-24 55 #define __underlying_memset __msan_memset 78a498c3a227f2 Alexander Potapenko 2022-10-24 56 #else a28a6e860c6cf2 Francis Laniel 2021-02-25 @57 #define __underlying_memcpy __builtin_memcpy a28a6e860c6cf2 Francis Laniel 2021-02-25 58 #define __underlying_memmove __builtin_memmove a28a6e860c6cf2 Francis Laniel 2021-02-25 59 #define __underlying_memset __builtin_memset 78a498c3a227f2 Alexander Potapenko 2022-10-24 60 #endif 78a498c3a227f2 Alexander Potapenko 2022-10-24 61 :::::: The code at line 57 was first introduced by commit :::::: a28a6e860c6cf231cf3c5171c75c342adcd00406 string.h: move fortified functions definitions in a dedicated header. :::::: TO: Francis Laniel <laniel_francis(a)privacyrequired.com> :::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-5.10 V1] sched: Fix sched tunable parameter range overflow
by Cheng Yu 14 Aug '25

14 Aug '25

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/ICSER4 -------------------------------- When recalculating scheduler tunables during CPU hotplug(online/offline), we failed to check and constrain the tunnable parameters within their valid ranges. After repeated operations, this could cause parameters to overflow beyond limits. In extreme cases, sysctl_sched_min_granularity could becomes 0, which disrupts normal scheduler operation and leads to unexpected behavior. Furthermore, setting sysctl_sched_tunable_scaling when this condition exists triggers a division-by-zero error, resulting in a system crash. Fix this by adding proper range checks and constraints during the tunable recalculation process during CPU hotplug events. Fixes: 0bcdcf28c979 ("sched: Fix missing sched tunable recalculation on cpu add/remove") Signed-off-by: Cheng Yu <serein.chengyu(a)huawei.com> --- include/linux/sched/sysctl.h | 5 +++++ kernel/sched/fair.c | 14 +++++++++----- kernel/sysctl.c | 15 +++++++-------- 3 files changed, 21 insertions(+), 13 deletions(-) diff --git a/include/linux/sched/sysctl.h b/include/linux/sched/sysctl.h index 90021477ea4c..2bc965928098 100644 --- a/include/linux/sched/sysctl.h +++ b/include/linux/sched/sysctl.h @@ -31,6 +31,11 @@ extern unsigned int sysctl_sched_min_granularity; extern unsigned int sysctl_sched_wakeup_granularity; extern unsigned int sysctl_sched_child_runs_first; +extern unsigned int min_sched_granularity_ns; +extern unsigned int max_sched_granularity_ns; +extern unsigned int min_wakeup_granularity_ns; +extern unsigned int max_wakeup_granularity_ns; + #ifdef CONFIG_QOS_SCHED_DYNAMIC_AFFINITY extern int sysctl_sched_util_low_pct; #endif diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d48d1ed28a5c..848d45f2bc49 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -235,11 +235,15 @@ static void update_sysctl(void) { unsigned int factor = get_update_sysctl_factor(); -#define SET_SYSCTL(name) \ - (sysctl_##name = (factor) * normalized_sysctl_##name) - SET_SYSCTL(sched_min_granularity); - SET_SYSCTL(sched_latency); - SET_SYSCTL(sched_wakeup_granularity); +#define SET_SYSCTL(name, min_val, max_val) \ + (sysctl_##name = clamp((factor) * normalized_sysctl_##name, \ + min_val, max_val)) + SET_SYSCTL(sched_min_granularity, + min_sched_granularity_ns, max_sched_granularity_ns); + SET_SYSCTL(sched_latency, + min_sched_granularity_ns, max_sched_granularity_ns); + SET_SYSCTL(sched_wakeup_granularity, + min_wakeup_granularity_ns, max_wakeup_granularity_ns); #undef SET_SYSCTL } diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 738d9a4455c1..fdb8146ed5b9 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -192,16 +192,15 @@ static enum sysctl_writes_mode sysctl_writes_strict = SYSCTL_WRITES_STRICT; int sysctl_legacy_va_layout; #endif -#ifdef CONFIG_SCHED_DEBUG -static int min_sched_granularity_ns = 100000; /* 100 usecs */ -static int max_sched_granularity_ns = NSEC_PER_SEC; /* 1 second */ -static int min_wakeup_granularity_ns; /* 0 usecs */ -static int max_wakeup_granularity_ns = NSEC_PER_SEC; /* 1 second */ -#ifdef CONFIG_SMP +unsigned int min_sched_granularity_ns = 100000; /* 100 usecs */ +unsigned int max_sched_granularity_ns = NSEC_PER_SEC; /* 1 second */ +unsigned int min_wakeup_granularity_ns; /* 0 usecs */ +unsigned int max_wakeup_granularity_ns = NSEC_PER_SEC; /* 1 second */ + +#if defined(CONFIG_SCHED_DEBUG) && defined(CONFIG_SMP) static int min_sched_tunable_scaling = SCHED_TUNABLESCALING_NONE; static int max_sched_tunable_scaling = SCHED_TUNABLESCALING_END-1; -#endif /* CONFIG_SMP */ -#endif /* CONFIG_SCHED_DEBUG */ +#endif #ifdef CONFIG_COMPACTION static int min_extfrag_threshold; -- 2.25.1

2 1

[PATCH OLK-6.6] sched/psi: change permissions of /proc/pressure/stat
by Lu Jialin 14 Aug '25

14 Aug '25

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/ICPMAC -------------------------------- Change the permissions of /proc/pressure/stat from 0666 to 0444. /proc/pressure/stat is read only now, therefore, there is no need to give the write permission to /proc/pressure/stat. Fixes: 4a69b56540f4 ("sched/psi: Introduce pressure.stat in psi") Signed-off-by: Lu Jialin <lujialin4(a)huawei.com> --- kernel/sched/psi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index 32ebbc50f2ed..3a7e5216fff4 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -2006,7 +2006,7 @@ static int __init psi_proc_init(void) proc_create("pressure/irq", 0666, NULL, &psi_irq_proc_ops); #endif #ifdef CONFIG_PSI_FINE_GRAINED - proc_create("pressure/stat", 0666, NULL, &psi_stat_proc_ops); + proc_create("pressure/stat", 0444, NULL, &psi_stat_proc_ops); #endif } return 0; -- 2.34.1

2 1

[PATCH openEuler-1.0-LTS] clone_private_mnt(): make sure that caller has CAP_SYS_ADMIN in the right userns
by Wang Zhaolong 14 Aug '25

14 Aug '25

From: Al Viro <viro(a)zeniv.linux.org.uk> mainline inclusion from mainline-v6.10-rc4 commit c28f922c9dcee0e4876a2c095939d77fe7e15116 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/ICSG51 CVE: CVE-2025-38499 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- What we want is to verify there is that clone won't expose something hidden by a mount we wouldn't be able to undo. "Wouldn't be able to undo" may be a result of MNT_LOCKED on a child, but it may also come from lacking admin rights in the userns of the namespace mount belongs to. clone_private_mnt() checks the former, but not the latter. There's a number of rather confusing CAP_SYS_ADMIN checks in various userns during the mount, especially with the new mount API; they serve different purposes and in case of clone_private_mnt() they usually, but not always end up covering the missing check mentioned above. Reviewed-by: Christian Brauner <brauner(a)kernel.org> Reported-by: "Orlando, Noah" <Noah.Orlando(a)deshaw.com> Fixes: 427215d85e8d ("ovl: prevent private clone if bind mount is not allowed") Signed-off-by: Al Viro <viro(a)zeniv.linux.org.uk> Conflicts: fs/namespace.c [Conflicts with mainline commit db04662e2f4f ("fs: allow detached mounts in clone_private_mount()") and commit 1f282cdc1d21 ("fs/fhandle.c: fix a race in call of has_locked_children()").] Signed-off-by: Wang Zhaolong <wangzhaolong(a)huaweicloud.com> --- fs/namespace.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/namespace.c b/fs/namespace.c index b682a044cf0e..e4226bc31e6b 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -1895,10 +1895,15 @@ struct vfsmount *clone_private_mount(const struct path *path) goto invalid; if (!check_mnt(old_mnt)) goto invalid; + if (!ns_capable(old_mnt->mnt_ns->user_ns, CAP_SYS_ADMIN)) { + up_read(&namespace_sem); + return ERR_PTR(-EPERM); + } + if (has_locked_children(old_mnt, path->dentry)) goto invalid; new_mnt = clone_mnt(old_mnt, path->dentry, CL_PRIVATE); up_read(&namespace_sem); -- 2.39.2

2 1

[openeuler:openEuler-1.0-LTS 1755/1755] arch/x86/kernel/apic/apic.c:2202: warning: Function parameter or member 'apicid' not described in 'apic_id_is_primary_thread'
by kernel test robot 14 Aug '25

14 Aug '25

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 8723dc57de6371f9cc8764e15d4cc9e57ae592ee commit: d0055f351e647f33f3b0329bff022213bf8aa085 [1755/1755] x86/smp: fix non-SMP broken build due to redefinition of apic_id_is_primary_thread config: x86_64-buildonly-randconfig-2002-20250811 (https://download.01.org/0day-ci/archive/20250814/202508140748.SO4qfB0e-lkp@…) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250814/202508140748.SO4qfB0e-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202508140748.SO4qfB0e-lkp@intel.com/ All warnings (new ones prefixed by >>): arch/x86/kernel/apic/apic.c:1040:28: warning: no previous prototype for function 'smp_apic_timer_interrupt' [-Wmissing-prototypes] 1040 | __visible void __irq_entry smp_apic_timer_interrupt(struct pt_regs *regs) | ^ arch/x86/kernel/apic/apic.c:1040:11: note: declare 'static' if the function is not intended to be used outside of this translation unit 1040 | __visible void __irq_entry smp_apic_timer_interrupt(struct pt_regs *regs) | ^ | static arch/x86/kernel/apic/apic.c:2021:28: warning: no previous prototype for function 'smp_spurious_interrupt' [-Wmissing-prototypes] 2021 | __visible void __irq_entry smp_spurious_interrupt(struct pt_regs *regs) | ^ arch/x86/kernel/apic/apic.c:2021:11: note: declare 'static' if the function is not intended to be used outside of this translation unit 2021 | __visible void __irq_entry smp_spurious_interrupt(struct pt_regs *regs) | ^ | static arch/x86/kernel/apic/apic.c:2051:28: warning: no previous prototype for function 'smp_error_interrupt' [-Wmissing-prototypes] 2051 | __visible void __irq_entry smp_error_interrupt(struct pt_regs *regs) | ^ arch/x86/kernel/apic/apic.c:2051:11: note: declare 'static' if the function is not intended to be used outside of this translation unit 2051 | __visible void __irq_entry smp_error_interrupt(struct pt_regs *regs) | ^ | static 3 warnings generated. >> arch/x86/kernel/apic/apic.c:2202: warning: Function parameter or member 'apicid' not described in 'apic_id_is_primary_thread' >> arch/x86/kernel/apic/apic.c:2202: warning: Excess function parameter 'id' description in 'apic_id_is_primary_thread' vim +2202 arch/x86/kernel/apic/apic.c 8f54969dc8d670 Gu Zheng 2016-08-25 2195 d0055f351e647f Vlastimil Babka 2018-08-14 2196 #ifdef CONFIG_SMP 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2197 /** 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2198 * apic_id_is_primary_thread - Check whether APIC ID belongs to a primary thread 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2199 * @id: APIC ID to check 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2200 */ 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2201 bool apic_id_is_primary_thread(unsigned int apicid) 6a4d2657e048f0 Thomas Gleixner 2018-05-29 @2202 { 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2203 u32 mask; 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2204 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2205 if (smp_num_siblings == 1) 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2206 return true; 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2207 /* Isolate the SMT bit(s) in the APICID and check for 0 */ 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2208 mask = (1U << (fls(smp_num_siblings) - 1)) - 1; 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2209 return !(apicid & mask); 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2210 } d0055f351e647f Vlastimil Babka 2018-08-14 2211 #endif 6a4d2657e048f0 Thomas Gleixner 2018-05-29 2212 :::::: The code at line 2202 was first introduced by commit :::::: 6a4d2657e048f096c7ffcad254010bd94891c8c0 x86/smp: Provide topology_is_primary_thread() :::::: TO: Thomas Gleixner <tglx(a)linutronix.de> :::::: CC: Thomas Gleixner <tglx(a)linutronix.de> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 1755/1755] arch/x86/kernel/cpu/mce/inject.o: warning: objtool: missing symbol for section .exit.text
by kernel test robot 14 Aug '25

14 Aug '25

Hi Borislav, First bad commit (maybe != root cause): tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 8723dc57de6371f9cc8764e15d4cc9e57ae592ee commit: 9b6ab4a9bac22d947d324eed3f0cfd938dde959d [1755/1755] x86/mce-inject: Reset injection struct after injection config: x86_64-buildonly-randconfig-2004-20250811 (https://download.01.org/0day-ci/archive/20250814/202508140732.YsbP7fHB-lkp@…) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250814/202508140732.YsbP7fHB-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202508140732.YsbP7fHB-lkp@intel.com/ All warnings (new ones prefixed by >>): >> arch/x86/kernel/cpu/mce/inject.o: warning: objtool: missing symbol for section .exit.text -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0