November 2024 - Kernel - mailweb.openeuler.org

[PATCH OLK-6.6] rseq/mm_cid: change KABI consistency interface
by He Yujie 22 Nov '24

22 Nov '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IB1OJX -------------------------------- The KABI consistency interface of the mmcid data structure is changed from KABI_REPLACE to KABI_DEPRECATE. Fixes: 7a35fa06727d ("rseq/mm_cid: change the mm_cid macro default status and keep KABI consistent") Signed-off-by: He Yujie <coka.heyujie(a)huawei.com> --- include/linux/mm_types.h | 5 ++--- include/linux/sched.h | 11 +++++------ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index fdc047bdbc49..4b9a8723d3eb 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -788,9 +788,8 @@ struct mm_struct { */ unsigned long mm_cid_next_scan; #else - KABI_REPLACE(struct mm_cid __percpu *pcpu_cid, - struct mm_cid __percpu *pcpu_cid) - KABI_REPLACE(unsigned long mm_cid_next_scan, unsigned long mm_cid_next_scan) + KABI_DEPRECATE(struct mm_cid __percpu *, pcpu_cid) + KABI_DEPRECATE(unsigned long, mm_cid_next_scan) #endif #ifdef CONFIG_MMU atomic_long_t pgtables_bytes; /* size of all page tables */ diff --git a/include/linux/sched.h b/include/linux/sched.h index b8be76b0c120..b8abb84382db 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1358,12 +1358,11 @@ struct task_struct { int mm_cid_active; /* Whether cid bitmap is active */ struct callback_head cid_work; #else - KABI_REPLACE(int mm_cid, int mm_cid) - KABI_REPLACE(int last_mm_cid, int last_mm_cid) - KABI_REPLACE(int migrate_from_cpu, int migrate_from_cpu) - KABI_REPLACE(int mm_cid_active, int mm_cid_active) - KABI_REPLACE(struct callback_head cid_work, - struct callback_head cid_work) + KABI_DEPRECATE(int, mm_cid) + KABI_DEPRECATE(int, last_mm_cid) + KABI_DEPRECATE(int, migrate_from_cpu) + KABI_DEPRECATE(int, mm_cid_active) + KABI_DEPRECATE(struct callback_head, cid_work) #endif struct tlbflush_unmap_batch tlb_ubc; -- 2.34.1

2 1

[PATCH OLK-6.6] ima: rot: remove misguiding message printing
by GONG Ruiqi 22 Nov '24

22 Nov '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/IB5YWN CVE: NA -------------------------------- Remove the ".. failed to self-initialize" printing following the failure of an RoT candidate's initialization, as it may raise unnessary concerns from users, who may be misguided and think this message indicates some sort of serious problems. Fixes: 036012386e44 ("ima: rot: Introduce basic framework") Signed-off-by: GONG Ruiqi <gongruiqi1(a)huawei.com> --- security/integrity/ima/ima_rot.c | 1 - 1 file changed, 1 deletion(-) diff --git a/security/integrity/ima/ima_rot.c b/security/integrity/ima/ima_rot.c index 45d2ea314790..9c73389e2220 100644 --- a/security/integrity/ima/ima_rot.c +++ b/security/integrity/ima/ima_rot.c @@ -79,7 +79,6 @@ struct ima_rot * __init ima_rot_init(void) pr_info("%s initialized and taken as IMA RoT\n", ima_rots[i].name); return &ima_rots[i]; } - pr_info("%s failed to self-initialize\n", ima_rots[i].name); } return NULL; -- 2.25.1

2 1

[openeuler:openEuler-1.0-LTS 1304/1304] drivers/mailbox/qcom-apcs-ipc-mailbox.c:65:35: warning: 'apcs_clk_match_table' defined but not used
by kernel test robot 22 Nov '24

22 Nov '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 81e029d5dd0cae934243168eee37ef303ebcce38 commit: c41cf355c959721c7269cc5ee7c6901cb47424a7 [1304/1304] mbox: qcom: add APCS child device for QCS404 config: x86_64-buildonly-randconfig-001-20241122 (https://download.01.org/0day-ci/archive/20241122/202411220931.AgGtoYjF-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220931.AgGtoYjF-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411220931.AgGtoYjF-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/mailbox/qcom-apcs-ipc-mailbox.c: In function 'qcom_apcs_ipc_probe': drivers/mailbox/qcom-apcs-ipc-mailbox.c:65:35: warning: unused variable 'apcs_clk_match_table' [-Wunused-variable] 65 | const struct of_device_id apcs_clk_match_table[] = { | ^~~~~~~~~~~~~~~~~~~~ drivers/mailbox/qcom-apcs-ipc-mailbox.c: At top level: >> drivers/mailbox/qcom-apcs-ipc-mailbox.c:65:35: warning: 'apcs_clk_match_table' defined but not used [-Wunused-const-variable=] vim +/apcs_clk_match_table +65 drivers/mailbox/qcom-apcs-ipc-mailbox.c 55 56 static int qcom_apcs_ipc_probe(struct platform_device *pdev) 57 { 58 struct qcom_apcs_ipc *apcs; 59 struct regmap *regmap; 60 struct resource *res; 61 unsigned long offset; 62 void __iomem *base; 63 unsigned long i; 64 int ret; > 65 const struct of_device_id apcs_clk_match_table[] = { 66 { .compatible = "qcom,msm8916-apcs-kpss-global", }, 67 { .compatible = "qcom,qcs404-apcs-apps-global", }, 68 {} 69 }; 70 71 apcs = devm_kzalloc(&pdev->dev, sizeof(*apcs), GFP_KERNEL); 72 if (!apcs) 73 return -ENOMEM; 74 75 res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 76 base = devm_ioremap_resource(&pdev->dev, res); 77 if (IS_ERR(base)) 78 return PTR_ERR(base); 79 80 regmap = devm_regmap_init_mmio(&pdev->dev, base, &apcs_regmap_config); 81 if (IS_ERR(regmap)) 82 return PTR_ERR(regmap); 83 84 offset = (unsigned long)of_device_get_match_data(&pdev->dev); 85 86 apcs->regmap = regmap; 87 apcs->offset = offset; 88 89 /* Initialize channel identifiers */ 90 for (i = 0; i < ARRAY_SIZE(apcs->mbox_chans); i++) 91 apcs->mbox_chans[i].con_priv = (void *)i; 92 93 apcs->mbox.dev = &pdev->dev; 94 apcs->mbox.ops = &qcom_apcs_ipc_ops; 95 apcs->mbox.chans = apcs->mbox_chans; 96 apcs->mbox.num_chans = ARRAY_SIZE(apcs->mbox_chans); 97 98 ret = mbox_controller_register(&apcs->mbox); 99 if (ret) { 100 dev_err(&pdev->dev, "failed to register APCS IPC controller\n"); 101 return ret; 102 } 103 104 if (of_match_device(apcs_clk_match_table, &pdev->dev)) { 105 apcs->clk = platform_device_register_data(&pdev->dev, 106 "qcom-apcs-msm8916-clk", 107 -1, NULL, 0); 108 if (IS_ERR(apcs->clk)) 109 dev_err(&pdev->dev, "failed to register APCS clk\n"); 110 } 111 112 platform_set_drvdata(pdev, apcs); 113 114 return 0; 115 } 116 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS] BUILD REGRESSION 81e029d5dd0cae934243168eee37ef303ebcce38
by kernel test robot 22 Nov '24

22 Nov '24

tree/branch: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS branch HEAD: 81e029d5dd0cae934243168eee37ef303ebcce38 !13346 nilfs2: propagate directory read errors from nilfs_find_entry() Error/Warning (recently discovered and may have been fixed): https://lore.kernel.org/oe-kbuild-all/202411212153.Ajpai55I-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202411220134.YWoog3yH-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202411220413.5RZED7zc-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202411220702.De8xAify-lkp@intel.com drivers/regulator/qcom-rpmh-regulator.c:742:34: warning: unused variable 'rpmh_regulator_match_table' [-Wunused-const-variable] Error/Warning ids grouped by kconfigs: recent_errors |-- arm64-allmodconfig | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- arm64-randconfig-001-20241121 | |-- drivers-clocksource-arm_arch_timer.c:error:hisi_161010101_read_cntvct_el0-undeclared-(first-use-in-this-function) | |-- drivers-iommu-arm-smmu-v3.c:error:CONFIG_CMA_ALIGNMENT-undeclared-(first-use-in-this-function) | |-- drivers-misc-uacce-uacce.c:error:implicit-declaration-of-function-module_refcount | `-- include-linux-kernel.h:error:first-argument-to-__builtin_choose_expr-not-a-constant |-- arm64-randconfig-002-20241121 | |-- drivers-misc-uacce-uacce.c:error:implicit-declaration-of-function-module_refcount | |-- fs-ext4-inode.c:warning:unused-variable-sbi | `-- include-linux-uaccess.h:warning:sve-may-be-used-uninitialized |-- arm64-randconfig-003-20241121 | |-- arch-arm64-kernel-acpi.c:warning:no-previous-prototype-for-acpi_map_cpu | |-- arch-arm64-kernel-acpi.c:warning:no-previous-prototype-for-acpi_unmap_cpu | |-- drivers-iommu-arm-smmu-v3.c:error:CONFIG_CMA_ALIGNMENT-undeclared-(first-use-in-this-function) | |-- drivers-misc-uacce-uacce.c:error:implicit-declaration-of-function-module_refcount | |-- drivers-nvme-host-core.c:error:compat_uptr_t-undeclared-(first-use-in-this-function) | |-- drivers-nvme-host-core.c:error:expected-before-ptrval | |-- fs-ext4-inode.c:warning:unused-variable-sbi | `-- include-linux-kernel.h:error:first-argument-to-__builtin_choose_expr-not-a-constant |-- arm64-randconfig-004-20241121 | |-- drivers-iommu-arm-smmu-v3.c:error:CONFIG_CMA_ALIGNMENT-undeclared-(first-use-in-this-function) | |-- drivers-misc-uacce-uacce.c:error:implicit-declaration-of-function-module_refcount | `-- include-linux-kernel.h:error:first-argument-to-__builtin_choose_expr-not-a-constant |-- x86_64-allyesconfig | |-- drivers-net-ethernet-stmicro-stmmac-dwmac-phytium.c:error:incompatible-pointer-to-integer-conversion-returning-void-from-a-function-with-result-type-int | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-buildonly-randconfig-001-20241122 | |-- drivers-misc-uacce-uacce.c:error:implicit-declaration-of-function-module_refcount | |-- fs-ext4-inode.c:warning:unused-variable-sbi | `-- include-asm-generic-bug.h:warning:mcu_ctrl-may-be-used-uninitialized |-- x86_64-buildonly-randconfig-002-20241117 | `-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-.tmp_amdgpu_dm_crc.o:warning:objtool:missing-symbol-for-section-.text |-- x86_64-buildonly-randconfig-002-20241122 | |-- sound-isa-gus-gus_io.o:warning:objtool:missing-symbol-for-section-.text | `-- sound-isa-gus-gus_volume.o:warning:objtool:missing-symbol-for-section-.text |-- x86_64-buildonly-randconfig-003-20241122 | |-- crypto-cts.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- crypto-lzo.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-cpufreq-cpufreq_conservative.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-fpga-socfpga-a10.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-hwtracing-intel_th-core.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-hwtracing-intel_th-gth.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-hwtracing-intel_th-msu-sink.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-hwtracing-intel_th-pti.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-i2c-busses-i2c-dln2.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-i2c-busses-i2c-jz4780.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-iio-adc-axp288_adc.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-iio-adc-qcom-pm8xxx-xoadc.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-iio-dac-stm32-dac-core.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-iio-dac-stm32-dac.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-iio-humidity-hts221_i2c.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-iio-light-adjd_s311.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-iio-light-tcs3472.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-iio-pressure-ms5611_i2c.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-iio-proximity-sx9500.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-iio-temperature-tmp006.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-joydev.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-misc-axp2-pek.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-misc-cm109.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-misc-e3x0-button.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-misc-gpio-beeper.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-misc-mc13783-pwrbutton.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-misc-pm8xxx-vibrator.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-misc-pmic8xxx-pwrkey.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-misc-tps65218-pwrbutton.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-misc-twl4030-pwrbutton.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-input-misc-wm831x-on.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-leds-leds-as3645a.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-leds-leds-lp5521.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-leds-uleds.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-mailbox-mailbox-test.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-mfd-bcm59x.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-mtd-redboot.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-mtd-tests-mtd_nandecctest.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-mtd-tests-pagetest.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-mtd-tests-stresstest.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-phy-samsung-phy-exynos-dp-video.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-pinctrl-pinctrl-axp209.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-power-supply-bq27xxx_battery_i2c.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-power-supply-ltc2941-battery-gauge.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-regulator-max8952.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-regulator-mc13892-regulator.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-regulator-pv88080-regulator.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-regulator-tps65217-regulator.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-slimbus-qcom-ctrl.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-ssb-main.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-thermal-rockchip_thermal.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-usb-host-ehci-platform.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-usb-host-r8a66597-hcd.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-usb-host-ssb-hcd.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-usb-misc-ehset.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-usb-misc-sisusbvga-sisusb.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-usb-misc-yurex.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-usb-phy-phy-generic.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-usb-typec-tps6598x.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-w1-slaves-w1_ds2405.o:warning:objtool:missing-symbol-for-section-.exit.text | `-- samples-rpmsg-rpmsg_client_sample.o:warning:objtool:missing-symbol-for-section-.exit.text |-- x86_64-buildonly-randconfig-004-20241117 | |-- drivers-mfd-rohm-bd718x7.o:warning:objtool:missing-symbol-for-section-.init.text | `-- drivers-watchdog-menz69_wdt.o:warning:objtool:missing-symbol-for-section-.init.text |-- x86_64-buildonly-randconfig-004-20241122 | |-- drivers-dax-bus.o:warning:objtool:missing-symbol-for-section-.exit.text | |-- drivers-misc-uacce-uacce.c:error:implicit-declaration-of-function-module_refcount | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-buildonly-randconfig-005-20241117 | |-- drivers-char-hw_random-zhaoxin-rng.o:warning:objtool:missing-symbol-for-section-.exit.text | `-- drivers-hwtracing-intel_th-msu-sink.o:warning:objtool:missing-symbol-for-section-.exit.text |-- x86_64-buildonly-randconfig-005-20241122 | `-- drivers-regulator-qcom-rpmh-regulator.c:warning:unused-variable-rpmh_regulator_match_table |-- x86_64-buildonly-randconfig-006-20241118 | `-- drivers-spi-spi-uniphier.o:warning:objtool:missing-symbol-for-section-.init.text |-- x86_64-buildonly-randconfig-006-20241122 | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-defconfig | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-kexec | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-randconfig-001-20241122 | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-randconfig-002-20241122 | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-randconfig-003-20241122 | `-- arch-x86-events-zhaoxin-core.c:error:redefinition-of-zhaoxin_pmu_init |-- x86_64-randconfig-004-20241122 | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-randconfig-006-20241122 | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-randconfig-011-20241122 | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-randconfig-161-20241122 | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-rhel-9.4 | |-- drivers-net-can-usb-kvaser_usb-kvaser_usb_hydra.c:warning:new_state-may-be-used-uninitialized | `-- fs-ext4-inode.c:warning:unused-variable-sbi |-- x86_64-rhel-9.4-func | `-- fs-ext4-inode.c:warning:unused-variable-sbi `-- x86_64-rhel-9.4-kselftests `-- fs-ext4-inode.c:warning:unused-variable-sbi elapsed time: 772m configs tested: 26 configs skipped: 138 tested configs: arm64 allmodconfig gcc-14.2.0 arm64 allnoconfig gcc-14.2.0 arm64 randconfig-001-20241121 gcc-14.2.0 arm64 randconfig-002-20241121 gcc-14.2.0 arm64 randconfig-003-20241121 gcc-14.2.0 arm64 randconfig-004-20241121 gcc-14.2.0 x86_64 allnoconfig clang-19 x86_64 allyesconfig clang-19 x86_64 buildonly-randconfig-001-20241122 gcc-12 x86_64 buildonly-randconfig-002-20241122 clang-19 x86_64 buildonly-randconfig-003-20241122 gcc-12 x86_64 buildonly-randconfig-004-20241122 gcc-12 x86_64 buildonly-randconfig-005-20241122 clang-19 x86_64 buildonly-randconfig-006-20241122 gcc-12 x86_64 defconfig gcc-11 x86_64 kexec clang-19 x86_64 randconfig-001-20241122 gcc-12 x86_64 randconfig-002-20241122 clang-19 x86_64 randconfig-003-20241122 gcc-12 x86_64 randconfig-004-20241122 clang-19 x86_64 randconfig-005-20241122 gcc-12 x86_64 randconfig-006-20241122 clang-19 x86_64 randconfig-011-20241122 clang-19 x86_64 rhel-9.4 gcc-12 x86_64 rhel-9.4-func gcc-12 x86_64 rhel-9.4-kselftests gcc-12 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 1304/1304] drivers/regulator/qcom-rpmh-regulator.c:742:34: warning: unused variable 'rpmh_regulator_match_table'
by kernel test robot 22 Nov '24

22 Nov '24

Hi David, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 81e029d5dd0cae934243168eee37ef303ebcce38 commit: 46fc033eba42f5a4fb583b2ab53f0a9918468452 [1304/1304] regulator: add QCOM RPMh regulator driver config: x86_64-buildonly-randconfig-005-20241122 (https://download.01.org/0day-ci/archive/20241122/202411220702.De8xAify-lkp@…) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220702.De8xAify-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411220702.De8xAify-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/regulator/qcom-rpmh-regulator.c:742:34: warning: unused variable 'rpmh_regulator_match_table' [-Wunused-const-variable] 742 | static const struct of_device_id rpmh_regulator_match_table[] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. drivers/regulator/qcom-rpmh-regulator.c:33: warning: Enum value 'VRM' not described in enum 'rpmh_regulator_type' drivers/regulator/qcom-rpmh-regulator.c:33: warning: Enum value 'XOB' not described in enum 'rpmh_regulator_type' drivers/regulator/qcom-rpmh-regulator.c:402: warning: Function parameter or member 'vreg' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:402: warning: Function parameter or member 'dev' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:402: warning: Function parameter or member 'node' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:402: warning: Function parameter or member 'pmic_id' not described in 'rpmh_regulator_init_vreg' drivers/regulator/qcom-rpmh-regulator.c:402: warning: Function parameter or member 'pmic_rpmh_data' not described in 'rpmh_regulator_init_vreg' vim +/rpmh_regulator_match_table +742 drivers/regulator/qcom-rpmh-regulator.c 741 > 742 static const struct of_device_id rpmh_regulator_match_table[] = { 743 { 744 .compatible = "qcom,pm8998-rpmh-regulators", 745 .data = pm8998_vreg_data, 746 }, 747 { 748 .compatible = "qcom,pmi8998-rpmh-regulators", 749 .data = pmi8998_vreg_data, 750 }, 751 { 752 .compatible = "qcom,pm8005-rpmh-regulators", 753 .data = pm8005_vreg_data, 754 }, 755 {} 756 }; 757 MODULE_DEVICE_TABLE(of, rpmh_regulator_match_table); 758 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 1297/1297] drivers/char/hw_random/zhaoxin-rng.o: warning: objtool: missing symbol for section .exit.text
by kernel test robot 22 Nov '24

22 Nov '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 81e029d5dd0cae934243168eee37ef303ebcce38 commit: 050ff2f361bf733d1dde505dea8b0f5ecb23507c [1297/1297] hwrng: Add Zhaoxin rng driver config: x86_64-buildonly-randconfig-005-20241117 (https://download.01.org/0day-ci/archive/20241122/202411220413.5RZED7zc-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220413.5RZED7zc-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411220413.5RZED7zc-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/char/hw_random/zhaoxin-rng.o: warning: objtool: missing symbol for section .exit.text -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 2462/2462] drivers/firmware/efi/libstub/../../../../lib/decompress_unlzo.c:46:12: warning: variable 'level' set but not used
by kernel test robot 22 Nov '24

22 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: e4ad5a7cc835421f3f2799db98ef2f9d5143f076 commit: e467807275555a062593aa1e89f3201644ef0ea5 [2462/2462] efi/libstub: implement generic EFI zboot config: arm64-randconfig-003-20241121 (https://download.01.org/0day-ci/archive/20241122/202411220334.X00IT0yA-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220334.X00IT0yA-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411220334.X00IT0yA-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from drivers/firmware/efi/libstub/zboot.c:21: drivers/firmware/efi/libstub/../../../../lib/decompress_unlzo.c: In function 'parse_header': >> drivers/firmware/efi/libstub/../../../../lib/decompress_unlzo.c:46:12: warning: variable 'level' set but not used [-Wunused-but-set-variable] 46 | u8 level = 0; | ^~~~~ drivers/firmware/efi/libstub/zboot.c: At top level: drivers/firmware/efi/libstub/zboot.c:162:1: warning: no previous prototype for 'efi_zboot_entry' [-Wmissing-prototypes] 162 | efi_zboot_entry(efi_handle_t handle, efi_system_table_t *systab) | ^~~~~~~~~~~~~~~ vim +/level +46 drivers/firmware/efi/libstub/../../../../lib/decompress_unlzo.c 7dd65feb6c603e Albin Tonnerre 2010-01-08 40 d97b07c54f34e8 Yinghai Lu 2014-08-08 41 STATIC inline long INIT parse_header(u8 *input, long *skip, long in_len) 7dd65feb6c603e Albin Tonnerre 2010-01-08 42 { 7dd65feb6c603e Albin Tonnerre 2010-01-08 43 int l; 7dd65feb6c603e Albin Tonnerre 2010-01-08 44 u8 *parse = input; 5a3f81a7029daf Lasse Collin 2011-01-12 45 u8 *end = input + in_len; 7dd65feb6c603e Albin Tonnerre 2010-01-08 @46 u8 level = 0; 7dd65feb6c603e Albin Tonnerre 2010-01-08 47 u16 version; 7dd65feb6c603e Albin Tonnerre 2010-01-08 48 5a3f81a7029daf Lasse Collin 2011-01-12 49 /* 5a3f81a7029daf Lasse Collin 2011-01-12 50 * Check that there's enough input to possibly have a valid header. 5a3f81a7029daf Lasse Collin 2011-01-12 51 * Then it is possible to parse several fields until the minimum 5a3f81a7029daf Lasse Collin 2011-01-12 52 * size may have been used. 5a3f81a7029daf Lasse Collin 2011-01-12 53 */ 5a3f81a7029daf Lasse Collin 2011-01-12 54 if (in_len < HEADER_SIZE_MIN) 5a3f81a7029daf Lasse Collin 2011-01-12 55 return 0; 5a3f81a7029daf Lasse Collin 2011-01-12 56 7dd65feb6c603e Albin Tonnerre 2010-01-08 57 /* read magic: 9 first bits */ 7dd65feb6c603e Albin Tonnerre 2010-01-08 58 for (l = 0; l < 9; l++) { 7dd65feb6c603e Albin Tonnerre 2010-01-08 59 if (*parse++ != lzop_magic[l]) 7dd65feb6c603e Albin Tonnerre 2010-01-08 60 return 0; 7dd65feb6c603e Albin Tonnerre 2010-01-08 61 } 7dd65feb6c603e Albin Tonnerre 2010-01-08 62 /* get version (2bytes), skip library version (2), 7dd65feb6c603e Albin Tonnerre 2010-01-08 63 * 'need to be extracted' version (2) and 7dd65feb6c603e Albin Tonnerre 2010-01-08 64 * method (1) */ 7dd65feb6c603e Albin Tonnerre 2010-01-08 65 version = get_unaligned_be16(parse); 7dd65feb6c603e Albin Tonnerre 2010-01-08 66 parse += 7; 7dd65feb6c603e Albin Tonnerre 2010-01-08 67 if (version >= 0x0940) 7dd65feb6c603e Albin Tonnerre 2010-01-08 68 level = *parse++; 7dd65feb6c603e Albin Tonnerre 2010-01-08 69 if (get_unaligned_be32(parse) & HEADER_HAS_FILTER) 7dd65feb6c603e Albin Tonnerre 2010-01-08 70 parse += 8; /* flags + filter info */ 7dd65feb6c603e Albin Tonnerre 2010-01-08 71 else 7dd65feb6c603e Albin Tonnerre 2010-01-08 72 parse += 4; /* flags */ 7dd65feb6c603e Albin Tonnerre 2010-01-08 73 5a3f81a7029daf Lasse Collin 2011-01-12 74 /* 5a3f81a7029daf Lasse Collin 2011-01-12 75 * At least mode, mtime_low, filename length, and checksum must 5a3f81a7029daf Lasse Collin 2011-01-12 76 * be left to be parsed. If also mtime_high is present, it's OK 5a3f81a7029daf Lasse Collin 2011-01-12 77 * because the next input buffer check is after reading the 5a3f81a7029daf Lasse Collin 2011-01-12 78 * filename length. 5a3f81a7029daf Lasse Collin 2011-01-12 79 */ 5a3f81a7029daf Lasse Collin 2011-01-12 80 if (end - parse < 8 + 1 + 4) 5a3f81a7029daf Lasse Collin 2011-01-12 81 return 0; 5a3f81a7029daf Lasse Collin 2011-01-12 82 7dd65feb6c603e Albin Tonnerre 2010-01-08 83 /* skip mode and mtime_low */ 7dd65feb6c603e Albin Tonnerre 2010-01-08 84 parse += 8; 7dd65feb6c603e Albin Tonnerre 2010-01-08 85 if (version >= 0x0940) 7dd65feb6c603e Albin Tonnerre 2010-01-08 86 parse += 4; /* skip mtime_high */ 7dd65feb6c603e Albin Tonnerre 2010-01-08 87 7dd65feb6c603e Albin Tonnerre 2010-01-08 88 l = *parse++; 7dd65feb6c603e Albin Tonnerre 2010-01-08 89 /* don't care about the file name, and skip checksum */ 5a3f81a7029daf Lasse Collin 2011-01-12 90 if (end - parse < l + 4) 5a3f81a7029daf Lasse Collin 2011-01-12 91 return 0; 7dd65feb6c603e Albin Tonnerre 2010-01-08 92 parse += l + 4; 7dd65feb6c603e Albin Tonnerre 2010-01-08 93 7dd65feb6c603e Albin Tonnerre 2010-01-08 94 *skip = parse - input; 7dd65feb6c603e Albin Tonnerre 2010-01-08 95 return 1; 7dd65feb6c603e Albin Tonnerre 2010-01-08 96 } 7dd65feb6c603e Albin Tonnerre 2010-01-08 97 :::::: The code at line 46 was first introduced by commit :::::: 7dd65feb6c603e13eba501c34c662259ab38e70e lib: add support for LZO-compressed kernels :::::: TO: Albin Tonnerre <albin.tonnerre(a)free-electrons.com> :::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1513/1513] mm/memory.c:5277:17: warning: variable 'nr_pages' set but not used
by kernel test robot 22 Nov '24

22 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: ab293c3a32ba6594fd24cd7ecd4a4a00ede0cd65 commit: 3bfa35ccde9e52ca74fed047eb4d89be32dd9e5e [1513/1513] mm/numa: no task_numa_fault() call if PTE is changed config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241122/202411220229.ELIipVRO-lkp@…) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220229.ELIipVRO-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411220229.ELIipVRO-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from mm/memory.c:43: In file included from include/linux/mm.h:2247: include/linux/vmstat.h:508:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 508 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 509 | item]; | ~~~~ include/linux/vmstat.h:515:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 515 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 516 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:527:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 527 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 528 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:536:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 536 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 537 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ In file included from mm/memory.c:44: include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 47 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~ ^ ~~~ include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 49 | NR_ZONE_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~~~~~~ ^ ~~~ >> mm/memory.c:5277:17: warning: variable 'nr_pages' set but not used [-Wunused-but-set-variable] 5277 | int flags = 0, nr_pages; | ^ 8 warnings generated. vim +/nr_pages +5277 mm/memory.c f569661eacc258 Baolin Wang 2024-05-11 5266 2b7403035459c7 Souptick Joarder 2018-08-23 5267 static vm_fault_t do_numa_page(struct vm_fault *vmf) d10e63f29488b0 Mel Gorman 2012-10-25 5268 { 82b0f8c39a3869 Jan Kara 2016-12-14 5269 struct vm_area_struct *vma = vmf->vma; d5e6c8d5790088 Kefeng Wang 2023-11-27 5270 struct folio *folio = NULL; d5e6c8d5790088 Kefeng Wang 2023-11-27 5271 int nid = NUMA_NO_NODE; 2cb37064a2b82c Baolin Wang 2024-06-22 5272 bool writable = false, ignore_writable = false; 2cb37064a2b82c Baolin Wang 2024-06-22 5273 bool pte_write_upgrade = vma_wants_manual_pte_write_upgrade(vma); 90572890d20252 Peter Zijlstra 2013-10-07 5274 int last_cpupid; cbee9f88ec1b8d Peter Zijlstra 2012-10-25 5275 int target_nid; 04a8645304500b Aneesh Kumar K.V 2019-03-05 5276 pte_t pte, old_pte; 2cb37064a2b82c Baolin Wang 2024-06-22 @5277 int flags = 0, nr_pages; d10e63f29488b0 Mel Gorman 2012-10-25 5278 d10e63f29488b0 Mel Gorman 2012-10-25 5279 /* e2491c31fb10ae John Hubbard 2024-05-25 5280 * The pte cannot be used safely until we verify, while holding the page e2491c31fb10ae John Hubbard 2024-05-25 5281 * table lock, that its contents have not changed during fault handling. d10e63f29488b0 Mel Gorman 2012-10-25 5282 */ 82b0f8c39a3869 Jan Kara 2016-12-14 5283 spin_lock(vmf->ptl); e2491c31fb10ae John Hubbard 2024-05-25 5284 /* Read the live PTE from the page tables: */ e2491c31fb10ae John Hubbard 2024-05-25 5285 old_pte = ptep_get(vmf->pte); e2491c31fb10ae John Hubbard 2024-05-25 5286 e2491c31fb10ae John Hubbard 2024-05-25 5287 if (unlikely(!pte_same(old_pte, vmf->orig_pte))) { 82b0f8c39a3869 Jan Kara 2016-12-14 5288 pte_unmap_unlock(vmf->pte, vmf->ptl); 3bfa35ccde9e52 Zi Yan 2024-08-09 5289 return 0; 4daae3b4b9e49b Mel Gorman 2012-11-02 5290 } 4daae3b4b9e49b Mel Gorman 2012-11-02 5291 04a8645304500b Aneesh Kumar K.V 2019-03-05 5292 pte = pte_modify(old_pte, vma->vm_page_prot); d10e63f29488b0 Mel Gorman 2012-10-25 5293 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5294 /* 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5295 * Detect now whether the PTE could be writable; this information 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5296 * is only valid while holding the PT lock. 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5297 */ 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5298 writable = pte_write(pte); 2cb37064a2b82c Baolin Wang 2024-06-22 5299 if (!writable && pte_write_upgrade && 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5300 can_change_pte_writable(vma, vmf->address, pte)) 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5301 writable = true; 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5302 d5e6c8d5790088 Kefeng Wang 2023-11-27 5303 folio = vm_normal_folio(vma, vmf->address, pte); d5e6c8d5790088 Kefeng Wang 2023-11-27 5304 if (!folio || folio_is_zone_device(folio)) b99a342d4f11a5 Huang Ying 2021-04-29 5305 goto out_map; d10e63f29488b0 Mel Gorman 2012-10-25 5306 6688cc05473b36 Peter Zijlstra 2013-10-07 5307 /* bea66fbd11af1c Mel Gorman 2015-03-25 5308 * Avoid grouping on RO pages in general. RO pages shouldn't hurt as bea66fbd11af1c Mel Gorman 2015-03-25 5309 * much anyway since they can be in shared cache state. This misses bea66fbd11af1c Mel Gorman 2015-03-25 5310 * the case where a mapping is writable but the process never writes bea66fbd11af1c Mel Gorman 2015-03-25 5311 * to it but pte_write gets cleared during protection updates and bea66fbd11af1c Mel Gorman 2015-03-25 5312 * pte_dirty has unpredictable behaviour between PTE scan updates, bea66fbd11af1c Mel Gorman 2015-03-25 5313 * background writeback, dirty balancing and application behaviour. bea66fbd11af1c Mel Gorman 2015-03-25 5314 */ 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5315 if (!writable) 6688cc05473b36 Peter Zijlstra 2013-10-07 5316 flags |= TNF_NO_GROUP; 6688cc05473b36 Peter Zijlstra 2013-10-07 5317 dabe1d992414a6 Rik van Riel 2013-10-07 5318 /* d5e6c8d5790088 Kefeng Wang 2023-11-27 5319 * Flag if the folio is shared between multiple address spaces. This dabe1d992414a6 Rik van Riel 2013-10-07 5320 * is later used when determining whether to group tasks together dabe1d992414a6 Rik van Riel 2013-10-07 5321 */ b8eba2d7e4a309 David Hildenbrand 2024-05-11 5322 if (folio_likely_mapped_shared(folio) && (vma->vm_flags & VM_SHARED)) dabe1d992414a6 Rik van Riel 2013-10-07 5323 flags |= TNF_SHARED; dabe1d992414a6 Rik van Riel 2013-10-07 5324 d5e6c8d5790088 Kefeng Wang 2023-11-27 5325 nid = folio_nid(folio); 2cb37064a2b82c Baolin Wang 2024-06-22 5326 nr_pages = folio_nr_pages(folio); 33024536bafd91 Huang Ying 2022-07-13 5327 /* 33024536bafd91 Huang Ying 2022-07-13 5328 * For memory tiering mode, cpupid of slow memory page is used 33024536bafd91 Huang Ying 2022-07-13 5329 * to record page access time. So use default value. 33024536bafd91 Huang Ying 2022-07-13 5330 */ 33024536bafd91 Huang Ying 2022-07-13 5331 if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) && d5e6c8d5790088 Kefeng Wang 2023-11-27 5332 !node_is_toptier(nid)) 33024536bafd91 Huang Ying 2022-07-13 5333 last_cpupid = (-1 & LAST_CPUPID_MASK); 33024536bafd91 Huang Ying 2022-07-13 5334 else 28e1ec746768bb Kefeng Wang 2023-11-27 5335 last_cpupid = folio_last_cpupid(folio); bf7c2ab764599b Kefeng Wang 2023-11-27 5336 target_nid = numa_migrate_prep(folio, vma, vmf->address, nid, &flags); 98fa15f34cb379 Anshuman Khandual 2019-03-05 5337 if (target_nid == NUMA_NO_NODE) { d5e6c8d5790088 Kefeng Wang 2023-11-27 5338 folio_put(folio); b99a342d4f11a5 Huang Ying 2021-04-29 5339 goto out_map; 4daae3b4b9e49b Mel Gorman 2012-11-02 5340 } b99a342d4f11a5 Huang Ying 2021-04-29 5341 pte_unmap_unlock(vmf->pte, vmf->ptl); 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5342 writable = false; 2cb37064a2b82c Baolin Wang 2024-06-22 5343 ignore_writable = true; 4daae3b4b9e49b Mel Gorman 2012-11-02 5344 4daae3b4b9e49b Mel Gorman 2012-11-02 5345 /* Migrate to the requested node */ d5e6c8d5790088 Kefeng Wang 2023-11-27 5346 if (migrate_misplaced_folio(folio, vma, target_nid)) { d5e6c8d5790088 Kefeng Wang 2023-11-27 5347 nid = target_nid; 6688cc05473b36 Peter Zijlstra 2013-10-07 5348 flags |= TNF_MIGRATED; 3bfa35ccde9e52 Zi Yan 2024-08-09 5349 task_numa_fault(last_cpupid, nid, 1, flags); 3bfa35ccde9e52 Zi Yan 2024-08-09 5350 return 0; 3bfa35ccde9e52 Zi Yan 2024-08-09 5351 } 3bfa35ccde9e52 Zi Yan 2024-08-09 5352 074c238177a75f Mel Gorman 2015-03-25 5353 flags |= TNF_MIGRATE_FAIL; c7ad08804fae5b Hugh Dickins 2023-06-08 5354 vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, c7ad08804fae5b Hugh Dickins 2023-06-08 5355 vmf->address, &vmf->ptl); c7ad08804fae5b Hugh Dickins 2023-06-08 5356 if (unlikely(!vmf->pte)) 3bfa35ccde9e52 Zi Yan 2024-08-09 5357 return 0; c33c794828f212 Ryan Roberts 2023-06-12 5358 if (unlikely(!pte_same(ptep_get(vmf->pte), vmf->orig_pte))) { b99a342d4f11a5 Huang Ying 2021-04-29 5359 pte_unmap_unlock(vmf->pte, vmf->ptl); d10e63f29488b0 Mel Gorman 2012-10-25 5360 return 0; 3bfa35ccde9e52 Zi Yan 2024-08-09 5361 } b99a342d4f11a5 Huang Ying 2021-04-29 5362 out_map: b99a342d4f11a5 Huang Ying 2021-04-29 5363 /* b99a342d4f11a5 Huang Ying 2021-04-29 5364 * Make it present again, depending on how arch implements b99a342d4f11a5 Huang Ying 2021-04-29 5365 * non-accessible ptes, some can allow access by kernel mode. b99a342d4f11a5 Huang Ying 2021-04-29 5366 */ 2cb37064a2b82c Baolin Wang 2024-06-22 5367 if (folio && folio_test_large(folio)) 2cb37064a2b82c Baolin Wang 2024-06-22 5368 numa_rebuild_large_mapping(vmf, vma, folio, pte, ignore_writable, 2cb37064a2b82c Baolin Wang 2024-06-22 5369 pte_write_upgrade); 2cb37064a2b82c Baolin Wang 2024-06-22 5370 else 2cb37064a2b82c Baolin Wang 2024-06-22 5371 numa_rebuild_single_mapping(vmf, vma, vmf->address, vmf->pte, 2cb37064a2b82c Baolin Wang 2024-06-22 5372 writable); b99a342d4f11a5 Huang Ying 2021-04-29 5373 pte_unmap_unlock(vmf->pte, vmf->ptl); 3bfa35ccde9e52 Zi Yan 2024-08-09 5374 3bfa35ccde9e52 Zi Yan 2024-08-09 5375 if (nid != NUMA_NO_NODE) 3bfa35ccde9e52 Zi Yan 2024-08-09 5376 task_numa_fault(last_cpupid, nid, 1, flags); 3bfa35ccde9e52 Zi Yan 2024-08-09 5377 return 0; d10e63f29488b0 Mel Gorman 2012-10-25 5378 } d10e63f29488b0 Mel Gorman 2012-10-25 5379 :::::: The code at line 5277 was first introduced by commit :::::: 2cb37064a2b82cd8ebeeaaed21259b5912dff51d mm: support multi-size THP numa balancing :::::: TO: Baolin Wang <baolin.wang(a)linux.alibaba.com> :::::: CC: Liu Shixin <liushixin2(a)huawei.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 1297/1297] drivers/watchdog/menz69_wdt.o: warning: objtool: missing symbol for section .init.text
by kernel test robot 22 Nov '24

22 Nov '24

Hi Johannes, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 81e029d5dd0cae934243168eee37ef303ebcce38 commit: 81ceed41d0c2b2c9300de7bc30c1451680257f52 [1297/1297] watchdog: add driver for the MEN 16z069 IP-Core config: x86_64-buildonly-randconfig-004-20241117 (https://download.01.org/0day-ci/archive/20241122/202411220134.YWoog3yH-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220134.YWoog3yH-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411220134.YWoog3yH-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from drivers/watchdog/menz69_wdt.c:10: include/linux/module.h:138:14: warning: 'cleanup_module' specifies less restrictive attribute than its target 'men_z069_driver_exit': 'cold' [-Wmissing-attributes] 138 | void cleanup_module(void) __attribute__((alias(#exitfn))); | ^~~~~~~~~~~~~~ include/linux/device.h:1558:1: note: in expansion of macro 'module_exit' 1558 | module_exit(__driver##_exit); | ^~~~~~~~~~~ include/linux/mcb.h:126:9: note: in expansion of macro 'module_driver' 126 | module_driver(__mcb_driver, mcb_register_driver, mcb_unregister_driver); | ^~~~~~~~~~~~~ drivers/watchdog/menz69_wdt.c:166:1: note: in expansion of macro 'module_mcb_driver' 166 | module_mcb_driver(men_z069_driver); | ^~~~~~~~~~~~~~~~~ In file included from include/linux/mcb.h:15, from drivers/watchdog/menz69_wdt.c:9: drivers/watchdog/menz69_wdt.c:166:19: note: 'cleanup_module' target declared here 166 | module_mcb_driver(men_z069_driver); | ^~~~~~~~~~~~~~~ include/linux/device.h:1554:20: note: in definition of macro 'module_driver' 1554 | static void __exit __driver##_exit(void) \ | ^~~~~~~~ drivers/watchdog/menz69_wdt.c:166:1: note: in expansion of macro 'module_mcb_driver' 166 | module_mcb_driver(men_z069_driver); | ^~~~~~~~~~~~~~~~~ include/linux/module.h:132:13: warning: 'init_module' specifies less restrictive attribute than its target 'men_z069_driver_init': 'cold' [-Wmissing-attributes] 132 | int init_module(void) __attribute__((alias(#initfn))); | ^~~~~~~~~~~ include/linux/device.h:1553:1: note: in expansion of macro 'module_init' 1553 | module_init(__driver##_init); \ | ^~~~~~~~~~~ include/linux/mcb.h:126:9: note: in expansion of macro 'module_driver' 126 | module_driver(__mcb_driver, mcb_register_driver, mcb_unregister_driver); | ^~~~~~~~~~~~~ drivers/watchdog/menz69_wdt.c:166:1: note: in expansion of macro 'module_mcb_driver' 166 | module_mcb_driver(men_z069_driver); | ^~~~~~~~~~~~~~~~~ drivers/watchdog/menz69_wdt.c:166:19: note: 'init_module' target declared here 166 | module_mcb_driver(men_z069_driver); | ^~~~~~~~~~~~~~~ include/linux/device.h:1549:19: note: in definition of macro 'module_driver' 1549 | static int __init __driver##_init(void) \ | ^~~~~~~~ drivers/watchdog/menz69_wdt.c:166:1: note: in expansion of macro 'module_mcb_driver' 166 | module_mcb_driver(men_z069_driver); | ^~~~~~~~~~~~~~~~~ >> drivers/watchdog/menz69_wdt.o: warning: objtool: missing symbol for section .init.text -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6] tpm: Lock TPM chip in tpm_pm_suspend() first
by Chen Zhongjin 21 Nov '24

21 Nov '24

From: Jarkko Sakkinen <jarkko(a)kernel.org> mainline inclusion from mainline-v6.12-rc1 commit 9265fed6db601ee2ec47577815387458ef4f047a category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IB5KRG CVE: CVE-2024-53085 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- Setting TPM_CHIP_FLAG_SUSPENDED in the end of tpm_pm_suspend() can be racy according, as this leaves window for tpm_hwrng_read() to be called while the operation is in progress. The recent bug report gives also evidence of this behaviour. Aadress this by locking the TPM chip before checking any chip->flags both in tpm_pm_suspend() and tpm_hwrng_read(). Move TPM_CHIP_FLAG_SUSPENDED check inside tpm_get_random() so that it will be always checked only when the lock is reserved. Cc: stable(a)vger.kernel.org # v6.4+ Fixes: 99d464506255 ("tpm: Prevent hwrng from activating during resume") Reported-by: Mike Seo <mikeseohyungjin(a)gmail.com> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219383 Reviewed-by: Jerry Snitselaar <jsnitsel(a)redhat.com> Tested-by: Mike Seo <mikeseohyungjin(a)gmail.com> Signed-off-by: Jarkko Sakkinen <jarkko(a)kernel.org> Conflicts: drivers/char/tpm/tpm-interface.c [df745e25098d ("tpm: Lazily flush the auth session") is not merged] Signed-off-by: Chen Zhongjin <chenzhongjin(a)huawei.com> --- drivers/char/tpm/tpm-chip.c | 4 ---- drivers/char/tpm/tpm-interface.c | 28 ++++++++++++++++++++-------- 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c index 42b1062e33cd5..78999f7f248cb 100644 --- a/drivers/char/tpm/tpm-chip.c +++ b/drivers/char/tpm/tpm-chip.c @@ -519,10 +519,6 @@ static int tpm_hwrng_read(struct hwrng *rng, void *data, size_t max, bool wait) { struct tpm_chip *chip = container_of(rng, struct tpm_chip, hwrng); - /* Give back zero bytes, as TPM chip has not yet fully resumed: */ - if (chip->flags & TPM_CHIP_FLAG_SUSPENDED) - return 0; - return tpm_get_random(chip, data, max); } diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index 66b16d26eecc7..9789aad5dd0df 100644 --- a/drivers/char/tpm/tpm-interface.c +++ b/drivers/char/tpm/tpm-interface.c @@ -394,6 +394,13 @@ int tpm_pm_suspend(struct device *dev) if (!chip) return -ENODEV; + rc = tpm_try_get_ops(chip); + if (rc) { + /* Can be safely set out of locks, as no action cannot race: */ + chip->flags |= TPM_CHIP_FLAG_SUSPENDED; + goto out; + } + if (chip->flags & TPM_CHIP_FLAG_ALWAYS_POWERED) goto suspended; @@ -401,18 +408,16 @@ int tpm_pm_suspend(struct device *dev) !pm_suspend_via_firmware()) goto suspended; - rc = tpm_try_get_ops(chip); - if (!rc) { - if (chip->flags & TPM_CHIP_FLAG_TPM2) - tpm2_shutdown(chip, TPM2_SU_STATE); - else - rc = tpm1_pm_suspend(chip, tpm_suspend_pcr); - - tpm_put_ops(chip); + if (chip->flags & TPM_CHIP_FLAG_TPM2) { + tpm2_shutdown(chip, TPM2_SU_STATE); + goto suspended; } + rc = tpm1_pm_suspend(chip, tpm_suspend_pcr); + suspended: chip->flags |= TPM_CHIP_FLAG_SUSPENDED; + tpm_put_ops(chip); if (rc) dev_err(dev, "Ignoring error %d while suspending\n", rc); @@ -462,11 +467,18 @@ int tpm_get_random(struct tpm_chip *chip, u8 *out, size_t max) if (!chip) return -ENODEV; + /* Give back zero bytes, as TPM chip has not yet fully resumed: */ + if (chip->flags & TPM_CHIP_FLAG_SUSPENDED) { + rc = 0; + goto out; + } + if (chip->flags & TPM_CHIP_FLAG_TPM2) rc = tpm2_get_random(chip, out, max); else rc = tpm1_get_random(chip, out, max); +out: tpm_put_ops(chip); return rc; } -- 2.25.1

2 1

2024

2023

2022

2021

2020

2019

Kernel November 2024