- Kernel - mailweb.openeuler.org

[openeuler:OLK-6.6 1636/1636] arch/loongarch/kernel/paravirt.c:85:24: error: 'KVM_HCALL_FUNC_PV_IPI' undeclared; did you mean 'KVM_HCALL_FUNC_IPI'?
by kernel test robot 14 Dec '24

14 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: d68dc6ee371ec5466be9b2d76bdca0b360940adc commit: dba6c8bad729e1971c31053550e9686127ce3844 [1636/1636] LoongArch: KVM: Add PV IPI support on host side config: loongarch-randconfig-002-20241213 (https://download.01.org/0day-ci/archive/20241214/202412140300.AvxBVNVW-lkp@…) compiler: loongarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241214/202412140300.AvxBVNVW-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412140300.AvxBVNVW-lkp@intel.com/ All errors (new ones prefixed by >>): arch/loongarch/kernel/paravirt.c: In function 'pv_send_ipi_single': >> arch/loongarch/kernel/paravirt.c:85:24: error: 'KVM_HCALL_FUNC_PV_IPI' undeclared (first use in this function); did you mean 'KVM_HCALL_FUNC_IPI'? 85 | kvm_hypercall3(KVM_HCALL_FUNC_PV_IPI, 1, 0, min); | ^~~~~~~~~~~~~~~~~~~~~ | KVM_HCALL_FUNC_IPI arch/loongarch/kernel/paravirt.c:85:24: note: each undeclared identifier is reported only once for each function it appears in arch/loongarch/kernel/paravirt.c: In function 'pv_send_ipi_mask': arch/loongarch/kernel/paravirt.c:119:40: error: 'KVM_HCALL_FUNC_PV_IPI' undeclared (first use in this function); did you mean 'KVM_HCALL_FUNC_IPI'? 119 | kvm_hypercall3(KVM_HCALL_FUNC_PV_IPI, | ^~~~~~~~~~~~~~~~~~~~~ | KVM_HCALL_FUNC_IPI vim +85 arch/loongarch/kernel/paravirt.c f860ab821dd12f5 Bibo Mao 2024-03-22 73 462dd429f52a765 Bibo Mao 2024-03-01 74 #ifdef CONFIG_SMP 462dd429f52a765 Bibo Mao 2024-03-01 75 static void pv_send_ipi_single(int cpu, unsigned int action) 462dd429f52a765 Bibo Mao 2024-03-01 76 { 462dd429f52a765 Bibo Mao 2024-03-01 77 unsigned int min, old; 462dd429f52a765 Bibo Mao 2024-03-01 78 irq_cpustat_t *info = &per_cpu(irq_stat, cpu); 462dd429f52a765 Bibo Mao 2024-03-01 79 462dd429f52a765 Bibo Mao 2024-03-01 80 old = atomic_fetch_or(BIT(action), &info->message); 462dd429f52a765 Bibo Mao 2024-03-01 81 if (old) 462dd429f52a765 Bibo Mao 2024-03-01 82 return; 462dd429f52a765 Bibo Mao 2024-03-01 83 462dd429f52a765 Bibo Mao 2024-03-01 84 min = cpu_logical_map(cpu); 462dd429f52a765 Bibo Mao 2024-03-01 @85 kvm_hypercall3(KVM_HCALL_FUNC_PV_IPI, 1, 0, min); 462dd429f52a765 Bibo Mao 2024-03-01 86 } 462dd429f52a765 Bibo Mao 2024-03-01 87 :::::: The code at line 85 was first introduced by commit :::::: 462dd429f52a7659ea1c74f02f7134a43fccccc8 LoongArch: Add pv ipi support on guest kernel side :::::: TO: Bibo Mao <maobibo(a)loongson.cn> :::::: CC: Xianglai Li <lixianglai(a)loongson.cn> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1636/1636] arch/loongarch/kvm/intc/pch_pic.c:459:16: warning: variable 'ret' set but not used
by kernel test robot 14 Dec '24

14 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: d68dc6ee371ec5466be9b2d76bdca0b360940adc commit: bd254ad9ed5fb35dc87b90f98ebb805567ff0472 [1636/1636] LoongArch: KVM: Add irqfd support config: loongarch-randconfig-001-20241213 (https://download.01.org/0day-ci/archive/20241214/202412140030.ws7cfuVO-lkp@…) compiler: loongarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241214/202412140030.ws7cfuVO-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412140030.ws7cfuVO-lkp@intel.com/ All warnings (new ones prefixed by >>): arch/loongarch/kvm/intc/pch_pic.c: In function 'kvm_setup_default_irq_routing': >> arch/loongarch/kvm/intc/pch_pic.c:459:16: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 459 | int i, ret; | ^~~ -- >> arch/loongarch/kvm/irqfd.c:81: warning: Function parameter or member 'e' not described in 'kvm_set_msi' >> arch/loongarch/kvm/irqfd.c:81: warning: Function parameter or member 'kvm' not described in 'kvm_set_msi' >> arch/loongarch/kvm/irqfd.c:81: warning: Function parameter or member 'irq_source_id' not described in 'kvm_set_msi' >> arch/loongarch/kvm/irqfd.c:81: warning: Function parameter or member 'level' not described in 'kvm_set_msi' >> arch/loongarch/kvm/irqfd.c:81: warning: Function parameter or member 'line_status' not described in 'kvm_set_msi' vim +/ret +459 arch/loongarch/kvm/intc/pch_pic.c 453 454 static int kvm_setup_default_irq_routing(struct kvm *kvm) 455 { 456 struct kvm_irq_routing_entry *entries; 457 458 u32 nr = KVM_IRQCHIP_NUM_PINS; > 459 int i, ret; 460 461 entries = kcalloc(nr, sizeof(*entries), GFP_KERNEL); 462 if (!entries) 463 return -ENOMEM; 464 465 for (i = 0; i < nr; i++) { 466 entries[i].gsi = i; 467 entries[i].type = KVM_IRQ_ROUTING_IRQCHIP; 468 entries[i].u.irqchip.irqchip = 0; 469 entries[i].u.irqchip.pin = i; 470 } 471 ret = kvm_set_irq_routing(kvm, entries, nr, 0); 472 kfree(entries); 473 474 return 0; 475 } 476 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1636/1636] arch/loongarch/kernel/paravirt.c:83:12: warning: 'paravt_steal_clock' defined but not used
by kernel test robot 13 Dec '24

13 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: d68dc6ee371ec5466be9b2d76bdca0b360940adc commit: 2ee1b090fed0f14944d85db83f5dbc33fbe812ec [1636/1636] LoongArch: KVM: Add PV steal time support in guest side config: loongarch-randconfig-002-20241213 (https://download.01.org/0day-ci/archive/20241213/202412132355.qfya7e74-lkp@…) compiler: loongarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241213/202412132355.qfya7e74-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412132355.qfya7e74-lkp@intel.com/ All warnings (new ones prefixed by >>): | ^~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:81:1: note: in expansion of macro 'early_param' 81 | early_param("no-steal-acc", parse_no_stealacc); | ^~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:111:12: error: redefinition of 'paravt_steal_clock' 111 | static u64 paravt_steal_clock(int cpu) | ^~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:83:12: note: previous definition of 'paravt_steal_clock' with type 'u64(int)' {aka 'long long unsigned int(int)'} 83 | static u64 paravt_steal_clock(int cpu) | ^~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c: In function 'pv_send_ipi_single': arch/loongarch/kernel/paravirt.c:141:24: error: 'KVM_HCALL_FUNC_PV_IPI' undeclared (first use in this function); did you mean 'KVM_HCALL_FUNC_IPI'? 141 | kvm_hypercall3(KVM_HCALL_FUNC_PV_IPI, 1, 0, min); | ^~~~~~~~~~~~~~~~~~~~~ | KVM_HCALL_FUNC_IPI arch/loongarch/kernel/paravirt.c:141:24: note: each undeclared identifier is reported only once for each function it appears in arch/loongarch/kernel/paravirt.c: In function 'pv_send_ipi_mask': arch/loongarch/kernel/paravirt.c:175:40: error: 'KVM_HCALL_FUNC_PV_IPI' undeclared (first use in this function); did you mean 'KVM_HCALL_FUNC_IPI'? 175 | kvm_hypercall3(KVM_HCALL_FUNC_PV_IPI, | ^~~~~~~~~~~~~~~~~~~~~ | KVM_HCALL_FUNC_IPI arch/loongarch/kernel/paravirt.c: At top level: arch/loongarch/kernel/paravirt.c:363:13: error: redefinition of 'pv_disable_steal_time' 363 | static void pv_disable_steal_time(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:224:13: note: previous definition of 'pv_disable_steal_time' with type 'void(void)' 224 | static void pv_disable_steal_time(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:393:13: error: redefinition of 'pv_cpu_reboot' 393 | static void pv_cpu_reboot(void *unused) | ^~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:289:13: note: previous definition of 'pv_cpu_reboot' with type 'void(void *)' 289 | static void pv_cpu_reboot(void *unused) | ^~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:398:12: error: redefinition of 'pv_reboot_notify' 398 | static int pv_reboot_notify(struct notifier_block *nb, unsigned long code, void *unused) | ^~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:294:12: note: previous definition of 'pv_reboot_notify' with type 'int(struct notifier_block *, long unsigned int, void *)' 294 | static int pv_reboot_notify(struct notifier_block *nb, unsigned long code, | ^~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:404:30: error: redefinition of 'pv_reboot_nb' 404 | static struct notifier_block pv_reboot_nb = { | ^~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:301:30: note: previous definition of 'pv_reboot_nb' with type 'struct notifier_block' 301 | static struct notifier_block pv_reboot_nb = { | ^~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:408:12: error: redefinition of 'pv_time_init' 408 | int __init pv_time_init(void) | ^~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:305:12: note: previous definition of 'pv_time_init' with type 'int(void)' 305 | int __init pv_time_init(void) | ^~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:453:12: error: redefinition of 'pv_enable_steal_time' 453 | static int pv_enable_steal_time(void) | ^~~~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:339:12: note: previous definition of 'pv_enable_steal_time' with type 'int(void)' 339 | static int pv_enable_steal_time(void) | ^~~~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:477:13: error: redefinition of 'pv_disable_steal_time' 477 | static void pv_disable_steal_time(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:363:13: note: previous definition of 'pv_disable_steal_time' with type 'void(void)' 363 | static void pv_disable_steal_time(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:484:12: error: redefinition of 'pv_time_cpu_online' 484 | static int pv_time_cpu_online(unsigned int cpu) | ^~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:370:12: note: previous definition of 'pv_time_cpu_online' with type 'int(unsigned int)' 370 | static int pv_time_cpu_online(unsigned int cpu) | ^~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:495:12: error: redefinition of 'pv_time_cpu_down_prepare' 495 | static int pv_time_cpu_down_prepare(unsigned int cpu) | ^~~~~~~~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:381:12: note: previous definition of 'pv_time_cpu_down_prepare' with type 'int(unsigned int)' 381 | static int pv_time_cpu_down_prepare(unsigned int cpu) | ^~~~~~~~~~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:507:13: error: redefinition of 'pv_cpu_reboot' 507 | static void pv_cpu_reboot(void *unused) | ^~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:393:13: note: previous definition of 'pv_cpu_reboot' with type 'void(void *)' 393 | static void pv_cpu_reboot(void *unused) | ^~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:512:12: error: redefinition of 'pv_reboot_notify' 512 | static int pv_reboot_notify(struct notifier_block *nb, unsigned long code, void *unused) | ^~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:398:12: note: previous definition of 'pv_reboot_notify' with type 'int(struct notifier_block *, long unsigned int, void *)' 398 | static int pv_reboot_notify(struct notifier_block *nb, unsigned long code, void *unused) | ^~~~~~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:518:30: error: redefinition of 'pv_reboot_nb' 518 | static struct notifier_block pv_reboot_nb = { | ^~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:404:30: note: previous definition of 'pv_reboot_nb' with type 'struct notifier_block' 404 | static struct notifier_block pv_reboot_nb = { | ^~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:522:12: error: redefinition of 'pv_time_init' 522 | int __init pv_time_init(void) | ^~~~~~~~~~~~ arch/loongarch/kernel/paravirt.c:305:12: note: previous definition of 'pv_time_init' with type 'int(void)' 305 | int __init pv_time_init(void) | ^~~~~~~~~~~~ >> arch/loongarch/kernel/paravirt.c:83:12: warning: 'paravt_steal_clock' defined but not used [-Wunused-function] 83 | static u64 paravt_steal_clock(int cpu) | ^~~~~~~~~~~~~~~~~~ vim +/paravt_steal_clock +83 arch/loongarch/kernel/paravirt.c 82 > 83 static u64 paravt_steal_clock(int cpu) 84 { 85 int version; 86 u64 steal; 87 struct kvm_steal_time *src; 88 89 src = &per_cpu(steal_time, cpu); 90 do { 91 92 version = src->version; 93 virt_rmb(); /* Make sure that the version is read before the steal */ 94 steal = src->steal; 95 virt_rmb(); /* Make sure that the steal is read before the next version */ 96 97 } while ((version & 1) || (version != src->version)); 98 99 return steal; 100 } 101 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1636/1636] arch/loongarch/kvm/vm.c:115:30: warning: variable 'vcpus' set but not used
by kernel test robot 13 Dec '24

13 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: d68dc6ee371ec5466be9b2d76bdca0b360940adc commit: 35da19c3c6d4b053eba09a0daa6063eae81e928a [1636/1636] LoongArch: KVM: Add PCHPIC read and write functions config: loongarch-randconfig-001-20241213 (https://download.01.org/0day-ci/archive/20241213/202412132352.24cSlwix-lkp@…) compiler: loongarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241213/202412132352.24cSlwix-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412132352.24cSlwix-lkp@intel.com/ All warnings (new ones prefixed by >>): arch/loongarch/kvm/vm.c: In function 'kvm_vm_ioctl_irq_line': >> arch/loongarch/kvm/vm.c:115:30: warning: variable 'vcpus' set but not used [-Wunused-but-set-variable] 115 | int type, vcpu, irq, vcpus, val, ret = 0; | ^~~~~ >> arch/loongarch/kvm/vm.c:115:19: warning: variable 'vcpu' set but not used [-Wunused-but-set-variable] 115 | int type, vcpu, irq, vcpus, val, ret = 0; | ^~~~ vim +/vcpus +115 arch/loongarch/kvm/vm.c 109 110 int kvm_vm_ioctl_irq_line(struct kvm *kvm, struct kvm_irq_level *data, 111 bool line_status) 112 { 113 bool level; 114 struct loongarch_pch_pic *s; > 115 int type, vcpu, irq, vcpus, val, ret = 0; -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 0/5] Backport some mm bugfix
by Jinjiang Tu 13 Dec '24

13 Dec '24

David Hildenbrand (1): mm/filemap: don't call folio_test_locked() without a reference in next_uptodate_folio() Hugh Dickins (1): mm: shmem: fix ShmemHugePages at swapout Kalesh Singh (1): mm: Respect mmap hint address when aligning for THP Matthew Wilcox (Oracle) (2): mm: open-code page_folio() in dump_page() mm: open-code PageTail in folio_flags() and const_folio_flags() include/linux/page-flags.h | 2 +- mm/debug.c | 7 +++++-- mm/filemap.c | 4 ++-- mm/mmap.c | 3 ++- mm/shmem.c | 22 ++++++++++++---------- 5 files changed, 22 insertions(+), 16 deletions(-) -- 2.34.1

2 6

[PATCH v2 OLK-6.6 0/2] kabi: restrict the KABI fix to a specific architecture and dist
by Xie XiuQi 13 Dec '24

13 Dec '24

Some distributions need to maintain and fix KABI compatibility so that drivers do not need to be recompiled during kernel upgrades. Fixing KABI compatibility is a dangerous and hacking job. Developers need to know clearly what they are doing and the risks they may face. KABI fix actions are closely related to the processor architecture. Fixes may not be appropriate for all architectures. Improper fix may cause kernel panic or unexpected error. Only for expert users, and select N by default. Xie XiuQi (2): kabi: restrict the KABI fix to a specific architecture and dist kabi: enable KABI_COMPAT series by default on x86_64 & ARM64 arch/arm64/configs/openeuler_defconfig | 5 ++-- arch/x86/configs/openeuler_defconfig | 5 ++-- include/linux/kabi.h | 2 +- init/Kconfig | 18 ++------------- lib/Kconfig.kabi | 32 ++++++++++++++++++++++++++ 5 files changed, 41 insertions(+), 21 deletions(-) create mode 100644 lib/Kconfig.kabi -- 2.20.1

2 3

[PATCH OLK-6.6 0/2] kabi: restrict the KABI fix to a specific architecture and dist
by Xie XiuQi 13 Dec '24

13 Dec '24

Some distributions need to maintain and fix KABI compatibility so that drivers do not need to be recompiled during kernel upgrades. Fixing KABI compatibility is a dangerous and hacking job. Developers need to know clearly what they are doing and the risks they may face. KABI fix actions are closely related to the processor architecture. Fixes may not be appropriate for all architectures. Improper fix may cause kernel panic or unexpected error. Only for expert users, and select N by default. Xie XiuQi (2): kabi: restrict the KABI fix to a specific architecture and dist kabi: enable KABI_COMPAT series by default on x86_64 & ARM64 arch/arm64/configs/openeuler_defconfig | 5 +-- arch/x86/configs/openeuler_defconfig | 5 +-- include/linux/kabi.h | 2 +- init/Kconfig | 49 +++++++++++++++++--------- 4 files changed, 40 insertions(+), 21 deletions(-) -- 2.20.1

2 4

[PATCH openEuler-1.0-LTS] padata: make padata_do_parallel find alternate callback CPU
by Yi Yang 13 Dec '24

13 Dec '24

From: Daniel Jordan <daniel.m.jordan(a)oracle.com> mainline inclusion from mainline-v5.4-rc1 commit e6ce0e0807e90d38a2cefa524ac253d7a85c3f2f category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I7RZMT CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- padata_do_parallel currently returns -EINVAL if the callback CPU isn't in the callback cpumask. pcrypt tries to prevent this situation by keeping its own callback cpumask in sync with padata's and checks that the callback CPU it passes to padata is valid. Make padata handle this instead. padata_do_parallel now takes a pointer to the callback CPU and updates it for the caller if an alternate CPU is used. Overall behavior in terms of which callback CPUs are chosen stays the same. Prepares for removal of the padata cpumask notifier in pcrypt, which will fix a lockdep complaint about nested acquisition of the CPU hotplug lock later in the series. Signed-off-by: Daniel Jordan <daniel.m.jordan(a)oracle.com> Acked-by: Steffen Klassert <steffen.klassert(a)secunet.com> Cc: Herbert Xu <herbert(a)gondor.apana.org.au> Cc: Lai Jiangshan <jiangshanlai(a)gmail.com> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Tejun Heo <tj(a)kernel.org> Cc: linux-crypto(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au> Conflicts: crypto/pcrypt.c include/linux/padata.h kernel/padata.c [Context conflict.] Signed-off-by: Yi Yang <yiyang13(a)huawei.com> --- crypto/pcrypt.c | 33 ++------------------------------- include/linux/padata.h | 2 +- kernel/padata.c | 27 ++++++++++++++++++++------- 3 files changed, 23 insertions(+), 39 deletions(-) diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c index 898a71c7386b..4542b48b5afd 100644 --- a/crypto/pcrypt.c +++ b/crypto/pcrypt.c @@ -70,35 +70,6 @@ struct pcrypt_aead_ctx { unsigned int cb_cpu; }; -static int pcrypt_do_parallel(struct padata_priv *padata, unsigned int *cb_cpu, - struct padata_pcrypt *pcrypt) -{ - unsigned int cpu_index, cpu, i; - struct pcrypt_cpumask *cpumask; - - cpu = *cb_cpu; - - rcu_read_lock_bh(); - cpumask = rcu_dereference_bh(pcrypt->cb_cpumask); - if (cpumask_test_cpu(cpu, cpumask->mask)) - goto out; - - if (!cpumask_weight(cpumask->mask)) - goto out; - - cpu_index = cpu % cpumask_weight(cpumask->mask); - - cpu = cpumask_first(cpumask->mask); - for (i = 0; i < cpu_index; i++) - cpu = cpumask_next(cpu, cpumask->mask); - - *cb_cpu = cpu; - -out: - rcu_read_unlock_bh(); - return padata_do_parallel(pcrypt->pinst, padata, cpu); -} - static int pcrypt_aead_setkey(struct crypto_aead *parent, const u8 *key, unsigned int keylen) { @@ -172,7 +143,7 @@ static int pcrypt_aead_encrypt(struct aead_request *req) req->cryptlen, req->iv); aead_request_set_ad(creq, req->assoclen); - err = pcrypt_do_parallel(padata, &ctx->cb_cpu, &pencrypt); + err = padata_do_parallel(pencrypt.pinst, padata, &ctx->cb_cpu); if (!err) return -EINPROGRESS; if (err == -EBUSY) { @@ -220,7 +191,7 @@ static int pcrypt_aead_decrypt(struct aead_request *req) req->cryptlen, req->iv); aead_request_set_ad(creq, req->assoclen); - err = pcrypt_do_parallel(padata, &ctx->cb_cpu, &pdecrypt); + err = padata_do_parallel(pdecrypt.pinst, padata, &ctx->cb_cpu); if (!err) return -EINPROGRESS; if (err == -EBUSY) { diff --git a/include/linux/padata.h b/include/linux/padata.h index d803397a28f7..8d2267926a64 100644 --- a/include/linux/padata.h +++ b/include/linux/padata.h @@ -167,7 +167,7 @@ extern struct padata_instance *padata_alloc_possible( struct workqueue_struct *wq); extern void padata_free(struct padata_instance *pinst); extern int padata_do_parallel(struct padata_instance *pinst, - struct padata_priv *padata, int cb_cpu); + struct padata_priv *padata, int *cb_cpu); extern void padata_do_serial(struct padata_priv *padata); extern int padata_set_cpumask(struct padata_instance *pinst, int cpumask_type, cpumask_var_t cpumask); diff --git a/kernel/padata.c b/kernel/padata.c index 848e40e3581b..3518c2e60965 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -96,17 +96,19 @@ static void padata_parallel_worker(struct work_struct *parallel_work) * * @pinst: padata instance * @padata: object to be parallelized - * @cb_cpu: cpu the serialization callback function will run on, - * must be in the serial cpumask of padata(i.e. cpumask.cbcpu). + * @cb_cpu: pointer to the CPU that the serialization callback function should + * run on. If it's not in the serial cpumask of @pinst + * (i.e. cpumask.cbcpu), this function selects a fallback CPU and if + * none found, returns -EINVAL. * * The parallelization callback function will run with BHs off. * Note: Every object which is parallelized by padata_do_parallel * must be seen by padata_do_serial. */ int padata_do_parallel(struct padata_instance *pinst, - struct padata_priv *padata, int cb_cpu) + struct padata_priv *padata, int *cb_cpu) { - int target_cpu, err; + int i, cpu, cpu_index, target_cpu, err; struct padata_parallel_queue *queue; struct parallel_data *pd; @@ -118,8 +120,19 @@ int padata_do_parallel(struct padata_instance *pinst, if (!(pinst->flags & PADATA_INIT) || pinst->flags & PADATA_INVALID) goto out; - if (!cpumask_test_cpu(cb_cpu, pd->cpumask.cbcpu)) - goto out; + if (!cpumask_test_cpu(*cb_cpu, pd->cpumask.cbcpu)) { + if (!cpumask_weight(pd->cpumask.cbcpu)) + goto out; + + /* Select an alternate fallback CPU and notify the caller. */ + cpu_index = *cb_cpu % cpumask_weight(pd->cpumask.cbcpu); + + cpu = cpumask_first(pd->cpumask.cbcpu); + for (i = 0; i < cpu_index; i++) + cpu = cpumask_next(cpu, pd->cpumask.cbcpu); + + *cb_cpu = cpu; + } err = -EBUSY; if ((pinst->flags & PADATA_RESET)) @@ -131,7 +144,7 @@ int padata_do_parallel(struct padata_instance *pinst, err = 0; atomic_inc(&pd->refcnt); padata->pd = pd; - padata->cb_cpu = cb_cpu; + padata->cb_cpu = *cb_cpu; target_cpu = padata_cpu_hash(pd); padata->cpu = target_cpu; -- 2.25.1

2 1

[openeuler:OLK-5.10 2579/2579] mm/share_pool.c:4380:12: warning: 'proc_usage_show' defined but not used
by kernel test robot 13 Dec '24

13 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: ff5378fff024fcb2552e6da22811cf933fe4a4c0 commit: f30182b3728f06123932e314f3cb413fbe66d681 [2579/2579] mm: sharepool: use built-in-statistics config: arm64-randconfig-004-20241213 (https://download.01.org/0day-ci/archive/20241213/202412131415.6NF7Ybi7-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241213/202412131415.6NF7Ybi7-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412131415.6NF7Ybi7-lkp@intel.com/ All warnings (new ones prefixed by >>): mm/share_pool.c:832:23: warning: no previous prototype for 'find_spg_node_by_spg' [-Wmissing-prototypes] 832 | struct sp_group_node *find_spg_node_by_spg(struct mm_struct *mm, | ^~~~~~~~~~~~~~~~~~~~ mm/share_pool.c: In function 'mg_sp_group_id_by_pid': mm/share_pool.c:1068:29: warning: ordered comparison of pointer with integer zero [-Wextra] 1068 | if (!spg_ids || num <= 0) | ^~ mm/share_pool.c: In function 'sp_compact_nodes': mm/share_pool.c:2103:9: error: implicit declaration of function 'sysctl_compaction_handler' [-Werror=implicit-function-declaration] 2103 | sysctl_compaction_handler(NULL, 1, NULL, NULL, NULL); | ^~~~~~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c: In function 'sp_hugetlb_entry': mm/share_pool.c:3278:21: error: implicit declaration of function 'huge_ptep_get' [-Werror=implicit-function-declaration] 3278 | pte_t pte = huge_ptep_get(ptep); | ^~~~~~~~~~~~~ mm/share_pool.c:3278:21: error: invalid initializer mm/share_pool.c: In function 'sp_unshare_kva': mm/share_pool.c:3673:14: warning: variable 'is_hugepage' set but not used [-Wunused-but-set-variable] 3673 | bool is_hugepage = true; | ^~~~~~~~~~~ mm/share_pool.c: At top level: mm/share_pool.c:4185:6: warning: no previous prototype for 'spa_overview_show' [-Wmissing-prototypes] 4185 | void spa_overview_show(struct seq_file *seq) | ^~~~~~~~~~~~~~~~~ mm/share_pool.c:4273:6: warning: no previous prototype for 'spg_overview_show' [-Wmissing-prototypes] 4273 | void spg_overview_show(struct seq_file *seq) | ^~~~~~~~~~~~~~~~~ mm/share_pool.c: In function 'sharepool_no_page': mm/share_pool.c:4482:30: error: implicit declaration of function 'huge_pte_none'; did you mean 'huge_pte_lock'? [-Werror=implicit-function-declaration] 4482 | if (!huge_pte_none(huge_ptep_get(ptep))) { | ^~~~~~~~~~~~~ | huge_pte_lock mm/share_pool.c:4495:23: error: implicit declaration of function 'huge_add_to_page_cache'; did you mean 'add_to_page_cache'? [-Werror=implicit-function-declaration] 4495 | err = huge_add_to_page_cache(page, mapping, idx); | ^~~~~~~~~~~~~~~~~~~~~~ | add_to_page_cache mm/share_pool.c:4517:9: error: implicit declaration of function 'set_huge_pte_at'; did you mean 'set_huge_swap_pte_at'? [-Werror=implicit-function-declaration] 4517 | set_huge_pte_at(mm, haddr, ptep, new_pte); | ^~~~~~~~~~~~~~~ | set_huge_swap_pte_at mm/share_pool.c:4519:9: error: implicit declaration of function 'hugetlb_count_add'; did you mean 'hugetlb_count_sub'? [-Werror=implicit-function-declaration] 4519 | hugetlb_count_add(pages_per_huge_page(h), mm); | ^~~~~~~~~~~~~~~~~ | hugetlb_count_sub mm/share_pool.c: At top level: >> mm/share_pool.c:4380:12: warning: 'proc_usage_show' defined but not used [-Wunused-function] 4380 | static int proc_usage_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~~~ >> mm/share_pool.c:4358:12: warning: 'proc_group_usage_show' defined but not used [-Wunused-function] 4358 | static int proc_group_usage_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:4298:12: warning: 'spa_stat_show' defined but not used [-Wunused-function] 4298 | static int spa_stat_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for PGP_KEY_PARSER Depends on [n]: CRYPTO [=y] && ASYMMETRIC_KEY_TYPE [=y] && ASYMMETRIC_PUBLIC_KEY_SUBTYPE [=n] Selected by [y]: - PGP_PRELOAD [=y] && CRYPTO [=y] && ASYMMETRIC_KEY_TYPE [=y] vim +/proc_usage_show +4380 mm/share_pool.c 4357 > 4358 static int proc_group_usage_show(struct seq_file *seq, void *offset) 4359 { 4360 spg_overview_show(seq); 4361 spa_overview_show(seq); 4362 4363 /* print the file header */ 4364 seq_printf(seq, "%-8s %-8s %-9s %-9s %-9s %-10s %-10s %-8s %-7s %-7s %-10s %-4s\n", 4365 "PID", "Group_ID", "SP_ALLOC", "SP_K2U", "SP_RES", "SP_RES_T", 4366 "Non-SP_RES", "VIRT", "RES", "Shm", "Non-SP_Shm", "PROT"); 4367 /* print kthread buff_module_guard_work */ 4368 seq_printf(seq, "%-8s %-8s %-9lld %-9lld\n", 4369 "guard", "-", 4370 byte2kb(atomic64_read(&kthread_stat.alloc_size)), 4371 byte2kb(atomic64_read(&kthread_stat.k2u_size))); 4372 4373 down_read(&sp_group_sem); 4374 idr_for_each(&sp_group_idr, proc_usage_by_group, seq); 4375 up_read(&sp_group_sem); 4376 4377 return 0; 4378 } 4379 > 4380 static int proc_usage_show(struct seq_file *seq, void *offset) 4381 { 4382 struct sp_group_master *master = NULL; 4383 unsigned long anon, file, shmem, total_rss; 4384 long sp_res, sp_res_nsize, non_sp_res, non_sp_shm; 4385 struct sp_proc_stat *proc_stat; 4386 4387 seq_printf(seq, "%-8s %-16s %-9s %-9s %-9s %-10s %-10s %-8s\n", 4388 "PID", "COMM", "SP_ALLOC", "SP_K2U", "SP_RES", "Non-SP_RES", 4389 "Non-SP_Shm", "VIRT"); 4390 4391 mutex_lock(&master_list_lock); 4392 list_for_each_entry(master, &master_list, list_node) { 4393 proc_stat = &master->instat; 4394 get_mm_rss_info(master->mm, &anon, &file, &shmem, &total_rss); 4395 get_process_sp_res(&master->instat, &sp_res, &sp_res_nsize); 4396 get_process_non_sp_res(total_rss, shmem, sp_res_nsize, 4397 &non_sp_res, &non_sp_shm); 4398 seq_printf(seq, "%-8d %-16s %-9ld %-9ld %-9ld %-10ld %-10ld %-8ld\n", 4399 proc_stat->tgid, proc_stat->comm, 4400 get_proc_alloc(proc_stat), 4401 get_proc_k2u(proc_stat), 4402 sp_res, non_sp_res, non_sp_shm, 4403 page2kb(master->mm->total_vm)); 4404 } 4405 mutex_unlock(&master_list_lock); 4406 4407 return 0; 4408 } 4409 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6] kabi reserver space for i2c and sched
by Zicheng Qu 13 Dec '24

13 Dec '24

hulk inclusion category: other bugzilla: https://gitee.com/openeuler/kernel/issues/IBAZ3A -------------------------------- Add two KABI_RESERVE macros for each struct, including i2c_adapter, sched_domain_shared, sched_domain. Signed-off-by: Zicheng Qu <quzicheng(a)huawei.com> --- include/linux/i2c.h | 3 +++ include/linux/sched/topology.h | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 32cf5708d5a5..3fd6932bf8cd 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -746,6 +746,9 @@ struct i2c_adapter { struct irq_domain *host_notify_domain; struct regulator *bus_regulator; + + KABI_RESERVE(1) + KABI_RESERVE(2) }; #define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev) diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 8e4d9bbdaa40..09a2b2625202 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -85,6 +85,8 @@ struct sched_domain_shared { #ifdef CONFIG_SCHED_STEAL struct sparsemask *cfs_overload_cpus; #endif + KABI_RESERVE(1) + KABI_RESERVE(2) }; struct sched_domain { @@ -154,6 +156,9 @@ struct sched_domain { }; struct sched_domain_shared *shared; + KABI_RESERVE(1) + KABI_RESERVE(2) + unsigned int span_weight; /* * Span of all CPUs in this domain. -- 2.34.1

2 1