- Kernel - mailweb.openeuler.org

[openeuler:OLK-6.6 2229/2229] drivers/net/ethernet/huawei/hinic/hinic_hwif.c:581: warning: Function parameter or member 'intr_reg_base' not described in 'hinic_init_hwif'
by kernel test robot 14 May '25

14 May '25

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: a53913bacac4876eee9ce118b3101dff842318ef commit: 9c1c9598010fbb9daa1e2a67d23830092fb6246a [2229/2229] net/hinic: Update Huawei Intelligent Network Card Driver: hinic config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20250514/202505141758.HmJKRSap-lkp@…) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) rustc: rustc 1.71.1 (eb26296b5 2023-08-03) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250514/202505141758.HmJKRSap-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202505141758.HmJKRSap-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c:531:5: warning: no previous prototype for function 'hinic_hiovs_set_cpath_vlan' [-Wmissing-prototypes] 531 | int hinic_hiovs_set_cpath_vlan(void *hwdev, u16 vlan_id, u16 pf_id) | ^ drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c:531:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 531 | int hinic_hiovs_set_cpath_vlan(void *hwdev, u16 vlan_id, u16 pf_id) | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c:557:5: warning: no previous prototype for function 'hinic_hiovs_del_cpath_vlan' [-Wmissing-prototypes] 557 | int hinic_hiovs_del_cpath_vlan(void *hwdev, u16 vlan_id, u16 pf_id) | ^ drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c:557:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 557 | int hinic_hiovs_del_cpath_vlan(void *hwdev, u16 vlan_id, u16 pf_id) | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c:2622:5: warning: no previous prototype for function 'nic_pf_mbox_handler' [-Wmissing-prototypes] 2622 | int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in, | ^ drivers/net/ethernet/huawei/hinic/hinic_nic_cfg.c:2622:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2622 | int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in, | ^ | static 3 warnings generated. -- >> drivers/net/ethernet/huawei/hinic/hinic_nic_io.c:362:6: warning: no previous prototype for function 'hinic_qp_prepare_cmdq_header' [-Wmissing-prototypes] 362 | void hinic_qp_prepare_cmdq_header(struct hinic_qp_ctxt_header *qp_ctxt_hdr, | ^ drivers/net/ethernet/huawei/hinic/hinic_nic_io.c:362:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 362 | void hinic_qp_prepare_cmdq_header(struct hinic_qp_ctxt_header *qp_ctxt_hdr, | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_nic_io.c:381:6: warning: no previous prototype for function 'hinic_sq_prepare_ctxt' [-Wmissing-prototypes] 381 | void hinic_sq_prepare_ctxt(struct hinic_sq *sq, u16 global_qpn, | ^ drivers/net/ethernet/huawei/hinic/hinic_nic_io.c:381:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 381 | void hinic_sq_prepare_ctxt(struct hinic_sq *sq, u16 global_qpn, | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_nic_io.c:443:6: warning: no previous prototype for function 'hinic_rq_prepare_ctxt' [-Wmissing-prototypes] 443 | void hinic_rq_prepare_ctxt(struct hinic_rq *rq, struct hinic_rq_ctxt *rq_ctxt) | ^ drivers/net/ethernet/huawei/hinic/hinic_nic_io.c:443:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 443 | void hinic_rq_prepare_ctxt(struct hinic_rq *rq, struct hinic_rq_ctxt *rq_ctxt) | ^ | static 3 warnings generated. -- >> drivers/net/ethernet/huawei/hinic/hinic_eqs.c:518:5: warning: variable 'lev' set but not used [-Wunused-but-set-variable] 518 | u8 lev; | ^ 1 warning generated. -- >> drivers/net/ethernet/huawei/hinic/hinic_hwif.c:581: warning: Function parameter or member 'intr_reg_base' not described in 'hinic_init_hwif' >> drivers/net/ethernet/huawei/hinic/hinic_hwif.c:581: warning: Function parameter or member 'db_base_phy' not described in 'hinic_init_hwif' >> drivers/net/ethernet/huawei/hinic/hinic_hwif.c:581: warning: Function parameter or member 'db_base' not described in 'hinic_init_hwif' >> drivers/net/ethernet/huawei/hinic/hinic_hwif.c:581: warning: Function parameter or member 'dwqe_mapping' not described in 'hinic_init_hwif' >> drivers/net/ethernet/huawei/hinic/hinic_hwif.c:717: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * get function id from register,used by sriov hot migration process drivers/net/ethernet/huawei/hinic/hinic_hwif.c:802: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * get function id, used by sriov hot migratition process. -- >> drivers/net/ethernet/huawei/hinic/hinic_mbox.c:796:5: warning: no previous prototype for function 'set_vf_mbox_random_id' [-Wmissing-prototypes] 796 | int set_vf_mbox_random_id(struct hinic_hwdev *hwdev, u16 func_id) | ^ drivers/net/ethernet/huawei/hinic/hinic_mbox.c:796:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 796 | int set_vf_mbox_random_id(struct hinic_hwdev *hwdev, u16 func_id) | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_mbox.c:846:6: warning: no previous prototype for function 'check_vf_mbox_random_id' [-Wmissing-prototypes] 846 | bool check_vf_mbox_random_id(struct hinic_mbox_func_to_func *func_to_func, | ^ drivers/net/ethernet/huawei/hinic/hinic_mbox.c:846:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 846 | bool check_vf_mbox_random_id(struct hinic_mbox_func_to_func *func_to_func, | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_mbox.c:1009:6: warning: no previous prototype for function 'dump_mox_reg' [-Wmissing-prototypes] 1009 | void dump_mox_reg(struct hinic_hwdev *hwdev) | ^ drivers/net/ethernet/huawei/hinic/hinic_mbox.c:1009:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1009 | void dump_mox_reg(struct hinic_hwdev *hwdev) | ^ | static 3 warnings generated. -- >> drivers/net/ethernet/huawei/hinic/hinic_eqs.c:321: warning: Function parameter or member 'hwe_cb' not described in 'hinic_aeq_register_hw_cb' >> drivers/net/ethernet/huawei/hinic/hinic_eqs.c:321: warning: Excess function parameter 'hw_cb' description in 'hinic_aeq_register_hw_cb' >> drivers/net/ethernet/huawei/hinic/hinic_eqs.c:369: warning: Function parameter or member 'aeq_swe_cb' not described in 'hinic_aeq_register_swe_cb' >> drivers/net/ethernet/huawei/hinic/hinic_eqs.c:369: warning: expecting prototype for hinic_aeq_register_sw_cb(). Prototype was for hinic_aeq_register_swe_cb() instead >> drivers/net/ethernet/huawei/hinic/hinic_eqs.c:391: warning: expecting prototype for hinic_aeq_unregister_sw_cb(). Prototype was for hinic_aeq_unregister_swe_cb() instead >> drivers/net/ethernet/huawei/hinic/hinic_eqs.c:417: warning: expecting prototype for hinic_ceq_register_sw_cb(). Prototype was for hinic_ceq_register_cb() instead -- >> drivers/net/ethernet/huawei/hinic/hinic_mbox.c:373: warning: expecting prototype for hinic_unregister_ppf_mbox_cb(). Prototype was for hinic_unregister_pf_mbox_cb() instead >> drivers/net/ethernet/huawei/hinic/hinic_mbox.c:411: warning: expecting prototype for hinic_unregister_ppf_mbox_cb(). Prototype was for hinic_unregister_ppf_to_pf_mbox_cb() instead -- >> drivers/net/ethernet/huawei/hinic/hinic_mgmt.c:939: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * api cmd write or read bypass defaut use poll, if want to use aeq interrupt, -- >> drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c:413: warning: expecting prototype for prepare_cell(). Prototype was for wait_for_resp_polling() instead >> drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c:1056: warning: Function parameter or member 'cmd_chain' not described in 'api_cmd_create_chain' >> drivers/net/ethernet/huawei/hinic/hinic_api_cmd.c:1056: warning: Excess function parameter 'chain' description in 'api_cmd_create_chain' -- >> drivers/net/ethernet/huawei/hinic/hinic_cmdq.c:1384:5: warning: no previous prototype for function 'hinic_set_cmdq_ctxts' [-Wmissing-prototypes] 1384 | int hinic_set_cmdq_ctxts(struct hinic_hwdev *hwdev) | ^ drivers/net/ethernet/huawei/hinic/hinic_cmdq.c:1384:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1384 | int hinic_set_cmdq_ctxts(struct hinic_hwdev *hwdev) | ^ | static 1 warning generated. -- >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:1061:5: warning: no previous prototype for function 'hinic_msg_to_mgmt_no_ack' [-Wmissing-prototypes] 1061 | int hinic_msg_to_mgmt_no_ack(void *hwdev, enum hinic_mod_type mod, u8 cmd, | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:1061:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1061 | int hinic_msg_to_mgmt_no_ack(void *hwdev, enum hinic_mod_type mod, u8 cmd, | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:1978:5: warning: no previous prototype for function 'comm_pf_mbox_handler' [-Wmissing-prototypes] 1978 | int comm_pf_mbox_handler(void *handle, u16 vf_id, u8 cmd, void *buf_in, | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:1978:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1978 | int comm_pf_mbox_handler(void *handle, u16 vf_id, u8 cmd, void *buf_in, | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2749:5: warning: no previous prototype for function 'hinic_ppf_ht_gpa_init' [-Wmissing-prototypes] 2749 | int hinic_ppf_ht_gpa_init(struct hinic_hwdev *hwdev) | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2749:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2749 | int hinic_ppf_ht_gpa_init(struct hinic_hwdev *hwdev) | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2795:6: warning: no previous prototype for function 'hinic_ppf_ht_gpa_deinit' [-Wmissing-prototypes] 2795 | void hinic_ppf_ht_gpa_deinit(struct hinic_hwdev *hwdev) | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2795:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2795 | void hinic_ppf_ht_gpa_deinit(struct hinic_hwdev *hwdev) | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2872:5: warning: no previous prototype for function 'mqm_eqm_try_alloc_mem' [-Wmissing-prototypes] 2872 | int mqm_eqm_try_alloc_mem(struct hinic_hwdev *hwdev, u32 page_size, | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2872:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2872 | int mqm_eqm_try_alloc_mem(struct hinic_hwdev *hwdev, u32 page_size, | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2909:5: warning: no previous prototype for function 'mqm_eqm_alloc_page_mem' [-Wmissing-prototypes] 2909 | int mqm_eqm_alloc_page_mem(struct hinic_hwdev *hwdev) | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2909:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2909 | int mqm_eqm_alloc_page_mem(struct hinic_hwdev *hwdev) | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2934:6: warning: no previous prototype for function 'mqm_eqm_free_page_mem' [-Wmissing-prototypes] 2934 | void mqm_eqm_free_page_mem(struct hinic_hwdev *hwdev) | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2934:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2934 | void mqm_eqm_free_page_mem(struct hinic_hwdev *hwdev) | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2950:5: warning: no previous prototype for function 'mqm_eqm_set_cfg_2_hw' [-Wmissing-prototypes] 2950 | int mqm_eqm_set_cfg_2_hw(struct hinic_hwdev *hwdev, u32 valid) | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2950:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2950 | int mqm_eqm_set_cfg_2_hw(struct hinic_hwdev *hwdev, u32 valid) | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2975:5: warning: no previous prototype for function 'mqm_eqm_set_page_2_hw' [-Wmissing-prototypes] 2975 | int mqm_eqm_set_page_2_hw(struct hinic_hwdev *hwdev) | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:2975:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2975 | int mqm_eqm_set_page_2_hw(struct hinic_hwdev *hwdev) | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:3053:5: warning: no previous prototype for function 'mqm_eqm_init' [-Wmissing-prototypes] 3053 | int mqm_eqm_init(struct hinic_hwdev *hwdev) | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:3053:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 3053 | int mqm_eqm_init(struct hinic_hwdev *hwdev) | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:3116:6: warning: no previous prototype for function 'mqm_eqm_deinit' [-Wmissing-prototypes] 3116 | void mqm_eqm_deinit(struct hinic_hwdev *hwdev) | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:3116:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 3116 | void mqm_eqm_deinit(struct hinic_hwdev *hwdev) | ^ | static drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:3719:18: warning: address of array 'chip_node->rt_cmd' will always evaluate to 'true' [-Wpointer-bool-conversion] 3719 | if (!chip_node->rt_cmd) | ~~~~~~~~~~~~^~~~~~ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:3748:18: warning: address of array 'chip_node->rt_cmd' will always evaluate to 'true' [-Wpointer-bool-conversion] 3748 | if (!chip_node->rt_cmd) | ~~~~~~~~~~~~^~~~~~ >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:4581:5: warning: no previous prototype for function '_set_led_status' [-Wmissing-prototypes] 4581 | int _set_led_status(struct hinic_hwdev *hwdev, u8 port, | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:4581:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 4581 | int _set_led_status(struct hinic_hwdev *hwdev, u8 port, | ^ | static >> drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:4667:5: warning: no previous prototype for function 'hinic_get_phy_init_status' [-Wmissing-prototypes] 4667 | int hinic_get_phy_init_status(void *hwdev, | ^ drivers/net/ethernet/huawei/hinic/hinic_hwdev.c:4667:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 4667 | int hinic_get_phy_init_status(void *hwdev, | ^ | static 15 warnings generated. .. vim +581 drivers/net/ethernet/huawei/hinic/hinic_hwif.c 571 572 /** 573 * hinic_init_hwif - initialize the hw interface 574 * @hwdev: the pointer to hw device 575 * @cfg_reg_base: configuration base address 576 * Return: 0 - success, negative - failure 577 */ 578 int hinic_init_hwif(struct hinic_hwdev *hwdev, void *cfg_reg_base, 579 void *intr_reg_base, u64 db_base_phy, 580 void *db_base, void *dwqe_mapping) > 581 { 582 struct hinic_hwif *hwif; 583 int err; 584 585 hwif = kzalloc(sizeof(*hwif), GFP_KERNEL); 586 if (!hwif) 587 return -ENOMEM; 588 589 hwdev->hwif = hwif; 590 hwif->pdev = hwdev->pcidev_hdl; 591 592 hwif->cfg_regs_base = cfg_reg_base; 593 hwif->intr_regs_base = intr_reg_base; 594 595 hwif->db_base_phy = db_base_phy; 596 hwif->db_base = db_base; 597 hwif->dwqe_mapping = dwqe_mapping; 598 599 hwif->db_size = hinic_get_db_size(cfg_reg_base, &hwif->chip_mode); 600 601 sdk_info(hwdev->dev_hdl, "Doorbell size: 0x%x, chip mode: %d\n", 602 hwif->db_size, hwif->chip_mode); 603 604 init_db_area_idx(hwif); 605 606 err = wait_hwif_ready(hwdev); 607 if (err) { 608 sdk_err(hwdev->dev_hdl, "Chip status is not ready\n"); 609 __print_selftest_reg(hwdev); 610 goto hwif_ready_err; 611 } 612 613 get_hwif_attr(hwif); 614 615 err = wait_until_doorbell_and_outbound_enabled(hwif); 616 if (err) { 617 sdk_err(hwdev->dev_hdl, "Hw doorbell/outbound is disabled\n"); 618 goto hwif_ready_err; 619 } 620 621 if (!HINIC_IS_VF(hwdev)) { 622 set_ppf(hwif); 623 624 if (HINIC_IS_PPF(hwdev)) 625 set_mpf(hwif); 626 627 get_mpf(hwif); 628 } 629 630 disable_all_msix(hwdev); 631 /* disable mgmt cpu report any event */ 632 hinic_set_pf_status(hwdev->hwif, HINIC_PF_STATUS_INIT); 633 634 sdk_info(hwdev->dev_hdl, "global_func_idx: %d, func_type: %d, host_id: %d, ppf: %d, mpf: %d\n", 635 hwif->attr.func_global_idx, hwif->attr.func_type, 636 hwif->attr.pci_intf_idx, hwif->attr.ppf_idx, 637 hwif->attr.mpf_idx); 638 639 return 0; 640 641 hwif_ready_err: 642 kfree(hwif); 643 644 return err; 645 } 646 647 /** 648 * hinic_free_hwif - free the hw interface 649 * @hwdev: the pointer to hw device 650 */ 651 void hinic_free_hwif(struct hinic_hwdev *hwdev) 652 { 653 kfree(hwdev->hwif); 654 } 655 656 int hinic_dma_alloc_coherent_align(void *dev_hdl, u64 size, u64 align, 657 unsigned int flag, 658 struct hinic_dma_addr_align *mem_align) 659 { 660 void *vaddr, *align_vaddr; 661 dma_addr_t paddr, align_paddr; 662 u64 real_size = size; 663 664 vaddr = dma_alloc_coherent(dev_hdl, real_size, &paddr, flag); 665 if (!vaddr) 666 return -ENOMEM; 667 668 align_paddr = ALIGN(paddr, align); 669 /* align */ 670 if (align_paddr == paddr) { 671 align_vaddr = vaddr; 672 goto out; 673 } 674 675 dma_free_coherent(dev_hdl, real_size, vaddr, paddr); 676 677 /* realloc memory for align */ 678 real_size = size + align; 679 vaddr = dma_alloc_coherent(dev_hdl, real_size, &paddr, flag); 680 if (!vaddr) 681 return -ENOMEM; 682 683 align_paddr = ALIGN(paddr, align); 684 align_vaddr = (void *)((u64)vaddr + (align_paddr - paddr)); 685 686 out: 687 mem_align->real_size = (u32)real_size; 688 mem_align->ori_vaddr = vaddr; 689 mem_align->ori_paddr = paddr; 690 mem_align->align_vaddr = align_vaddr; 691 mem_align->align_paddr = align_paddr; 692 693 return 0; 694 } 695 696 void hinic_dma_free_coherent_align(void *dev_hdl, 697 struct hinic_dma_addr_align *mem_align) 698 { 699 dma_free_coherent(dev_hdl, mem_align->real_size, 700 mem_align->ori_vaddr, mem_align->ori_paddr); 701 } 702 703 u16 hinic_global_func_id(void *hwdev) 704 { 705 struct hinic_hwif *hwif; 706 707 if (!hwdev) 708 return 0; 709 710 hwif = ((struct hinic_hwdev *)hwdev)->hwif; 711 712 return hwif->attr.func_global_idx; 713 } 714 EXPORT_SYMBOL(hinic_global_func_id); 715 716 /** > 717 * get function id from register,used by sriov hot migration process 718 * @hwdev: the pointer to hw device 719 */ 720 u16 hinic_global_func_id_hw(void *hwdev) 721 { 722 u32 addr, attr0; 723 struct hinic_hwdev *dev; 724 725 dev = (struct hinic_hwdev *)hwdev; 726 addr = HINIC_CSR_FUNC_ATTR0_ADDR; 727 attr0 = hinic_hwif_read_reg(dev->hwif, addr); 728 729 return HINIC_AF0_GET(attr0, FUNC_GLOBAL_IDX); 730 } 731 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 0/5] CVE-2024-58098
by Pu Lehui 14 May '25

14 May '25

Eduard Zingerman (4): bpf: add find_containing_subprog() utility function bpf: refactor bpf_helper_changes_pkt_data to use helper number bpf: track changes_pkt_data property for global functions selftests/bpf: test for changing packet data from global functions Pu Lehui (1): bpf: Fix kabi breakage in struct bpf_subprog_info include/linux/bpf_verifier.h | 1 + include/linux/filter.h | 2 +- kernel/bpf/core.c | 2 +- kernel/bpf/verifier.c | 62 ++++++++++++++++-- net/core/filter.c | 63 +++++++++---------- .../selftests/bpf/progs/verifier_sock.c | 28 +++++++++ 6 files changed, 115 insertions(+), 43 deletions(-) -- 2.34.1

2 6

[PATCH openEuler-1.0-LTS] scsi: core: Clear driver private data when retrying request
by Zheng Qixing 14 May '25

14 May '25

From: Ye Bin <yebin10(a)huawei.com> mainline inclusion from mainline-v6.14-rc5 commit dce5c4afd035e8090a26e5d776b1682c0e649683 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/IBPBUA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… ---------------------- After commit 1bad6c4a57ef ("scsi: zero per-cmd private driver data for each MQ I/O"), the xen-scsifront/virtio_scsi/snic drivers all removed code that explicitly zeroed driver-private command data. In combination with commit 464a00c9e0ad ("scsi: core: Kill DRIVER_SENSE"), after virtio_scsi performs a capacity expansion, the first request will return a unit attention to indicate that the capacity has changed. And then the original command is retried. As driver-private command data was not cleared, the request would return UA again and eventually time out and fail. Zero driver-private command data when a request is retried. Fixes: f7de50da1479 ("scsi: xen-scsifront: Remove code that zeroes driver-private command data") Fixes: c2bb87318baa ("scsi: virtio_scsi: Remove code that zeroes driver-private command data") Fixes: c3006a926468 ("scsi: snic: Remove code that zeroes driver-private command data") Signed-off-by: Ye Bin <yebin10(a)huawei.com> Reviewed-by: Bart Van Assche <bvanassche(a)acm.org> Link: https://lore.kernel.org/r/20250217021628.2929248-1-yebin@huaweicloud.com Signed-off-by: Martin K. Petersen <martin.petersen(a)oracle.com> Conflicts: drivers/scsi/scsi_lib.c [Due to not merging commit 65ca846a5314 ("scsi: core: Introduce {init,exit}_cmd_priv()").] Signed-off-by: Zheng Qixing <zhengqixing(a)huawei.com> --- drivers/scsi/scsi_lib.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 15fd51cc3364..e08a944de8e0 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1370,7 +1370,7 @@ void scsi_init_command(struct scsi_device *dev, struct scsi_cmnd *cmd) retries = cmd->retries; /* zero out the cmd, except for the embedded scsi_request */ memset((char *)cmd + sizeof(cmd->req), 0, - sizeof(*cmd) - sizeof(cmd->req) + dev->host->hostt->cmd_size); + sizeof(*cmd) - sizeof(cmd->req)); cmd->device = dev; cmd->sense_buffer = buf; @@ -2196,6 +2196,9 @@ static blk_status_t scsi_queue_rq(struct blk_mq_hw_ctx *hctx, if (!scsi_host_queue_ready(q, shost, sdev)) goto out_dec_target_busy; + if (shost->hostt->cmd_size) + memset(cmd + 1, 0, shost->hostt->cmd_size); + if (!(req->rq_flags & RQF_DONTPREP)) { ret = prep_to_mq(scsi_mq_prep_fn(req)); if (ret != BLK_STS_OK) -- 2.39.2

2 1

[openeuler:OLK-6.6 2228/2228] include/linux/psp-hygon.h:219:5: warning: no previous prototype for 'psp_register_cmd_notifier'
by kernel test robot 14 May '25

14 May '25

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: a8743142c88fdbade6ffcd3cf426037633e9e1fc commit: 518c81d56c055affc71650b1ad1ba7f86e5ee867 [2228/2228] arch/x86/kvm: Support tkm virtualization config: x86_64-buildonly-randconfig-002-20250514 (https://download.01.org/0day-ci/archive/20250514/202505141619.2NcI2pvO-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250514/202505141619.2NcI2pvO-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202505141619.2NcI2pvO-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from arch/x86/kvm/psp.c:15: >> include/linux/psp-hygon.h:219:5: warning: no previous prototype for 'psp_register_cmd_notifier' [-Wmissing-prototypes] 219 | int psp_register_cmd_notifier(uint32_t cmd_id, p2c_notifier_t notifier) { return -ENODEV; } | ^~~~~~~~~~~~~~~~~~~~~~~~~ >> include/linux/psp-hygon.h:220:5: warning: no previous prototype for 'psp_unregister_cmd_notifier' [-Wmissing-prototypes] 220 | int psp_unregister_cmd_notifier(uint32_t cmd_id, p2c_notifier_t notifier) { return -ENODEV; } | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/x86/kvm/psp.c:105:21: warning: no previous prototype for 'map_tbl_dump' [-Wmissing-prototypes] 105 | void __maybe_unused map_tbl_dump(const char *title, struct addr_map_tbls *tbls) | ^~~~~~~~~~~~ arch/x86/kvm/psp.c:118:21: warning: no previous prototype for 'g2h_tbl_dump' [-Wmissing-prototypes] 118 | void __maybe_unused g2h_tbl_dump(const char *title, struct gpa2hva_tbls *tbls) | ^~~~~~~~~~~~ vim +/psp_register_cmd_notifier +219 include/linux/psp-hygon.h d0b3a770d8e20d chench00 2024-08-01 218 d0b3a770d8e20d chench00 2024-08-01 @219 int psp_register_cmd_notifier(uint32_t cmd_id, p2c_notifier_t notifier) { return -ENODEV; } d0b3a770d8e20d chench00 2024-08-01 @220 int psp_unregister_cmd_notifier(uint32_t cmd_id, p2c_notifier_t notifier) { return -ENODEV; } d0b3a770d8e20d chench00 2024-08-01 221 :::::: The code at line 219 was first introduced by commit :::::: d0b3a770d8e20d953fe2a74ea8c4b5f4767c4add crypto: command co-processor: Add another mailbox interrupt support for PSP sending command to X86 :::::: TO: chench00 <chench(a)hygon.cn> :::::: CC: chench00 <chench(a)hygon.cn> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH openEuler-1.0-LTS] udf: Fix a slab-out-of-bounds write bug in udf_find_entry()
by Zeng Heng 14 May '25

14 May '25

From: ZhangPeng <zhangpeng362(a)huawei.com> stable inclusion from stable-v4.19.267 commit 7a6051d734f1ed0031e2216f9a538621235c11a4 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IC5BQP CVE: CVE-2022-49846 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------------------------------- commit c8af247de385ce49afabc3bf1cf4fd455c94bfe8 upstream. Syzbot reported a slab-out-of-bounds Write bug: loop0: detected capacity change from 0 to 2048 ================================================================== BUG: KASAN: slab-out-of-bounds in udf_find_entry+0x8a5/0x14f0 fs/udf/namei.c:253 Write of size 105 at addr ffff8880123ff896 by task syz-executor323/3610 CPU: 0 PID: 3610 Comm: syz-executor323 Not tainted 6.1.0-rc2-syzkaller-00105-gb229b6ca5abb #0 Hardware name: Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106 print_address_description+0x74/0x340 mm/kasan/report.c:284 print_report+0x107/0x1f0 mm/kasan/report.c:395 kasan_report+0xcd/0x100 mm/kasan/report.c:495 kasan_check_range+0x2a7/0x2e0 mm/kasan/generic.c:189 memcpy+0x3c/0x60 mm/kasan/shadow.c:66 udf_find_entry+0x8a5/0x14f0 fs/udf/namei.c:253 udf_lookup+0xef/0x340 fs/udf/namei.c:309 lookup_open fs/namei.c:3391 [inline] open_last_lookups fs/namei.c:3481 [inline] path_openat+0x10e6/0x2df0 fs/namei.c:3710 do_filp_open+0x264/0x4f0 fs/namei.c:3740 do_sys_openat2+0x124/0x4e0 fs/open.c:1310 do_sys_open fs/open.c:1326 [inline] __do_sys_creat fs/open.c:1402 [inline] __se_sys_creat fs/open.c:1396 [inline] __x64_sys_creat+0x11f/0x160 fs/open.c:1396 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7ffab0d164d9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffe1a7e6bb8 EFLAGS: 00000246 ORIG_RAX: 0000000000000055 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007ffab0d164d9 RDX: 00007ffab0d164d9 RSI: 0000000000000000 RDI: 0000000020000180 RBP: 00007ffab0cd5a10 R08: 0000000000000000 R09: 0000000000000000 R10: 00005555573552c0 R11: 0000000000000246 R12: 00007ffab0cd5aa0 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 </TASK> Allocated by task 3610: kasan_save_stack mm/kasan/common.c:45 [inline] kasan_set_track+0x3d/0x60 mm/kasan/common.c:52 ____kasan_kmalloc mm/kasan/common.c:371 [inline] __kasan_kmalloc+0x97/0xb0 mm/kasan/common.c:380 kmalloc include/linux/slab.h:576 [inline] udf_find_entry+0x7b6/0x14f0 fs/udf/namei.c:243 udf_lookup+0xef/0x340 fs/udf/namei.c:309 lookup_open fs/namei.c:3391 [inline] open_last_lookups fs/namei.c:3481 [inline] path_openat+0x10e6/0x2df0 fs/namei.c:3710 do_filp_open+0x264/0x4f0 fs/namei.c:3740 do_sys_openat2+0x124/0x4e0 fs/open.c:1310 do_sys_open fs/open.c:1326 [inline] __do_sys_creat fs/open.c:1402 [inline] __se_sys_creat fs/open.c:1396 [inline] __x64_sys_creat+0x11f/0x160 fs/open.c:1396 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd The buggy address belongs to the object at ffff8880123ff800 which belongs to the cache kmalloc-256 of size 256 The buggy address is located 150 bytes inside of 256-byte region [ffff8880123ff800, ffff8880123ff900) The buggy address belongs to the physical page: page:ffffea000048ff80 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x123fe head:ffffea000048ff80 order:1 compound_mapcount:0 compound_pincount:0 flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff) raw: 00fff00000010200 ffffea00004b8500 dead000000000003 ffff888012041b40 raw: 0000000000000000 0000000080100010 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected page_owner tracks the page as allocated page last allocated via order 0, migratetype Unmovable, gfp_mask 0x0(), pid 1, tgid 1 (swapper/0), ts 1841222404, free_ts 0 create_dummy_stack mm/page_owner.c:67 [inline] register_early_stack+0x77/0xd0 mm/page_owner.c:83 init_page_owner+0x3a/0x731 mm/page_owner.c:93 kernel_init_freeable+0x41c/0x5d5 init/main.c:1629 kernel_init+0x19/0x2b0 init/main.c:1519 page_owner free stack trace missing Memory state around the buggy address: ffff8880123ff780: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff8880123ff800: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >ffff8880123ff880: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 06 ^ ffff8880123ff900: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff8880123ff980: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ================================================================== Fix this by changing the memory size allocated for copy_name from UDF_NAME_LEN(254) to UDF_NAME_LEN_CS0(255), because the total length (lfi) of subsequent memcpy can be up to 255. CC: stable(a)vger.kernel.org Reported-by: syzbot+69c9fdccc6dd08961d34(a)syzkaller.appspotmail.com Fixes: 066b9cded00b ("udf: Use separate buffer for copying split names") Signed-off-by: ZhangPeng <zhangpeng362(a)huawei.com> Signed-off-by: Jan Kara <jack(a)suse.cz> Link: https://lore.kernel.org/r/20221109013542.442790-1-zhangpeng362@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- fs/udf/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/udf/namei.c b/fs/udf/namei.c index 9cfb555db1ad..0867322512cb 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c @@ -238,7 +238,7 @@ static struct fileIdentDesc *udf_find_entry(struct inode *dir, poffset - lfi); else { if (!copy_name) { - copy_name = kmalloc(UDF_NAME_LEN, + copy_name = kmalloc(UDF_NAME_LEN_CS0, GFP_NOFS); if (!copy_name) { fi = ERR_PTR(-ENOMEM); -- 2.25.1

2 1

[PATCH OLK-6.6 0/4] Sync from 6.6 for the sam kabi
by Liu Chuang 14 May '25

14 May '25

Liu Chuang (1): trace: Fix kabi breakage in struct trace_iterator Steven Rostedt (1): tracing: Return from tracing_buffers_read() if the file has been closed Steven Rostedt (Google) (2): tracing/ring-buffer: Fix wait_on_pipe() race ring-buffer: Make wake once of ring_buffer_wait() more robust include/linux/ring_buffer.h | 3 ++- include/linux/trace_events.h | 6 ++++- kernel/trace/ring_buffer.c | 39 ++++++++++++++++++++----------- kernel/trace/trace.c | 45 +++++++++++++++++++++++++----------- 4 files changed, 64 insertions(+), 29 deletions(-) -- 2.34.1

2 5

[openeuler:OLK-5.10 2894/2894] drivers/ub/urma/ubcore/ubcore_main.c:257:36: sparse: sparse: incorrect type in assignment (different base types)
by kernel test robot 14 May '25

14 May '25

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 731227d05f54b13300b28332fabd3f3aaf0950eb commit: 95c713224477ac3433652331dd715e9bbcbc793a [2894/2894] ub: init ubcore module config: x86_64-randconfig-r121-20250514 compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202505141607.i1GpuEfA-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) drivers/ub/urma/ubcore/ubcore_main.c:118:44: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const *args_addr @@ got void [noderef] __user * @@ drivers/ub/urma/ubcore/ubcore_main.c:118:44: sparse: expected void const *args_addr drivers/ub/urma/ubcore/ubcore_main.c:118:44: sparse: got void [noderef] __user * drivers/ub/urma/ubcore/ubcore_main.c:130:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *args_addr @@ got void [noderef] __user * @@ drivers/ub/urma/ubcore/ubcore_main.c:130:36: sparse: expected void *args_addr drivers/ub/urma/ubcore/ubcore_main.c:130:36: sparse: got void [noderef] __user * drivers/ub/urma/ubcore/ubcore_main.c:143:44: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const *args_addr @@ got void [noderef] __user * @@ drivers/ub/urma/ubcore/ubcore_main.c:143:44: sparse: expected void const *args_addr drivers/ub/urma/ubcore/ubcore_main.c:143:44: sparse: got void [noderef] __user * drivers/ub/urma/ubcore/ubcore_main.c:256:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] resv2 @@ got restricted __be32 [usertype] @@ drivers/ub/urma/ubcore/ubcore_main.c:256:37: sparse: expected unsigned int [usertype] resv2 drivers/ub/urma/ubcore/ubcore_main.c:256:37: sparse: got restricted __be32 [usertype] >> drivers/ub/urma/ubcore/ubcore_main.c:257:36: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] addr @@ got restricted __be32 [usertype] ipv4 @@ drivers/ub/urma/ubcore/ubcore_main.c:257:36: sparse: expected unsigned int [usertype] addr drivers/ub/urma/ubcore/ubcore_main.c:257:36: sparse: got restricted __be32 [usertype] ipv4 drivers/ub/urma/ubcore/ubcore_main.c:86:17: sparse: sparse: context imbalance in 'ubcore_uasid_alloc' - unexpected unlock drivers/ub/urma/ubcore/ubcore_main.c: note: in included file: >> drivers/ub/urma/ubcore/ubcore_cmd.h:65:45: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] __user *from @@ got void const *args_addr @@ drivers/ub/urma/ubcore/ubcore_cmd.h:65:45: sparse: expected void const [noderef] __user *from drivers/ub/urma/ubcore/ubcore_cmd.h:65:45: sparse: got void const *args_addr >> drivers/ub/urma/ubcore/ubcore_cmd.h:75:37: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *to @@ got void *args_addr @@ drivers/ub/urma/ubcore/ubcore_cmd.h:75:37: sparse: expected void [noderef] __user *to drivers/ub/urma/ubcore/ubcore_cmd.h:75:37: sparse: got void *args_addr >> drivers/ub/urma/ubcore/ubcore_cmd.h:65:45: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] __user *from @@ got void const *args_addr @@ drivers/ub/urma/ubcore/ubcore_cmd.h:65:45: sparse: expected void const [noderef] __user *from drivers/ub/urma/ubcore/ubcore_cmd.h:65:45: sparse: got void const *args_addr >> drivers/ub/urma/ubcore/ubcore_cmd.h:65:45: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] __user *from @@ got void const *args_addr @@ drivers/ub/urma/ubcore/ubcore_cmd.h:65:45: sparse: expected void const [noderef] __user *from drivers/ub/urma/ubcore/ubcore_cmd.h:65:45: sparse: got void const *args_addr vim +257 drivers/ub/urma/ubcore/ubcore_main.c 112 113 static int ubcore_cmd_set_uasid(struct ubcore_cmd_hdr *hdr) 114 { 115 struct ubcore_cmd_set_uasid arg; 116 int ret; 117 118 ret = ubcore_copy_from_user(&arg, (void __user *)(uintptr_t)hdr->args_addr, 119 sizeof(struct ubcore_cmd_set_uasid)); 120 if (ret != 0) 121 return -EPERM; 122 123 arg.out.uasid = ubcore_uasid_alloc(arg.in.uasid); 124 if (arg.out.uasid == 0) { 125 ubcore_log_err("set uasid allocation failed, in_uasid: %u.\n", arg.in.uasid); 126 return -ENOMEM; 127 } 128 ubcore_log_info("set uasid allocation success, uasid: %u.\n", arg.out.uasid); 129 > 130 ret = ubcore_copy_to_user((void __user *)(uintptr_t)hdr->args_addr, &arg, 131 sizeof(struct ubcore_cmd_set_uasid)); 132 if (ret != 0) 133 return -EPERM; 134 135 return 0; 136 } 137 138 static int ubcore_cmd_put_uasid(struct ubcore_cmd_hdr *hdr) 139 { 140 struct ubcore_cmd_put_uasid arg; 141 int ret; 142 143 ret = ubcore_copy_from_user(&arg, (void __user *)(uintptr_t)hdr->args_addr, 144 sizeof(struct ubcore_cmd_put_uasid)); 145 if (ret != 0) 146 return -EPERM; 147 148 if (ubcore_uasid_free(arg.in.uasid) != 0) 149 return -EINVAL; 150 151 ubcore_log_info("put uasid free success, uasid: %u.\n", arg.in.uasid); 152 return 0; 153 } 154 static int ubcore_cmd_parse(struct ubcore_cmd_hdr *hdr) 155 { 156 switch (hdr->command) { 157 case UBCORE_CMD_SET_UASID: 158 return ubcore_cmd_set_uasid(hdr); 159 case UBCORE_CMD_PUT_UASID: 160 return ubcore_cmd_put_uasid(hdr); 161 default: 162 ubcore_log_err("bad ubcore command: %d.\n", (int)hdr->command); 163 return -EINVAL; 164 } 165 } 166 167 static long ubcore_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 168 { 169 struct ubcore_cmd_hdr hdr; 170 int ret; 171 172 if (cmd == UBCORE_CMD) { 173 ret = ubcore_copy_from_user(&hdr, (void *)arg, sizeof(struct ubcore_cmd_hdr)); 174 if ((ret != 0) || (hdr.args_len > UBCORE_MAX_CMD_SIZE)) { 175 ubcore_log_err("length of ioctl input parameter is out of range.\n"); 176 return -EINVAL; 177 } 178 } else { 179 ubcore_log_err("bad ioctl command.\n"); 180 return -ENOIOCTLCMD; 181 } 182 return ubcore_cmd_parse(&hdr); 183 } 184 185 static int ubcore_close(struct inode *i_node, struct file *filp) 186 { 187 return 0; 188 } 189 190 static const struct file_operations g_ubcore_ops = { 191 .owner = THIS_MODULE, 192 .open = ubcore_open, 193 .release = ubcore_close, 194 .unlocked_ioctl = ubcore_ioctl, 195 .compat_ioctl = ubcore_ioctl, 196 }; 197 198 static int ubcore_register_sysfs(void) 199 { 200 int ret; 201 202 ret = alloc_chrdev_region(&g_ubcore_ctx.ubcore_devno, 0, 1, UBCORE_DEVICE_NAME); 203 if (ret != 0) { 204 ubcore_log_err("alloc chrdev region failed, ret:%d.\n", ret); 205 return ret; 206 } 207 208 cdev_init(&g_ubcore_ctx.ubcore_cdev, &g_ubcore_ops); 209 ret = cdev_add(&g_ubcore_ctx.ubcore_cdev, g_ubcore_ctx.ubcore_devno, 1); 210 if (ret != 0) { 211 ubcore_log_err("chrdev add failed, ret:%d.\n", ret); 212 goto unreg_cdev_region; 213 } 214 215 /* /sys/class/ubus/ubcore */ 216 g_ubcore_ctx.ubcore_class = class_create(THIS_MODULE, UBCORE_CLASS_NAME); 217 if (IS_ERR(g_ubcore_ctx.ubcore_class)) { 218 ret = (int)PTR_ERR(g_ubcore_ctx.ubcore_class); 219 ubcore_log_err("couldn't create class %s, ret:%d.\n", UBCORE_CLASS_NAME, ret); 220 goto del_cdev; 221 } 222 223 /* /dev/ubcore */ 224 g_ubcore_ctx.ubcore_dev = 225 device_create(g_ubcore_ctx.ubcore_class, NULL, g_ubcore_ctx.ubcore_devno, NULL, 226 UBCORE_DEVICE_NAME); 227 if (IS_ERR(g_ubcore_ctx.ubcore_dev)) { 228 ret = (int)PTR_ERR(g_ubcore_ctx.ubcore_dev); 229 ubcore_log_err("couldn't create device %s, ret:%d.\n", UBCORE_DEVICE_NAME, ret); 230 goto destroy_class; 231 } 232 ubcore_log_info("ubcore device created success.\n"); 233 return 0; 234 235 destroy_class: 236 class_destroy(g_ubcore_ctx.ubcore_class); 237 del_cdev: 238 cdev_del(&g_ubcore_ctx.ubcore_cdev); 239 unreg_cdev_region: 240 unregister_chrdev_region(g_ubcore_ctx.ubcore_devno, 1); 241 return ret; 242 } 243 244 static void ubcore_unregister_sysfs(void) 245 { 246 device_destroy(g_ubcore_ctx.ubcore_class, g_ubcore_ctx.ubcore_cdev.dev); 247 class_destroy(g_ubcore_ctx.ubcore_class); 248 cdev_del(&g_ubcore_ctx.ubcore_cdev); 249 unregister_chrdev_region(g_ubcore_ctx.ubcore_devno, 1); 250 ubcore_log_info("ubcore device destroyed success.\n"); 251 } 252 253 static void ubcore_ipv4_to_netaddr(struct ubcore_net_addr *netaddr, __be32 ipv4) 254 { 255 netaddr->net_addr.in4.resv1 = 0; 256 netaddr->net_addr.in4.resv2 = htonl(UBCORE_IPV4_MAP_IPV6_PREFIX); > 257 netaddr->net_addr.in4.addr = ipv4; 258 } 259 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 2229/2229] kernel/livepatch/core.c:2046: warning: bad line:
by kernel test robot 14 May '25

14 May '25

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: a8743142c88fdbade6ffcd3cf426037633e9e1fc commit: 29f85d3cff2dfa35ace94d3e4036d5ea456eb859 [2229/2229] livepatch: Add klp_module_delete_safety_check config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20250514/202505141516.wTret3B2-lkp@…) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) rustc: rustc 1.71.1 (eb26296b5 2023-08-03) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250514/202505141516.wTret3B2-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202505141516.wTret3B2-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/livepatch/core.c:2046: warning: bad line: vim +2046 kernel/livepatch/core.c 2033 2034 /** 2035 * klp_module_delete_safety_check() - safety check in livepatch scenario when delete a module 2036 * @mod: Module to be deleted 2037 * 2038 * Module refcnt ensures that there is no rare case between enable_patch and delete_module: 2039 * 1. safety_check -> try_enable_patch -> try_release_module_ref: 2040 * try_enable_patch would increase module refcnt, which cause try_release_module_ref fails. 2041 * 2. safety_check -> try_release_module_ref -> try_enable_patch: 2042 * after release module ref, try_enable_patch would fail because try_module_get fails. 2043 * So the problem that release resources unsafely when enable livepatch after safety_check is 2044 * passed during module deletion does not exist, complex synchronization protection is not 2045 * required. > 2046 2047 * Return: 0 on success, otherwise error 2048 */ 2049 int klp_module_delete_safety_check(struct module *mod) 2050 { 2051 int ret; 2052 2053 if (!mod || !is_livepatch_module(mod)) 2054 return 0; 2055 2056 ret = stop_machine(arch_klp_module_check_calltrace, (void *)mod, NULL); 2057 if (ret) { 2058 pr_debug("failed to check klp module calltrace: %d\n", ret); 2059 return ret; 2060 } 2061 2062 return 0; 2063 } 2064 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 0/4] Sync from 6.6 for the same kabi
by Liu Chuang 14 May '25

14 May '25

Liu Chuang (1): trace: Fix kabi breakage in struct trace_iterator Steven Rostedt (1): tracing: Return from tracing_buffers_read() if the file has been closed Steven Rostedt (Google) (2): tracing/ring-buffer: Fix wait_on_pipe() race ring-buffer: Make wake once of ring_buffer_wait() more robust include/linux/ring_buffer.h | 3 ++- include/linux/trace_events.h | 6 ++++- kernel/trace/ring_buffer.c | 39 ++++++++++++++++++++----------- kernel/trace/trace.c | 45 +++++++++++++++++++++++++----------- 4 files changed, 64 insertions(+), 29 deletions(-) -- 2.34.1

2 5

[PATCH 0/4] Sync from 6.6 for the same kabi
by Liu Chuang 14 May '25

14 May '25

Liu Chuang (1): trace: Fix kabi breakage in struct trace_iterator Steven Rostedt (1): tracing: Return from tracing_buffers_read() if the file has been closed Steven Rostedt (Google) (2): tracing/ring-buffer: Fix wait_on_pipe() race ring-buffer: Make wake once of ring_buffer_wait() more robust include/linux/ring_buffer.h | 3 ++- include/linux/trace_events.h | 6 ++++- kernel/trace/ring_buffer.c | 39 ++++++++++++++++++++----------- kernel/trace/trace.c | 45 +++++++++++++++++++++++++----------- 4 files changed, 64 insertions(+), 29 deletions(-) -- 2.34.1

1 0