- Kernel - mailweb.openeuler.org

[openeuler:OLK-6.6 6862/7265] drivers/net/ethernet/mucse/rnpvf/vf.c:486:5: warning: no previous prototype for 'rnpvf_addr_list_itr'
by kernel test robot 03 Apr '24

03 Apr '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 448a7c1b3e0654d6b6801c216e7c265445a83a2f commit: 6adab536d69347a10c2366aaf6b86de963d5994b [6862/7265] drivers: initial support for rnpvf drivers from Mucse Technology config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240403/202404030557.mZnvUtOv-lkp@…) compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240403/202404030557.mZnvUtOv-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202404030557.mZnvUtOv-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/net/ethernet/mucse/rnpvf/vf.c: In function 'rnpvf_stop_hw_vf': drivers/net/ethernet/mucse/rnpvf/vf.c:256:13: warning: variable 'number_of_queues' set but not used [-Wunused-but-set-variable] 256 | u32 number_of_queues; | ^~~~~~~~~~~~~~~~ drivers/net/ethernet/mucse/rnpvf/vf.c: At top level: >> drivers/net/ethernet/mucse/rnpvf/vf.c:486:5: warning: no previous prototype for 'rnpvf_addr_list_itr' [-Wmissing-prototypes] 486 | u8 *rnpvf_addr_list_itr(struct rnpvf_hw __maybe_unused *hw, | ^~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/vf.c:685:5: warning: no previous prototype for 'rnpvf_negotiate_api_version' [-Wmissing-prototypes] 685 | int rnpvf_negotiate_api_version(struct rnpvf_hw *hw, int api) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/vf.c:690:5: warning: no previous prototype for 'rnpvf_get_queues' [-Wmissing-prototypes] 690 | int rnpvf_get_queues(struct rnpvf_hw *hw, unsigned int *num_tcs, | ^~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/vf.c:696:6: warning: no previous prototype for 'rnpvf_set_veb_mac_n10' [-Wmissing-prototypes] 696 | void rnpvf_set_veb_mac_n10(struct rnpvf_hw *hw, u8 *mac, u32 vfnum, | ^~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/vf.c:718:6: warning: no previous prototype for 'rnpvf_set_vlan_n10' [-Wmissing-prototypes] 718 | void rnpvf_set_vlan_n10(struct rnpvf_hw *hw, u16 vid, u32 vf_num) | ^~~~~~~~~~~~~~~~~~ -- >> drivers/net/ethernet/mucse/rnpvf/ethtool.c:249:6: warning: no previous prototype for 'rnpvf_get_ringparam' [-Wmissing-prototypes] 249 | void rnpvf_get_ringparam(struct net_device *netdev, | ^~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mucse/rnpvf/ethtool.c: In function 'rnpvf_get_strings': drivers/net/ethernet/mucse/rnpvf/ethtool.c:269:13: warning: variable 'queue_idx' set but not used [-Wunused-but-set-variable] 269 | u16 queue_idx; | ^~~~~~~~~ drivers/net/ethernet/mucse/rnpvf/ethtool.c: At top level: >> drivers/net/ethernet/mucse/rnpvf/ethtool.c:103:19: warning: 'rnp_gstrings_test' defined but not used [-Wunused-const-variable=] 103 | static const char rnp_gstrings_test[][ETH_GSTRING_LEN] = { | ^~~~~~~~~~~~~~~~~ -- >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:127:6: warning: no previous prototype for 'rnpvf_unmap_and_free_tx_resource' [-Wmissing-prototypes] 127 | void rnpvf_unmap_and_free_tx_resource(struct rnpvf_ring *ring, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:919:6: warning: no previous prototype for 'rnpvf_alloc_rx_buffers' [-Wmissing-prototypes] 919 | void rnpvf_alloc_rx_buffers(struct rnpvf_ring *rx_ring, u16 cleaned_count) | ^~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:1945:6: warning: no previous prototype for 'update_rx_count' [-Wmissing-prototypes] 1945 | void update_rx_count(int cleaned, struct rnpvf_q_vector *q_vector) | ^~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2420:6: warning: no previous prototype for 'rnpvf_write_eitr_rx' [-Wmissing-prototypes] 2420 | void rnpvf_write_eitr_rx(struct rnpvf_q_vector *q_vector) | ^~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2523:6: warning: no previous prototype for 'rnpvf_configure_tx_ring' [-Wmissing-prototypes] 2523 | void rnpvf_configure_tx_ring(struct rnpvf_adapter *adapter, | ^~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2589:6: warning: no previous prototype for 'rnpvf_disable_rx_queue' [-Wmissing-prototypes] 2589 | void rnpvf_disable_rx_queue(struct rnpvf_adapter *adapter, | ^~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2595:6: warning: no previous prototype for 'rnpvf_enable_rx_queue' [-Wmissing-prototypes] 2595 | void rnpvf_enable_rx_queue(struct rnpvf_adapter *adapter, | ^~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2601:6: warning: no previous prototype for 'rnpvf_configure_rx_ring' [-Wmissing-prototypes] 2601 | void rnpvf_configure_rx_ring(struct rnpvf_adapter *adapter, | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c: In function 'rnpvf_vlan_rx_kill_vid': drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2736:13: warning: variable 'err' set but not used [-Wunused-but-set-variable] 2736 | int err = -EOPNOTSUPP; | ^~~ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c: In function 'rnpvf_acquire_msix_vectors': drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:3307:13: warning: variable 'vector_threshold' set but not used [-Wunused-but-set-variable] 3307 | int vector_threshold; | ^~~~~~~~~~~~~~~~ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c: In function 'irq_miss_check': drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:3456:26: warning: variable 'hw' set but not used [-Wunused-but-set-variable] 3456 | struct rnpvf_hw *hw; | ^~ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c: At top level: >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:4590:6: warning: no previous prototype for 'rnpvf_tx_ctxtdesc' [-Wmissing-prototypes] 4590 | void rnpvf_tx_ctxtdesc(struct rnpvf_ring *tx_ring, u16 mss_seg_len, | ^~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5039:6: warning: no previous prototype for 'rnpvf_maybe_tx_ctxtdesc' [-Wmissing-prototypes] 5039 | void rnpvf_maybe_tx_ctxtdesc(struct rnpvf_ring *tx_ring, | ^~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5089:13: warning: no previous prototype for 'rnpvf_xmit_frame_ring' [-Wmissing-prototypes] 5089 | netdev_tx_t rnpvf_xmit_frame_ring(struct sk_buff *skb, | ^~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5580:6: warning: no previous prototype for 'rnpvf_assign_netdev_ops' [-Wmissing-prototypes] 5580 | void rnpvf_assign_netdev_ops(struct net_device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c: In function 'rnpvf_request_msix_irqs': >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2129:72: warning: '%d' directive output may be truncated writing between 1 and 5 bytes into a region of size between 1 and 16 [-Wformat-truncation=] 2129 | sizeof(q_vector->name) - 1, "%s-%s-%d-%d", | ^~ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2129:62: note: directive argument in the range [0, 65535] 2129 | sizeof(q_vector->name) - 1, "%s-%s-%d-%d", | ^~~~~~~~~~~~~ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2128:25: note: 'snprintf' output between 10 and 29 bytes into a destination of size 24 2128 | snprintf(q_vector->name, | ^~~~~~~~~~~~~~~~~~~~~~~~ 2129 | sizeof(q_vector->name) - 1, "%s-%s-%d-%d", | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2130 | netdev->name, "TxRx", i, q_vector->v_idx); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/rnpvf_addr_list_itr +486 drivers/net/ethernet/mucse/rnpvf/vf.c 485 > 486 u8 *rnpvf_addr_list_itr(struct rnpvf_hw __maybe_unused *hw, 487 u8 **mc_addr_ptr) 488 { 489 struct netdev_hw_addr *mc_ptr; 490 u8 *addr = *mc_addr_ptr; 491 492 mc_ptr = container_of(addr, struct netdev_hw_addr, addr[0]); 493 if (mc_ptr->list.next) { 494 struct netdev_hw_addr *ha; 495 496 ha = list_entry(mc_ptr->list.next, struct netdev_hw_addr, 497 list); 498 *mc_addr_ptr = ha->addr; 499 } else { 500 *mc_addr_ptr = NULL; 501 } 502 503 return addr; 504 } 505 506 /** 507 * rnpvf_update_mc_addr_list_vf - Update Multicast addresses 508 * @hw: pointer to the HW structure 509 * @netdev: pointer to net device structure 510 * 511 * Updates the Multicast Table Array. 512 **/ 513 static s32 rnpvf_update_mc_addr_list_vf(struct rnpvf_hw *hw, 514 struct net_device *netdev) 515 { 516 struct netdev_hw_addr *ha; 517 u32 msgbuf[RNP_VFMAILBOX_SIZE]; 518 u16 *vector_list = (u16 *)&msgbuf[1]; 519 u32 cnt, i; 520 int addr_count = 0; 521 u8 *addr_list = NULL; 522 523 /* Each entry in the list uses 1 16 bit word. We have 30 524 * 16 bit words available in our HW msg buffer (minus 1 for the 525 * msg type). That's 30 hash values if we pack 'em right. If 526 * there are more than 30 MC addresses to add then punt the 527 * extras for now and then add code to handle more than 30 later. 528 * It would be unusual for a server to request that many multi-cast 529 * addresses except for in large enterprise network environments. 530 */ 531 532 cnt = netdev_mc_count(netdev); 533 if (cnt > 30) 534 cnt = 30; 535 msgbuf[0] = RNP_VF_SET_MULTICAST; 536 msgbuf[0] |= cnt << RNP_VT_MSGINFO_SHIFT; 537 538 addr_count = netdev_mc_count(netdev); 539 540 ha = list_first_entry(&netdev->mc.list, struct netdev_hw_addr, 541 list); 542 addr_list = ha->addr; 543 for (i = 0; i < addr_count; i++) { 544 vector_list[i] = rnpvf_mta_vector(hw, 545 rnpvf_addr_list_itr(hw, &addr_list)); 546 } 547 548 rnpvf_write_msg_read_ack(hw, msgbuf, RNP_VFMAILBOX_SIZE); 549 550 return 0; 551 } 552 553 /** 554 * rnpvf_set_vfta_vf - Set/Unset vlan filter table address 555 * @hw: pointer to the HW structure 556 * @vlan: 12 bit VLAN ID 557 * @vind: unused by VF drivers 558 * @vlan_on: if true then set bit, else clear bit 559 **/ 560 static s32 rnpvf_set_vfta_vf(struct rnpvf_hw *hw, u32 vlan, u32 vind, 561 bool vlan_on) 562 { 563 struct rnp_mbx_info *mbx = &hw->mbx; 564 u32 msgbuf[2]; 565 s32 err; 566 567 msgbuf[0] = RNP_VF_SET_VLAN; 568 msgbuf[1] = vlan; 569 /* Setting the 8 bit field MSG INFO to TRUE indicates "add" */ 570 msgbuf[0] |= vlan_on << RNP_VT_MSGINFO_SHIFT; 571 572 err = mbx->ops.write_posted(hw, msgbuf, 2, false); 573 if (err) 574 goto mbx_err; 575 576 err = mbx->ops.read_posted(hw, msgbuf, 2, false); 577 if (err) 578 goto mbx_err; 579 580 /* remove extra bits from the message */ 581 msgbuf[0] &= ~RNP_VT_MSGTYPE_CTS; 582 msgbuf[0] &= ~(0xFF << RNP_VT_MSGINFO_SHIFT); 583 584 if (msgbuf[0] != (RNP_VF_SET_VLAN | RNP_VT_MSGTYPE_ACK)) 585 err = RNP_ERR_INVALID_ARGUMENT; 586 587 mbx_err: 588 return err; 589 } 590 591 static s32 rnpvf_set_vlan_strip(struct rnpvf_hw *hw, bool vlan_on) 592 { 593 struct rnp_mbx_info *mbx = &hw->mbx; 594 struct rnpvf_adapter *adapter = (struct rnpvf_adapter *)hw->back; 595 u32 msgbuf[4]; 596 s32 err; 597 int i; 598 599 if (adapter->num_rx_queues > 2) { 600 err = -EINVAL; 601 goto mbx_err; 602 } 603 604 msgbuf[0] = RNP_VF_SET_VLAN_STRIP; 605 msgbuf[1] = (vlan_on << 31) | adapter->num_rx_queues; 606 607 for (i = 0; i < adapter->num_rx_queues; i++) 608 msgbuf[2 + i] = adapter->rx_ring[i]->rnpvf_queue_idx; 609 610 err = mbx->ops.write_posted(hw, msgbuf, 2 + adapter->num_rx_queues, 611 false); 612 if (err) 613 goto mbx_err; 614 615 err = mbx->ops.read_posted(hw, msgbuf, 1, false); 616 if (err) 617 goto mbx_err; 618 619 /* remove extra bits from the message */ 620 msgbuf[0] &= ~RNP_VT_MSGTYPE_CTS; 621 msgbuf[0] &= ~(0xFF << RNP_VT_MSGINFO_SHIFT); 622 623 if (msgbuf[0] != (RNP_VF_SET_VLAN_STRIP | RNP_VT_MSGTYPE_ACK)) 624 err = RNP_ERR_INVALID_ARGUMENT; 625 626 mbx_err: 627 return err; 628 } 629 630 /** 631 * rnpvf_setup_mac_link_vf - Setup MAC link settings 632 * @hw: pointer to hardware structure 633 * @speed: Unused in this implementation 634 * @autoneg: Unused in this implementation 635 * @autoneg_wait_to_complete: Unused in this implementation 636 * 637 * Do nothing and return success. VF drivers are not allowed to change 638 * global settings. Maintained for driver compatibility. 639 **/ 640 static s32 rnpvf_setup_mac_link_vf(struct rnpvf_hw *hw, 641 rnp_link_speed speed, bool autoneg, 642 bool autoneg_wait_to_complete) 643 { 644 return 0; 645 } 646 647 /** 648 * rnpvf_check_mac_link_vf - Get link/speed status 649 * @hw: pointer to hardware structure 650 * @speed: pointer to link speed 651 * @link_up: true is link is up, false otherwise 652 * @autoneg_wait_to_complete: true when waiting for completion is needed 653 * 654 * Reads the links register to determine if link is up and the current speed 655 **/ 656 static s32 rnpvf_check_mac_link_vf(struct rnpvf_hw *hw, 657 rnp_link_speed *speed, bool *link_up, 658 bool autoneg_wait_to_complete) 659 { 660 *speed = hw->speed; 661 *link_up = hw->link; 662 663 return 0; 664 } 665 666 /** 667 * rnpvf_rlpml_set_vf - Set the maximum receive packet length 668 * @hw: pointer to the HW structure 669 * @max_size: value to assign to max frame size 670 **/ 671 void rnpvf_rlpml_set_vf(struct rnpvf_hw *hw, u16 max_size) 672 { 673 u32 msgbuf[2]; 674 675 msgbuf[0] = RNP_VF_SET_LPE; 676 msgbuf[1] = max_size; 677 rnpvf_write_msg_read_ack(hw, msgbuf, 2); 678 } 679 680 /** 681 * rnpvf_negotiate_api_version - Negotiate supported API version 682 * @hw: pointer to the HW structure 683 * @api: integer containing requested API version 684 **/ > 685 int rnpvf_negotiate_api_version(struct rnpvf_hw *hw, int api) 686 { 687 return 0; 688 } 689 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 0/6] vfio/migration: some bugfix
by Longfang Liu 02 Apr '24

02 Apr '24

From: JiangShui Yang <yangjiangshui(a)h-partners.com> Longfang Liu (4): vfio/migration: added map length page alignment vfio/migration: bugfix some driver code vfio/migration: add eq and aeq interruption restore vfio/migration: bugfix cache write-back issue Weili Qian (2): vfio/migration: remove unused local variable hisi_acc_vfio_pci: obtain the mailbox configuration at one time drivers/crypto/hisilicon/qm.c | 15 ++- .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 125 +++++++++--------- .../vfio/pci/hisilicon/hisi_acc_vfio_pci.h | 3 + include/linux/hisi_acc_qm.h | 8 +- 4 files changed, 78 insertions(+), 73 deletions(-) -- 2.33.0

2 7

[PATCH openEuler-1.0-LTS 0/2] CVE-2024-26654
by liwei 02 Apr '24

02 Apr '24

CVE-2024-26654 Duoming Zhou (1): ALSA: sh: aica: reorder cleanup operations to avoid UAF bugs Takashi Iwai (1): ALSA: aica: Fix a long-time build breakage sound/sh/aica.c | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) -- 2.25.1

2 3

[PATCH OLK-5.10 v2 0/2] fix CVE-2023-52587
by Yu Liao 02 Apr '24

02 Apr '24

Daniel Vacek (1): IB/ipoib: Fix mcast list locking Jack Wang (1): RDMA/IPoIB: Fix error code return in ipoib_mcast_join drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) -- 2.25.1

2 3

[openeuler:openEuler-1.0-LTS 14777/22023] drivers/scsi/huawei/hifc/.tmp_hifc_module.o: warning: objtool: missing symbol for section .text
by kernel test robot 02 Apr '24

02 Apr '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 9268ff82cb11f4d613c20c217cafbf2bb1a85b45 commit: 7fc993d55d1b54ae40e29dfac825a18d04d644c6 [14777/22023] scsi/hifc: add hifc driver FC service module config: x86_64-buildonly-randconfig-001-20240329 (https://download.01.org/0day-ci/archive/20240402/202404022024.yOXMtyZl-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240402/202404022024.yOXMtyZl-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202404022024.yOXMtyZl-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from drivers/scsi/huawei/hifc/hifc_module.c:7: In file included from drivers/scsi/huawei/hifc/hifc_module.h:10: In file included from drivers/scsi/huawei/hifc/unf_common.h:9: In file included from drivers/scsi/huawei/hifc/unf_scsi_common.h:10: In file included from drivers/scsi/huawei/hifc/hifc_knl_adp.h:30: In file included from include/scsi/scsi_host.h:12: In file included from include/linux/blk-mq.h:5: In file included from include/linux/blkdev.h:16: include/linux/pagemap.h:425:21: warning: cast from 'int (*)(struct file *, struct page *)' to 'filler_t *' (aka 'int (*)(void *, struct page *)') converts to incompatible function type [-Wcast-function-type-strict] 425 | filler_t *filler = (filler_t *)mapping->a_ops->readpage; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/huawei/hifc/hifc_module.c:46:5: warning: no previous prototype for function 'hifc_init_module' [-Wmissing-prototypes] 46 | int hifc_init_module(void) | ^ drivers/scsi/huawei/hifc/hifc_module.c:46:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 46 | int hifc_init_module(void) | ^ | static drivers/scsi/huawei/hifc/hifc_module.c:88:6: warning: no previous prototype for function 'hifc_exit_module' [-Wmissing-prototypes] 88 | void hifc_exit_module(void) | ^ drivers/scsi/huawei/hifc/hifc_module.c:88:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 88 | void hifc_exit_module(void) | ^ | static 3 warnings generated. >> drivers/scsi/huawei/hifc/.tmp_hifc_module.o: warning: objtool: missing symbol for section .text -- In file included from drivers/scsi/huawei/hifc/hifc_sml.c:9: In file included from drivers/scsi/huawei/hifc/hifc_knl_adp.h:30: In file included from include/scsi/scsi_host.h:12: In file included from include/linux/blk-mq.h:5: In file included from include/linux/blkdev.h:16: include/linux/pagemap.h:425:21: warning: cast from 'int (*)(struct file *, struct page *)' to 'filler_t *' (aka 'int (*)(void *, struct page *)') converts to incompatible function type [-Wcast-function-type-strict] 425 | filler_t *filler = (filler_t *)mapping->a_ops->readpage; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/huawei/hifc/hifc_sml.c:114:5: warning: no previous prototype for function 'hifc_sm_ctr_rd32_clear' [-Wmissing-prototypes] 114 | int hifc_sm_ctr_rd32_clear(void *hwdev, u8 node, u8 instance, | ^ drivers/scsi/huawei/hifc/hifc_sml.c:114:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 114 | int hifc_sm_ctr_rd32_clear(void *hwdev, u8 node, u8 instance, | ^ | static drivers/scsi/huawei/hifc/hifc_sml.c:152:5: warning: no previous prototype for function 'hifc_sm_ctr_wr32' [-Wmissing-prototypes] 152 | int hifc_sm_ctr_wr32(void *hwdev, u8 node, u8 instance, u32 ctr_id, u32 value) | ^ drivers/scsi/huawei/hifc/hifc_sml.c:152:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 152 | int hifc_sm_ctr_wr32(void *hwdev, u8 node, u8 instance, u32 ctr_id, u32 value) | ^ | static drivers/scsi/huawei/hifc/hifc_sml.c:212:5: warning: no previous prototype for function 'hifc_sm_ctr_wr64' [-Wmissing-prototypes] 212 | int hifc_sm_ctr_wr64(void *hwdev, u8 node, u8 instance, u32 ctr_id, u64 value) | ^ drivers/scsi/huawei/hifc/hifc_sml.c:212:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 212 | int hifc_sm_ctr_wr64(void *hwdev, u8 node, u8 instance, u32 ctr_id, u64 value) | ^ | static drivers/scsi/huawei/hifc/hifc_sml.c:279:5: warning: no previous prototype for function 'hifc_sm_ctr_wr64_pair' [-Wmissing-prototypes] 279 | int hifc_sm_ctr_wr64_pair(void *hwdev, u8 node, u8 instance, | ^ drivers/scsi/huawei/hifc/hifc_sml.c:279:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 279 | int hifc_sm_ctr_wr64_pair(void *hwdev, u8 node, u8 instance, | ^ | static 5 warnings generated. >> drivers/scsi/huawei/hifc/.tmp_hifc_sml.o: warning: objtool: missing symbol for section .text -- In file included from drivers/scsi/huawei/hifc/hifc_wqe.c:7: In file included from drivers/scsi/huawei/hifc/hifc_module.h:10: In file included from drivers/scsi/huawei/hifc/unf_common.h:9: In file included from drivers/scsi/huawei/hifc/unf_scsi_common.h:10: In file included from drivers/scsi/huawei/hifc/hifc_knl_adp.h:30: In file included from include/scsi/scsi_host.h:12: In file included from include/linux/blk-mq.h:5: In file included from include/linux/blkdev.h:16: include/linux/pagemap.h:425:21: warning: cast from 'int (*)(struct file *, struct page *)' to 'filler_t *' (aka 'int (*)(void *, struct page *)') converts to incompatible function type [-Wcast-function-type-strict] 425 | filler_t *filler = (filler_t *)mapping->a_ops->readpage; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. >> drivers/scsi/huawei/hifc/.tmp_hifc_wqe.o: warning: objtool: missing symbol for section .text -- | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/huawei/hifc/unf_npiv.c:173:14: warning: no previous prototype for function 'unf_alloc_vp_index' [-Wmissing-prototypes] 173 | unsigned int unf_alloc_vp_index(struct unf_vport_pool_s *v_vport_pool, | ^ drivers/scsi/huawei/hifc/unf_npiv.c:173:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 173 | unsigned int unf_alloc_vp_index(struct unf_vport_pool_s *v_vport_pool, | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:229:6: warning: no previous prototype for function 'unf_free_vp_index' [-Wmissing-prototypes] 229 | void unf_free_vp_index(struct unf_vport_pool_s *v_vport_pool, | ^ drivers/scsi/huawei/hifc/unf_npiv.c:229:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 229 | void unf_free_vp_index(struct unf_vport_pool_s *v_vport_pool, | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:255:21: warning: no previous prototype for function 'unf_get_free_vport' [-Wmissing-prototypes] 255 | struct unf_lport_s *unf_get_free_vport(struct unf_lport_s *v_lport) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:255:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 255 | struct unf_lport_s *unf_get_free_vport(struct unf_lport_s *v_lport) | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:287:6: warning: no previous prototype for function 'unf_vport_back_to_pool' [-Wmissing-prototypes] 287 | void unf_vport_back_to_pool(void *v_vport) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:287:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 287 | void unf_vport_back_to_pool(void *v_vport) | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:312:6: warning: no previous prototype for function 'unf_init_vport_from_lport' [-Wmissing-prototypes] 312 | void unf_init_vport_from_lport(struct unf_lport_s *v_vport, | ^ drivers/scsi/huawei/hifc/unf_npiv.c:312:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 312 | void unf_init_vport_from_lport(struct unf_lport_s *v_vport, | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:339:6: warning: no previous prototype for function 'unf_check_vport_pool_status' [-Wmissing-prototypes] 339 | void unf_check_vport_pool_status(struct unf_lport_s *v_lport) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:339:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 339 | void unf_check_vport_pool_status(struct unf_lport_s *v_lport) | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:366:6: warning: no previous prototype for function 'unf_vport_deinit' [-Wmissing-prototypes] 366 | void unf_vport_deinit(void *v_vport) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:366:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 366 | void unf_vport_deinit(void *v_vport) | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:410:14: warning: no previous prototype for function 'unf_vport_init' [-Wmissing-prototypes] 410 | unsigned int unf_vport_init(void *v_vport) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:410:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 410 | unsigned int unf_vport_init(void *v_vport) | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:928:6: warning: no previous prototype for function 'unf_vport_abort_all_sfs_exch' [-Wmissing-prototypes] 928 | void unf_vport_abort_all_sfs_exch(struct unf_lport_s *vport) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:928:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 928 | void unf_vport_abort_all_sfs_exch(struct unf_lport_s *vport) | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:979:6: warning: no previous prototype for function 'unf_vport_abort_ini_io_exch' [-Wmissing-prototypes] 979 | void unf_vport_abort_ini_io_exch(struct unf_lport_s *vport) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:979:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 979 | void unf_vport_abort_ini_io_exch(struct unf_lport_s *vport) | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:1028:6: warning: no previous prototype for function 'unf_vport_abort_all_exch' [-Wmissing-prototypes] 1028 | void unf_vport_abort_all_exch(struct unf_lport_s *vport) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:1028:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1028 | void unf_vport_abort_all_exch(struct unf_lport_s *vport) | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:1037:14: warning: no previous prototype for function 'unf_vport_wait_all_exch_removed' [-Wmissing-prototypes] 1037 | unsigned int unf_vport_wait_all_exch_removed(struct unf_lport_s *vport) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:1037:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1037 | unsigned int unf_vport_wait_all_exch_removed(struct unf_lport_s *vport) | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:1114:14: warning: no previous prototype for function 'unf_vport_wait_rports_removed' [-Wmissing-prototypes] 1114 | unsigned int unf_vport_wait_rports_removed(struct unf_lport_s *vport) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:1114:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1114 | unsigned int unf_vport_wait_rports_removed(struct unf_lport_s *vport) | ^ | static drivers/scsi/huawei/hifc/unf_npiv.c:1303:5: warning: no previous prototype for function 'unf_process_vports_linkup' [-Wmissing-prototypes] 1303 | int unf_process_vports_linkup(void *v_arg_in, void *v_arg_out) | ^ drivers/scsi/huawei/hifc/unf_npiv.c:1303:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1303 | int unf_process_vports_linkup(void *v_arg_in, void *v_arg_out) | ^ | static 15 warnings generated. >> drivers/scsi/huawei/hifc/.tmp_unf_npiv.o: warning: objtool: missing symbol for section .text -- In file included from drivers/scsi/huawei/hifc/unf_event.c:8: In file included from drivers/scsi/huawei/hifc/unf_common.h:9: In file included from drivers/scsi/huawei/hifc/unf_scsi_common.h:10: In file included from drivers/scsi/huawei/hifc/hifc_knl_adp.h:30: In file included from include/scsi/scsi_host.h:12: In file included from include/linux/blk-mq.h:5: In file included from include/linux/blkdev.h:16: include/linux/pagemap.h:425:21: warning: cast from 'int (*)(struct file *, struct page *)' to 'filler_t *' (aka 'int (*)(void *, struct page *)') converts to incompatible function type [-Wcast-function-type-strict] 425 | filler_t *filler = (filler_t *)mapping->a_ops->readpage; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/huawei/hifc/unf_event.c:18:14: warning: no previous prototype for function 'unf_init_event_msg' [-Wmissing-prototypes] 18 | unsigned int unf_init_event_msg(struct unf_lport_s *v_lport) | ^ drivers/scsi/huawei/hifc/unf_event.c:18:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 18 | unsigned int unf_init_event_msg(struct unf_lport_s *v_lport) | ^ | static drivers/scsi/huawei/hifc/unf_event.c:69:6: warning: no previous prototype for function 'unf_init_event_node' [-Wmissing-prototypes] 69 | void unf_init_event_node(struct unf_cm_event_report *v_event_node) | ^ drivers/scsi/huawei/hifc/unf_event.c:69:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 69 | void unf_init_event_node(struct unf_cm_event_report *v_event_node) | ^ | static drivers/scsi/huawei/hifc/unf_event.c:85:29: warning: no previous prototype for function 'unf_get_free_event_node' [-Wmissing-prototypes] 85 | struct unf_cm_event_report *unf_get_free_event_node(void *v_lport) | ^ drivers/scsi/huawei/hifc/unf_event.c:85:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 85 | struct unf_cm_event_report *unf_get_free_event_node(void *v_lport) | ^ | static drivers/scsi/huawei/hifc/unf_event.c:128:6: warning: no previous prototype for function 'unf_check_event_mgr_status' [-Wmissing-prototypes] 128 | void unf_check_event_mgr_status(struct unf_event_mgr *v_event_mgr) | ^ drivers/scsi/huawei/hifc/unf_event.c:128:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 128 | void unf_check_event_mgr_status(struct unf_event_mgr *v_event_mgr) | ^ | static drivers/scsi/huawei/hifc/unf_event.c:142:6: warning: no previous prototype for function 'unf_release_event' [-Wmissing-prototypes] 142 | void unf_release_event(void *v_lport, void *v_event_node) | ^ drivers/scsi/huawei/hifc/unf_event.c:142:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 142 | void unf_release_event(void *v_lport, void *v_event_node) | ^ | static drivers/scsi/huawei/hifc/unf_event.c:166:6: warning: no previous prototype for function 'unf_post_event' [-Wmissing-prototypes] 166 | void unf_post_event(void *v_lport, void *v_event_node) | ^ drivers/scsi/huawei/hifc/unf_event.c:166:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 166 | void unf_post_event(void *v_lport, void *v_event_node) | ^ | static drivers/scsi/huawei/hifc/unf_event.c:249:6: warning: no previous prototype for function 'unf_wait_event_mgr_complete' [-Wmissing-prototypes] 249 | void unf_wait_event_mgr_complete(struct unf_event_mgr *v_event_mgr) | ^ drivers/scsi/huawei/hifc/unf_event.c:249:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 249 | void unf_wait_event_mgr_complete(struct unf_event_mgr *v_event_mgr) | ^ | static drivers/scsi/huawei/hifc/unf_event.c:355:6: warning: no previous prototype for function 'unf_release_global_event' [-Wmissing-prototypes] 355 | void unf_release_global_event(void *v_event_node) | ^ drivers/scsi/huawei/hifc/unf_event.c:355:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 355 | void unf_release_global_event(void *v_event_node) | ^ | static 9 warnings generated. >> drivers/scsi/huawei/hifc/.tmp_unf_event.o: warning: objtool: missing symbol for section .text -- In file included from drivers/scsi/huawei/hifc/hifc_cqm_main.c:13: In file included from drivers/scsi/huawei/hifc/hifc_knl_adp.h:30: In file included from include/scsi/scsi_host.h:12: In file included from include/linux/blk-mq.h:5: In file included from include/linux/blkdev.h:16: include/linux/pagemap.h:425:21: warning: cast from 'int (*)(struct file *, struct page *)' to 'filler_t *' (aka 'int (*)(void *, struct page *)') converts to incompatible function type [-Wcast-function-type-strict] 425 | filler_t *filler = (filler_t *)mapping->a_ops->readpage; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/huawei/hifc/hifc_cqm_main.c:46:6: warning: no previous prototype for function 'cqm_test_mode_init' [-Wmissing-prototypes] 46 | void cqm_test_mode_init(struct cqm_handle_s *cqm_handle, | ^ drivers/scsi/huawei/hifc/hifc_cqm_main.c:46:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 46 | void cqm_test_mode_init(struct cqm_handle_s *cqm_handle, | ^ | static drivers/scsi/huawei/hifc/hifc_cqm_main.c:95:5: warning: no previous prototype for function 'cqm_service_capability_init' [-Wmissing-prototypes] 95 | s32 cqm_service_capability_init(struct cqm_handle_s *cqm_handle, | ^ drivers/scsi/huawei/hifc/hifc_cqm_main.c:95:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 95 | s32 cqm_service_capability_init(struct cqm_handle_s *cqm_handle, | ^ | static drivers/scsi/huawei/hifc/hifc_cqm_main.c:114:5: warning: no previous prototype for function 'cqm_capability_init' [-Wmissing-prototypes] 114 | s32 cqm_capability_init(void *ex_handle) | ^ drivers/scsi/huawei/hifc/hifc_cqm_main.c:114:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 114 | s32 cqm_capability_init(void *ex_handle) | ^ | static drivers/scsi/huawei/hifc/hifc_cqm_main.c:431:5: warning: no previous prototype for function 'cqm_db_addr_alloc' [-Wmissing-prototypes] 431 | s32 cqm_db_addr_alloc(void *ex_handle, void __iomem **db_addr, | ^ drivers/scsi/huawei/hifc/hifc_cqm_main.c:431:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 431 | s32 cqm_db_addr_alloc(void *ex_handle, void __iomem **db_addr, | ^ | static drivers/scsi/huawei/hifc/hifc_cqm_main.c:476:6: warning: no previous prototype for function 'cqm_db_addr_free' [-Wmissing-prototypes] 476 | void cqm_db_addr_free(void *ex_handle, void __iomem *db_addr, | ^ drivers/scsi/huawei/hifc/hifc_cqm_main.c:476:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 476 | void cqm_db_addr_free(void *ex_handle, void __iomem *db_addr, | ^ | static 6 warnings generated. drivers/scsi/huawei/hifc/hifc_cqm_main.c:592: warning: Excess function parameter 'service_type' description in 'cqm_service_unregister' >> drivers/scsi/huawei/hifc/.tmp_hifc_cqm_main.o: warning: objtool: missing symbol for section .text -- In file included from drivers/scsi/huawei/hifc/hifc_portmng.c:6: In file included from drivers/scsi/huawei/hifc/hifc_module.h:10: In file included from drivers/scsi/huawei/hifc/unf_common.h:9: In file included from drivers/scsi/huawei/hifc/unf_scsi_common.h:10: In file included from drivers/scsi/huawei/hifc/hifc_knl_adp.h:30: In file included from include/scsi/scsi_host.h:12: In file included from include/linux/blk-mq.h:5: In file included from include/linux/blkdev.h:16: include/linux/pagemap.h:425:21: warning: cast from 'int (*)(struct file *, struct page *)' to 'filler_t *' (aka 'int (*)(void *, struct page *)') converts to incompatible function type [-Wcast-function-type-strict] 425 | filler_t *filler = (filler_t *)mapping->a_ops->readpage; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/huawei/hifc/hifc_portmng.c:570:5: warning: no previous prototype for function 'hifc_dfx_get_rxtx_error_state' [-Wmissing-prototypes] 570 | int hifc_dfx_get_rxtx_error_state(void *v_hba, void *v_buff_out) | ^ drivers/scsi/huawei/hifc/hifc_portmng.c:570:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 570 | int hifc_dfx_get_rxtx_error_state(void *v_hba, void *v_buff_out) | ^ | static drivers/scsi/huawei/hifc/hifc_portmng.c:1118:14: warning: no previous prototype for function 'hifc_port_info' [-Wmissing-prototypes] 1118 | unsigned int hifc_port_info(struct unf_hinicam_pkg *v_input) | ^ drivers/scsi/huawei/hifc/hifc_portmng.c:1118:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1118 | unsigned int hifc_port_info(struct unf_hinicam_pkg *v_input) | ^ | static 3 warnings generated. >> drivers/scsi/huawei/hifc/.tmp_hifc_portmng.o: warning: objtool: missing symbol for section .text .. -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH openEuler-1.0-LTS 0/2] net: hns3: updates 2024.04.02
by Yonglong Liu 02 Apr '24

02 Apr '24

This patch set fix a bug for hns3 driver and modify the driver version. Yonglong Liu (2): net: hns3: fix port vlan filter not disabled problem in dynamic vlan mode net: hns3: update hns3 version to 24.3.1 drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 +- .../ethernet/hisilicon/hns3/hns3_cae/hns3_cae_version.h | 2 +- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 2 +- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 9 +++++++-- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 2 +- .../net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 2 +- 6 files changed, 12 insertions(+), 7 deletions(-) -- 2.17.1

2 3

[PATCH openEuler-1.0-LTS 0/2] net: hns3: updates 2024.04.02
by Yonglong Liu 02 Apr '24

02 Apr '24

This patch set fix a bug for hns3 driver and modify the driver version. Yonglong Liu (2): net: hns3: fix port vlan filter not disabled problem in dynamic vlan mode net: hns3: update hns3 version to 24.3.1 drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 +- .../ethernet/hisilicon/hns3/hns3_cae/hns3_cae_version.h | 2 +- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 2 +- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 9 +++++++-- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 2 +- .../net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 2 +- 6 files changed, 12 insertions(+), 7 deletions(-) -- 2.17.1

2 3

[PATCH openEuler-1.0-LTS v2] tipc: wait and exit until all work queues are done
by Ziyang Xuan 02 Apr '24

02 Apr '24

From: Xin Long <lucien.xin(a)gmail.com> mainline inclusion from mainline-v5.13-rc4 commit 04c26faa51d1e2fe71cf13c45791f5174c37f986 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9BHRY CVE: CVE-2021-47163 -------------------------------- On some host, a crash could be triggered simply by repeating these commands several times: # modprobe tipc # tipc bearer enable media udp name UDP1 localip 127.0.0.1 # rmmod tipc [] BUG: unable to handle kernel paging request at ffffffffc096bb00 [] Workqueue: events 0xffffffffc096bb00 [] Call Trace: [] ? process_one_work+0x1a7/0x360 [] ? worker_thread+0x30/0x390 [] ? create_worker+0x1a0/0x1a0 [] ? kthread+0x116/0x130 [] ? kthread_flush_work_fn+0x10/0x10 [] ? ret_from_fork+0x35/0x40 When removing the TIPC module, the UDP tunnel sock will be delayed to release in a work queue as sock_release() can't be done in rtnl_lock(). If the work queue is schedule to run after the TIPC module is removed, kernel will crash as the work queue function cleanup_beareri() code no longer exists when trying to invoke it. To fix it, this patch introduce a member wq_count in tipc_net to track the numbers of work queues in schedule, and wait and exit until all work queues are done in tipc_exit_net(). Fixes: d0f91938bede ("tipc: add ip/udp media type") Reported-by: Shuang Li <shuali(a)redhat.com> Signed-off-by: Xin Long <lucien.xin(a)gmail.com> Acked-by: Jon Maloy <jmaloy(a)redhat.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Conflicts: net/tipc/core.c net/tipc/core.h net/tipc/udp_media.c Signed-off-by: Ziyang Xuan <william.xuanziyang(a)huawei.com> --- v2: - Remove "Reference" in comment header. --- net/tipc/core.c | 5 +++++ net/tipc/core.h | 3 +++ net/tipc/udp_media.c | 2 ++ 3 files changed, 10 insertions(+) diff --git a/net/tipc/core.c b/net/tipc/core.c index 49bb9fc0aa06..7b61e1650cb0 100644 --- a/net/tipc/core.c +++ b/net/tipc/core.c @@ -92,10 +92,15 @@ static int __net_init tipc_init_net(struct net *net) static void __net_exit tipc_exit_net(struct net *net) { + struct tipc_net *tn = tipc_net(net); + tipc_net_stop(net); tipc_bcast_stop(net); tipc_nametbl_stop(net); tipc_sk_rht_destroy(net); + + while (atomic_read(&tn->wq_count)) + cond_resched(); } static struct pernet_operations tipc_net_ops = { diff --git a/net/tipc/core.h b/net/tipc/core.h index 8020a6c360ff..3abbdbffd460 100644 --- a/net/tipc/core.h +++ b/net/tipc/core.h @@ -122,6 +122,9 @@ struct tipc_net { /* Topology subscription server */ struct tipc_topsrv *topsrv; atomic_t subscription_count; + + /* The numbers of work queues in schedule */ + atomic_t wq_count; }; static inline struct tipc_net *tipc_net(struct net *net) diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index 1d6235479706..efe822d3bb28 100644 --- a/net/tipc/udp_media.c +++ b/net/tipc/udp_media.c @@ -771,6 +771,7 @@ static void cleanup_bearer(struct work_struct *work) kfree_rcu(rcast, rcu); } + atomic_dec(&tipc_net(sock_net(ub->ubsock->sk))->wq_count); if (ub->ubsock) udp_tunnel_sock_release(ub->ubsock); synchronize_net(); @@ -792,6 +793,7 @@ static void tipc_udp_disable(struct tipc_bearer *b) RCU_INIT_POINTER(ub->bearer, NULL); /* sock_release need to be done outside of rtnl lock */ + atomic_inc(&tipc_net(sock_net(ub->ubsock->sk))->wq_count); INIT_WORK(&ub->work, cleanup_bearer); schedule_work(&ub->work); } -- 2.25.1

2 1

[PATCH openEuler-1.0-LTS v2] ip6_tunnel: make sure to pull inner header in __ip6_tnl_rcv()
by Dong Chenchen 02 Apr '24

02 Apr '24

From: Eric Dumazet <edumazet(a)google.com> mainline inclusion from mainline-v6.8-rc1 commit 8d975c15c0cd744000ca386247432d57b21f9df0 category: bugfix bugzilla: 189707, https://gitee.com/src-openeuler/kernel/issues/I99JV2 CVE: CVE-2024-26641 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- syzbot found __ip6_tnl_rcv() could access unitiliazed data [1]. Call pskb_inet_may_pull() to fix this, and initialize ipv6h variable after this call as it can change skb->head. [1] BUG: KMSAN: uninit-value in __INET_ECN_decapsulate include/net/inet_ecn.h:253 [inline] BUG: KMSAN: uninit-value in INET_ECN_decapsulate include/net/inet_ecn.h:275 [inline] BUG: KMSAN: uninit-value in IP6_ECN_decapsulate+0x7df/0x1e50 include/net/inet_ecn.h:321 __INET_ECN_decapsulate include/net/inet_ecn.h:253 [inline] INET_ECN_decapsulate include/net/inet_ecn.h:275 [inline] IP6_ECN_decapsulate+0x7df/0x1e50 include/net/inet_ecn.h:321 ip6ip6_dscp_ecn_decapsulate+0x178/0x1b0 net/ipv6/ip6_tunnel.c:727 __ip6_tnl_rcv+0xd4e/0x1590 net/ipv6/ip6_tunnel.c:845 ip6_tnl_rcv+0xce/0x100 net/ipv6/ip6_tunnel.c:888 gre_rcv+0x143f/0x1870 ip6_protocol_deliver_rcu+0xda6/0x2a60 net/ipv6/ip6_input.c:438 ip6_input_finish net/ipv6/ip6_input.c:483 [inline] NF_HOOK include/linux/netfilter.h:314 [inline] ip6_input+0x15d/0x430 net/ipv6/ip6_input.c:492 ip6_mc_input+0xa7e/0xc80 net/ipv6/ip6_input.c:586 dst_input include/net/dst.h:461 [inline] ip6_rcv_finish+0x5db/0x870 net/ipv6/ip6_input.c:79 NF_HOOK include/linux/netfilter.h:314 [inline] ipv6_rcv+0xda/0x390 net/ipv6/ip6_input.c:310 __netif_receive_skb_one_core net/core/dev.c:5532 [inline] __netif_receive_skb+0x1a6/0x5a0 net/core/dev.c:5646 netif_receive_skb_internal net/core/dev.c:5732 [inline] netif_receive_skb+0x58/0x660 net/core/dev.c:5791 tun_rx_batched+0x3ee/0x980 drivers/net/tun.c:1555 tun_get_user+0x53af/0x66d0 drivers/net/tun.c:2002 tun_chr_write_iter+0x3af/0x5d0 drivers/net/tun.c:2048 call_write_iter include/linux/fs.h:2084 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0x786/0x1200 fs/read_write.c:590 ksys_write+0x20f/0x4c0 fs/read_write.c:643 __do_sys_write fs/read_write.c:655 [inline] __se_sys_write fs/read_write.c:652 [inline] __x64_sys_write+0x93/0xd0 fs/read_write.c:652 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x6d/0x140 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b Uninit was created at: slab_post_alloc_hook+0x129/0xa70 mm/slab.h:768 slab_alloc_node mm/slub.c:3478 [inline] kmem_cache_alloc_node+0x5e9/0xb10 mm/slub.c:3523 kmalloc_reserve+0x13d/0x4a0 net/core/skbuff.c:560 __alloc_skb+0x318/0x740 net/core/skbuff.c:651 alloc_skb include/linux/skbuff.h:1286 [inline] alloc_skb_with_frags+0xc8/0xbd0 net/core/skbuff.c:6334 sock_alloc_send_pskb+0xa80/0xbf0 net/core/sock.c:2787 tun_alloc_skb drivers/net/tun.c:1531 [inline] tun_get_user+0x1e8a/0x66d0 drivers/net/tun.c:1846 tun_chr_write_iter+0x3af/0x5d0 drivers/net/tun.c:2048 call_write_iter include/linux/fs.h:2084 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0x786/0x1200 fs/read_write.c:590 ksys_write+0x20f/0x4c0 fs/read_write.c:643 __do_sys_write fs/read_write.c:655 [inline] __se_sys_write fs/read_write.c:652 [inline] __x64_sys_write+0x93/0xd0 fs/read_write.c:652 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x6d/0x140 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b CPU: 0 PID: 5034 Comm: syz-executor331 Not tainted 6.7.0-syzkaller-00562-g9f8413c4a66f #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Fixes: 0d3c703a9d17 ("ipv6: Cleanup IPv6 tunnel receive path") Reported-by: syzbot <syzkaller(a)googlegroups.com> Signed-off-by: Eric Dumazet <edumazet(a)google.com> Reviewed-by: Simon Horman <horms(a)kernel.org> Link: https://lore.kernel.org/r/20240125170557.2663942-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> Conflicts: net/ipv6/ip6_tunnel.c Signed-off-by: Dong Chenchen <dongchenchen2(a)huawei.com> --- net/ipv6/ip6_tunnel.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index b647a4037679..6e2cd2a94781 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @@ -780,8 +780,8 @@ static int __ip6_tnl_rcv(struct ip6_tnl *tunnel, struct sk_buff *skb, bool log_ecn_err) { struct pcpu_sw_netstats *tstats; - const struct ipv6hdr *ipv6h = ipv6_hdr(skb); - int err; + const struct ipv6hdr *ipv6h; + int nh, err; if ((!(tpi->flags & TUNNEL_CSUM) && (tunnel->parms.i_flags & TUNNEL_CSUM)) || @@ -813,14 +813,29 @@ static int __ip6_tnl_rcv(struct ip6_tnl *tunnel, struct sk_buff *skb, goto drop; } - ipv6h = ipv6_hdr(skb); skb->protocol = eth_type_trans(skb, tunnel->dev); skb_postpull_rcsum(skb, eth_hdr(skb), ETH_HLEN); } else { skb->dev = tunnel->dev; } + /* Save offset of outer header relative to skb->head, + * because we are going to reset the network header to the inner header + * and might change skb->head. + */ + nh = skb_network_header(skb) - skb->head; + skb_reset_network_header(skb); + + if (!pskb_inet_may_pull(skb)) { + DEV_STATS_INC(tunnel->dev, rx_length_errors); + DEV_STATS_INC(tunnel->dev, rx_errors); + goto drop; + } + + /* Get the outer header. */ + ipv6h = (struct ipv6hdr *)(skb->head + nh); + memset(skb->cb, 0, sizeof(struct inet6_skb_parm)); __skb_tunnel_rx(skb, tunnel->dev, tunnel->net); -- 2.25.1

2 1

[openeuler:openEuler-1.0-LTS 21385/22019] drivers/tee/optee/core.c:618:31: sparse: sparse: incorrect type in return expression (different base types)
by kernel test robot 02 Apr '24

02 Apr '24

Hi Ard, First bad commit (maybe != root cause): tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: d246e7fa919fdfd1ff81b422adf53047558c3aee commit: 595311cf7e49c781dd26782e4b45fd54bbfb3e40 [21385/22019] optee: model OP-TEE as a platform device/driver config: arm64-randconfig-r111-20240331 (https://download.01.org/0day-ci/archive/20240402/202404021149.LAZ7pTf4-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20240402/202404021149.LAZ7pTf4-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202404021149.LAZ7pTf4-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/tee/optee/core.c:618:31: sparse: sparse: incorrect type in return expression (different base types) @@ expected int @@ got void * @@ drivers/tee/optee/core.c:618:31: sparse: expected int drivers/tee/optee/core.c:618:31: sparse: got void * drivers/tee/optee/core.c: In function 'optee_probe': drivers/tee/optee/core.c:618:24: warning: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] 618 | return ERR_PTR(-EINVAL); | ^~~~~~~~~~~~~~~~ vim +618 drivers/tee/optee/core.c 595311cf7e49c7 Ard Biesheuvel 2019-12-09 581 595311cf7e49c7 Ard Biesheuvel 2019-12-09 582 static int optee_probe(struct platform_device *pdev) 4fb0a5eb364d23 Jens Wiklander 2015-04-14 583 { 4fb0a5eb364d23 Jens Wiklander 2015-04-14 584 optee_invoke_fn *invoke_fn; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 585 struct tee_shm_pool *pool; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 586 struct optee *optee = NULL; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 587 void *memremaped_shm = NULL; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 588 struct tee_device *teedev; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 589 u32 sec_caps; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 590 int rc; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 591 595311cf7e49c7 Ard Biesheuvel 2019-12-09 592 invoke_fn = get_invoke_func(&pdev->dev); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 593 if (IS_ERR(invoke_fn)) 595311cf7e49c7 Ard Biesheuvel 2019-12-09 594 return PTR_ERR(invoke_fn); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 595 4fb0a5eb364d23 Jens Wiklander 2015-04-14 596 if (!optee_msg_api_uid_is_optee_api(invoke_fn)) { 4fb0a5eb364d23 Jens Wiklander 2015-04-14 597 pr_warn("api uid mismatch\n"); 595311cf7e49c7 Ard Biesheuvel 2019-12-09 598 return -EINVAL; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 599 } 4fb0a5eb364d23 Jens Wiklander 2015-04-14 600 5c5f80307ab27c Jérôme Forissier 2017-11-24 601 optee_msg_get_os_revision(invoke_fn); 5c5f80307ab27c Jérôme Forissier 2017-11-24 602 4fb0a5eb364d23 Jens Wiklander 2015-04-14 603 if (!optee_msg_api_revision_is_compatible(invoke_fn)) { 4fb0a5eb364d23 Jens Wiklander 2015-04-14 604 pr_warn("api revision mismatch\n"); 595311cf7e49c7 Ard Biesheuvel 2019-12-09 605 return -EINVAL; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 606 } 4fb0a5eb364d23 Jens Wiklander 2015-04-14 607 4fb0a5eb364d23 Jens Wiklander 2015-04-14 608 if (!optee_msg_exchange_capabilities(invoke_fn, &sec_caps)) { 4fb0a5eb364d23 Jens Wiklander 2015-04-14 609 pr_warn("capabilities mismatch\n"); 595311cf7e49c7 Ard Biesheuvel 2019-12-09 610 return -EINVAL; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 611 } 4fb0a5eb364d23 Jens Wiklander 2015-04-14 612 4fb0a5eb364d23 Jens Wiklander 2015-04-14 613 /* 4fb0a5eb364d23 Jens Wiklander 2015-04-14 614 * We have no other option for shared memory, if secure world 4fb0a5eb364d23 Jens Wiklander 2015-04-14 615 * doesn't have any reserved memory we can use we can't continue. 4fb0a5eb364d23 Jens Wiklander 2015-04-14 616 */ 4fb0a5eb364d23 Jens Wiklander 2015-04-14 617 if (!(sec_caps & OPTEE_SMC_SEC_CAP_HAVE_RESERVED_SHM)) 4fb0a5eb364d23 Jens Wiklander 2015-04-14 @618 return ERR_PTR(-EINVAL); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 619 f58e236c9d665a Volodymyr Babchuk 2017-11-29 620 pool = optee_config_shm_memremap(invoke_fn, &memremaped_shm, sec_caps); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 621 if (IS_ERR(pool)) 595311cf7e49c7 Ard Biesheuvel 2019-12-09 622 return PTR_ERR(pool); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 623 4fb0a5eb364d23 Jens Wiklander 2015-04-14 624 optee = kzalloc(sizeof(*optee), GFP_KERNEL); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 625 if (!optee) { 4fb0a5eb364d23 Jens Wiklander 2015-04-14 626 rc = -ENOMEM; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 627 goto err; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 628 } 4fb0a5eb364d23 Jens Wiklander 2015-04-14 629 4fb0a5eb364d23 Jens Wiklander 2015-04-14 630 optee->invoke_fn = invoke_fn; d885cc5e0759fc Volodymyr Babchuk 2017-11-29 631 optee->sec_caps = sec_caps; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 632 4fb0a5eb364d23 Jens Wiklander 2015-04-14 633 teedev = tee_device_alloc(&optee_desc, NULL, pool, optee); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 634 if (IS_ERR(teedev)) { 4fb0a5eb364d23 Jens Wiklander 2015-04-14 635 rc = PTR_ERR(teedev); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 636 goto err; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 637 } 4fb0a5eb364d23 Jens Wiklander 2015-04-14 638 optee->teedev = teedev; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 639 4fb0a5eb364d23 Jens Wiklander 2015-04-14 640 teedev = tee_device_alloc(&optee_supp_desc, NULL, pool, optee); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 641 if (IS_ERR(teedev)) { 4fb0a5eb364d23 Jens Wiklander 2015-04-14 642 rc = PTR_ERR(teedev); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 643 goto err; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 644 } 4fb0a5eb364d23 Jens Wiklander 2015-04-14 645 optee->supp_teedev = teedev; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 646 4fb0a5eb364d23 Jens Wiklander 2015-04-14 647 rc = tee_device_register(optee->teedev); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 648 if (rc) 4fb0a5eb364d23 Jens Wiklander 2015-04-14 649 goto err; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 650 4fb0a5eb364d23 Jens Wiklander 2015-04-14 651 rc = tee_device_register(optee->supp_teedev); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 652 if (rc) 4fb0a5eb364d23 Jens Wiklander 2015-04-14 653 goto err; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 654 4fb0a5eb364d23 Jens Wiklander 2015-04-14 655 mutex_init(&optee->call_queue.mutex); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 656 INIT_LIST_HEAD(&optee->call_queue.waiters); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 657 optee_wait_queue_init(&optee->wait_queue); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 658 optee_supp_init(&optee->supp); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 659 optee->memremaped_shm = memremaped_shm; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 660 optee->pool = pool; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 661 4fb0a5eb364d23 Jens Wiklander 2015-04-14 662 optee_enable_shm_cache(optee); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 663 595311cf7e49c7 Ard Biesheuvel 2019-12-09 664 platform_set_drvdata(pdev, optee); 595311cf7e49c7 Ard Biesheuvel 2019-12-09 665 4fb0a5eb364d23 Jens Wiklander 2015-04-14 666 pr_info("initialized driver\n"); 595311cf7e49c7 Ard Biesheuvel 2019-12-09 667 return 0; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 668 err: 4fb0a5eb364d23 Jens Wiklander 2015-04-14 669 if (optee) { 4fb0a5eb364d23 Jens Wiklander 2015-04-14 670 /* 4fb0a5eb364d23 Jens Wiklander 2015-04-14 671 * tee_device_unregister() is safe to call even if the 4fb0a5eb364d23 Jens Wiklander 2015-04-14 672 * devices hasn't been registered with 4fb0a5eb364d23 Jens Wiklander 2015-04-14 673 * tee_device_register() yet. 4fb0a5eb364d23 Jens Wiklander 2015-04-14 674 */ 4fb0a5eb364d23 Jens Wiklander 2015-04-14 675 tee_device_unregister(optee->supp_teedev); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 676 tee_device_unregister(optee->teedev); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 677 kfree(optee); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 678 } 4fb0a5eb364d23 Jens Wiklander 2015-04-14 679 if (pool) 4fb0a5eb364d23 Jens Wiklander 2015-04-14 680 tee_shm_pool_free(pool); 4fb0a5eb364d23 Jens Wiklander 2015-04-14 681 if (memremaped_shm) 4fb0a5eb364d23 Jens Wiklander 2015-04-14 682 memunmap(memremaped_shm); 595311cf7e49c7 Ard Biesheuvel 2019-12-09 683 return rc; 4fb0a5eb364d23 Jens Wiklander 2015-04-14 684 } 4fb0a5eb364d23 Jens Wiklander 2015-04-14 685 :::::: The code at line 618 was first introduced by commit :::::: 4fb0a5eb364d239722e745c02aef0dbd4e0f1ad2 tee: add OP-TEE driver :::::: TO: Jens Wiklander <jens.wiklander(a)linaro.org> :::::: CC: Jens Wiklander <jens.wiklander(a)linaro.org> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0