- Kernel - mailweb.openeuler.org

[PATCH OLK-5.10] block: remove precise_iostat
by Li Nan 23 Jan '24

23 Jan '24

hulk inclusion category: bugfix bugzilla: 189480, https://gitee.com/openeuler/kernel/issues/I8Y90L -------------------------------- Previously, we believed it would be too costly to sum all the percpu variables 'in_flight' every jiffy if we want to count io accurately. So we added switch 'precise_iostat' and set it to false be default. However, the overhead of precise_iostat is 1. inc and dev in_flight when submitting io and done io 2. read in_flight up to HZ times per second It is much lower than our previous evaluation and can be ignored. Now, turn on the switch by default. And it will be removed in the feature. Signed-off-by: Li Nan <linan122(a)huawei.com> --- block/blk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index 3564de78f102..f91f8e8be482 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -62,7 +62,7 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(block_unplug); DEFINE_IDA(blk_queue_ida); -bool precise_iostat; +bool precise_iostat = true; static int __init precise_iostat_setup(char *str) { -- 2.39.2

2 1

[PATCH OLK-6.6 0/1] arm64: Add CONFIG_IPI_AS_NMI to IPI as NMI feature
by Liao Chen 23 Jan '24

23 Jan '24

This patch adds CONFIG_IPI_AS_NMI to control the availability of pseudo NMIs, which follows upstream commit 41ddf73f9f7e (arm64: Add framework to turn IPI as NMI). CONFIG_IPI_AS_NMI depends on: ARM64_PSEUDO_NMI=y Liao Chen (1): arm64: Add CONFIG_IPI_AS_NMI to IPI as NMI feature arch/arm64/Kconfig | 12 +++++++++++- arch/arm64/include/asm/irq.h | 2 +- arch/arm64/kernel/Makefile | 3 ++- arch/arm64/kernel/kgdb.c | 2 ++ arch/arm64/kernel/smp.c | 6 ++++++ include/linux/kgdb.h | 2 ++ kernel/debug/debug_core.c | 6 ++++++ 7 files changed, 30 insertions(+), 3 deletions(-) -- 2.34.1

2 2

[PATCH OLK-6.6 v2] tcp: fix compilation issue when CONFIG_SYSCTL is disabled
by Zhengchao Shao 23 Jan '24

23 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8Y7PX CVE: NA -------------------------------- The following error is reported when the kernel is compiled with CONFIG_SYSCTL disabled: aarch64-linux-ld: net/ipv4/inet_hashtables.o: in function `__inet_hash_connect': inet_hashtables.c:(.text+0x3564): undefined reference to `sysctl_local_port_allocation' aarch64-linux-ld: net/ipv4/inet_hashtables.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `sysctl_local_port_allocation' which may bind externally can not be used when making a shared object; recompile with -fPIC >> inet_hashtables.c:(.text+0x3564): dangerous relocation: unsupported relocation aarch64-linux-ld: inet_hashtables.c:(.text+0x3568): undefined reference to `sysctl_local_port_allocation' aarch64-linux-ld: inet_hashtables.c:(.text+0x3580): undefined reference to `sysctl_local_port_allocation' When CONFIG_SYSCTL is disabled, sysctl_local_port_allocation is undefined. Fixes: 208a72041292 ("tcp/dccp: Add another way to allocate local ports in connect()") Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401180939.2N529UUe-lkp@intel.com/ Signed-off-by: Zhengchao Shao <shaozhengchao(a)huawei.com> --- v2: move sysctl_local_port_allocation to inet_hashtables.c --- net/ipv4/inet_hashtables.c | 2 ++ net/ipv4/sysctl_net_ipv4.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c index a24dcf39e9ae..6fb12a4d86af 100644 --- a/net/ipv4/inet_hashtables.c +++ b/net/ipv4/inet_hashtables.c @@ -28,6 +28,8 @@ #include <net/tcp.h> #include <net/sock_reuseport.h> +int sysctl_local_port_allocation = 0; + u32 inet_ehashfn(const struct net *net, const __be32 laddr, const __u16 lport, const __be32 faddr, const __be16 fport) diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index f212133b05e9..64b3bfcbfa25 100644 --- a/net/ipv4/sysctl_net_ipv4.c +++ b/net/ipv4/sysctl_net_ipv4.c @@ -39,7 +39,6 @@ static unsigned long ip_ping_group_range_min[] = { 0, 0 }; static unsigned long ip_ping_group_range_max[] = { GID_T_MAX, GID_T_MAX }; static u32 u32_max_div_HZ = UINT_MAX / HZ; static int one_day_secs = 24 * 3600; -int sysctl_local_port_allocation; static u32 fib_multipath_hash_fields_all_mask __maybe_unused = FIB_MULTIPATH_HASH_FIELD_ALL_MASK; static unsigned int tcp_child_ehash_entries_max = 16 * 1024 * 1024; -- 2.34.1

2 1

[PATCH OLK-6.6] tcp: fix compilation issue when CONFIG_SYSCTL is disabled
by Zhengchao Shao 23 Jan '24

23 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8Y7PX CVE: NA -------------------------------- The following error is reported when the kernel is compiled with CONFIG_SYSCTL disabled: aarch64-linux-ld: net/ipv4/inet_hashtables.o: in function `__inet_hash_connect': inet_hashtables.c:(.text+0x3564): undefined reference to `sysctl_local_port_allocation' aarch64-linux-ld: net/ipv4/inet_hashtables.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `sysctl_local_port_allocation' which may bind externally can not be used when making a shared object; recompile with -fPIC >> inet_hashtables.c:(.text+0x3564): dangerous relocation: unsupported relocation aarch64-linux-ld: inet_hashtables.c:(.text+0x3568): undefined reference to `sysctl_local_port_allocation' aarch64-linux-ld: inet_hashtables.c:(.text+0x3580): undefined reference to `sysctl_local_port_allocation' When CONFIG_SYSCTL is disabled, sysctl_local_port_allocation is undefined. Fixes: 208a72041292 ("tcp/dccp: Add another way to allocate local ports in connect()") Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401180939.2N529UUe-lkp@intel.com/ Signed-off-by: Zhengchao Shao <shaozhengchao(a)huawei.com> --- net/ipv4/inet_hashtables.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c index a24dcf39e9ae..14da0ce40bad 100644 --- a/net/ipv4/inet_hashtables.c +++ b/net/ipv4/inet_hashtables.c @@ -1011,7 +1011,10 @@ int __inet_hash_connect(struct inet_timewait_death_row *death_row, struct inet_bind_bucket *tb; bool tb_created = false; u32 remaining, offset; - int ret, i, low, high, span_size; + int ret, i, low, high; +#if IS_ENABLED(CONFIG_SYSCTL) + int span_size; +#endif int l3mdev; u32 index; @@ -1021,11 +1024,13 @@ int __inet_hash_connect(struct inet_timewait_death_row *death_row, local_bh_enable(); return ret; } +#if IS_ENABLED(CONFIG_SYSCTL) /* local_port_allocation 0 means even and odd port allocation strategy * will be applied, so span size is 2; otherwise sequential allocation * will be used and span size is 1. Default value is 0. */ span_size = sysctl_local_port_allocation ? 1 : 2; +#endif l3mdev = inet_sk_bound_l3mdev(sk); @@ -1048,7 +1053,11 @@ int __inet_hash_connect(struct inet_timewait_death_row *death_row, offset &= ~1U; other_parity_scan: port = low + offset; +#if IS_ENABLED(CONFIG_SYSCTL) for (i = 0; i < remaining; i += span_size, port += span_size) { +#else + for (i = 0; i < remaining; i += 2, port += 2) { +#endif if (unlikely(port >= high)) port -= remaining; if (inet_is_local_reserved_port(net, port)) @@ -1089,7 +1098,11 @@ int __inet_hash_connect(struct inet_timewait_death_row *death_row, } offset++; +#if IS_ENABLED(CONFIG_SYSCTL) if ((offset & 1) && remaining > 1 && span_size == 2) +#else + if ((offset & 1) && remaining > 1) +#endif goto other_parity_scan; return -EADDRNOTAVAIL; -- 2.34.1

2 1

[openeuler:OLK-5.10 26782/30000] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c:1030:27: warning: unused variable 'hdev'
by kernel test robot 23 Jan '24

23 Jan '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: ddef9a7fc99eaf6e3fdd9800687c2aa34d9a37e9 commit: 1cdab7738ac98414f73d5d56f7d643e4398b9bf2 [26782/30000] UNIC: Supports query, configuration, and management of IP entry config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240123/202401231038.k8yrs6Qq-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240123/202401231038.k8yrs6Qq-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401231038.k8yrs6Qq-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c: In function 'hclge_mbx_get_vf_flr_status_handler': >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c:1030:27: warning: unused variable 'hdev' [-Wunused-variable] 1030 | struct hclge_dev *hdev = param->vport->back; | ^~~~ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c: In function 'hclge_mbx_vf_uninit_handler': drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c:1046:27: warning: unused variable 'hdev' [-Wunused-variable] 1046 | struct hclge_dev *hdev = param->vport->back; | ^~~~ vim +/hdev +1030 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c 1026 1027 static int 1028 hclge_mbx_get_vf_flr_status_handler(struct hclge_mbx_ops_param *param) 1029 { > 1030 struct hclge_dev *hdev = param->vport->back; 1031 1032 hclge_rm_vport_all_mac_table(param->vport, false, 1033 HCLGE_MAC_ADDR_UC); 1034 hclge_rm_vport_all_mac_table(param->vport, false, 1035 HCLGE_MAC_ADDR_MC); 1036 hclge_rm_vport_all_vlan_table(param->vport, false); 1037 #ifdef CONFIG_HNS3_UBL 1038 if (hnae3_dev_ubl_supported(hdev->ae_dev)) 1039 hclge_unic_rm_vport_all_ip_table(param->vport, false); 1040 #endif 1041 return 0; 1042 } 1043 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 15329/21565] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:66:19: warning: array subscript 0 is outside array bounds of 'struct aperture[0]'
by kernel test robot 23 Jan '24

23 Jan '24

Hi shiyongbang, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: fb3a7131883be36037affebc26a6597087cbd012 commit: 97663f80b4826fcd792deef824b18510e139d674 [15329/21565] gpu: hibmc: Fix stuck when switch GUI to text. config: arm64-randconfig-001-20240112 (https://download.01.org/0day-ci/archive/20240123/202401230904.waKHfYdD-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240123/202401230904.waKHfYdD-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401230904.waKHfYdD-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:40:13: warning: no previous prototype for 'hibmc_drm_interrupt' [-Wmissing-prototypes] 40 | irqreturn_t hibmc_drm_interrupt(int irq, void *arg) | ^~~~~~~~~~~~~~~~~~~ In function 'hibmc_remove_framebuffers', inlined from 'hibmc_pci_probe' at drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:386:2: >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:66:19: warning: array subscript 0 is outside array bounds of 'struct aperture[0]' [-Warray-bounds=] 66 | ap->ranges[0].base = pci_resource_start(pdev, 0); | ~~~~~~~~~~^~~ In file included from include/drm/drm_crtc.h:31, from include/drm/drm_atomic_helper.h:31, from drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:22: include/linux/fb.h: In function 'hibmc_pci_probe': include/linux/fb.h:527:19: note: while referencing 'ranges' 527 | } ranges[0]; | ^~~~~~ In function 'hibmc_remove_framebuffers', inlined from 'hibmc_pci_probe' at drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:386:2: drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:67:19: warning: array subscript 0 is outside array bounds of 'struct aperture[0]' [-Warray-bounds=] 67 | ap->ranges[0].size = pci_resource_len(pdev, 0); | ~~~~~~~~~~^~~ include/linux/fb.h: In function 'hibmc_pci_probe': include/linux/fb.h:527:19: note: while referencing 'ranges' 527 | } ranges[0]; | ^~~~~~ vim +66 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c 57 58 static void hibmc_remove_framebuffers(struct pci_dev *pdev) 59 { 60 struct apertures_struct *ap; 61 62 ap = alloc_apertures(1); 63 if (!ap) 64 return; 65 > 66 ap->ranges[0].base = pci_resource_start(pdev, 0); 67 ap->ranges[0].size = pci_resource_len(pdev, 0); 68 69 drm_fb_helper_remove_conflicting_framebuffers(ap, "hibmcdrmfb", false); 70 71 kfree(ap); 72 } 73 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 12457/21565] drivers/char/svm.c:1762:36: warning: 'svm_acpi_match' defined but not used
by kernel test robot 23 Jan '24

23 Jan '24

Hi Lijun, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: fb3a7131883be36037affebc26a6597087cbd012 commit: d8e64215b6c932fd8d7c521d6cb3bcf6414d300c [12457/21565] svm: Delete ifdef CONFIG_ACPI in svm config: arm64-randconfig-001-20240112 (https://download.01.org/0day-ci/archive/20240123/202401230321.uVO9BE4k-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240123/202401230321.uVO9BE4k-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401230321.uVO9BE4k-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/char/svm.c:158:6: warning: no previous prototype for 'sysrq_sched_debug_show_export' [-Wmissing-prototypes] 158 | void sysrq_sched_debug_show_export(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/char/svm.c:1132:5: warning: no previous prototype for 'svm_get_pasid' [-Wmissing-prototypes] 1132 | int svm_get_pasid(pid_t vpid, int dev_id __maybe_unused) | ^~~~~~~~~~~~~ >> drivers/char/svm.c:1762:36: warning: 'svm_acpi_match' defined but not used [-Wunused-const-variable=] 1762 | static const struct acpi_device_id svm_acpi_match[] = { | ^~~~~~~~~~~~~~ In file included from arch/arm64/include/asm/atomic.h:34, from include/linux/atomic.h:7, from include/asm-generic/bitops/atomic.h:5, from arch/arm64/include/asm/bitops.h:37, from include/linux/bitops.h:19, from include/linux/kernel.h:11, from include/asm-generic/bug.h:18, from arch/arm64/include/asm/bug.h:37, from arch/arm64/include/asm/memory.h:27, from arch/arm64/include/asm/esr.h:21, from drivers/char/svm.c:10: In function '__cmpxchg_case_mb_4', inlined from '__cmpxchg_mb' at arch/arm64/include/asm/cmpxchg.h:143:1, inlined from 'svm_proc_load_flag' at drivers/char/svm.c:1465:12: arch/arm64/include/asm/atomic_lse.h:458:9: warning: array subscript 'long unsigned int[0]' is partly outside array bounds of 'atomic_t[1]' [-Warray-bounds=] 458 | asm volatile(ARM64_LSE_ATOMIC_INSN( \ | ^~~ arch/arm64/include/asm/atomic_lse.h:487:1: note: in expansion of macro '__CMPXCHG_CASE' 487 | __CMPXCHG_CASE(w, , mb_4, al, "memory") | ^~~~~~~~~~~~~~ drivers/char/svm.c: In function 'svm_proc_load_flag': drivers/char/svm.c:1456:25: note: object 'l2buf_load_flag' of size 4 1456 | static atomic_t l2buf_load_flag = ATOMIC_INIT(0); | ^~~~~~~~~~~~~~~ In function '__cmpxchg_case_mb_4', inlined from '__cmpxchg_mb' at arch/arm64/include/asm/cmpxchg.h:143:1, inlined from 'svm_proc_load_flag' at drivers/char/svm.c:1465:12: arch/arm64/include/asm/atomic_lse.h:458:9: warning: array subscript 'long unsigned int[0]' is partly outside array bounds of 'atomic_t[1]' [-Warray-bounds=] 458 | asm volatile(ARM64_LSE_ATOMIC_INSN( \ | ^~~ arch/arm64/include/asm/atomic_lse.h:487:1: note: in expansion of macro '__CMPXCHG_CASE' 487 | __CMPXCHG_CASE(w, , mb_4, al, "memory") | ^~~~~~~~~~~~~~ drivers/char/svm.c: In function 'svm_proc_load_flag': drivers/char/svm.c:1456:25: note: object 'l2buf_load_flag' of size 4 1456 | static atomic_t l2buf_load_flag = ATOMIC_INIT(0); | ^~~~~~~~~~~~~~~ vim +/svm_acpi_match +1762 drivers/char/svm.c 8f29578be61750 Jiankang Chen 2019-10-28 1761 8f29578be61750 Jiankang Chen 2019-10-28 @1762 static const struct acpi_device_id svm_acpi_match[] = { 8f29578be61750 Jiankang Chen 2019-10-28 1763 { "HSVM1980", 0}, 8f29578be61750 Jiankang Chen 2019-10-28 1764 { } 8f29578be61750 Jiankang Chen 2019-10-28 1765 }; 8f29578be61750 Jiankang Chen 2019-10-28 1766 MODULE_DEVICE_TABLE(acpi, svm_acpi_match); d8e64215b6c932 Lijun Fang 2020-01-16 1767 :::::: The code at line 1762 was first introduced by commit :::::: 8f29578be61750d83b8effb090c25e07432dcb75 svm: add svm drv framework for hi1910 and hi1980 :::::: TO: Jiankang Chen <chenjiankang1(a)huawei.com> :::::: CC: Xie XiuQi <xiexiuqi(a)huawei.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 15455/21561] drivers/staging/gmjstcm/tcm_tis_spi.c:817:36: warning: 'tcm_tis_spi_acpi_match' defined but not used
by kernel test robot 22 Jan '24

22 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: d7de179b5122c922d0dcae88231947a26f47b632 commit: 5ebbfc8c29eb5eb6dfdab853bdb2a622e0533d7e [15455/21561] staging: TCM: add GMJS(Nationz Tech) TCM driver. config: arm64-randconfig-002-20240120 (https://download.01.org/0day-ci/archive/20240122/202401222135.PnRKwawm-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240122/202401222135.PnRKwawm-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401222135.PnRKwawm-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/staging/gmjstcm/tcm_tis_spi.c:109:5: warning: no previous prototype for 'tcm_tis_spi_transfer' [-Wmissing-prototypes] 109 | int tcm_tis_spi_transfer(struct device *dev, u32 addr, u16 len, | ^~~~~~~~~~~~~~~~~~~~ drivers/staging/gmjstcm/tcm_tis_spi.c: In function 'recv_data': drivers/staging/gmjstcm/tcm_tis_spi.c:423:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 423 | int ret; | ^~~ drivers/staging/gmjstcm/tcm_tis_spi.c: At top level: >> drivers/staging/gmjstcm/tcm_tis_spi.c:817:36: warning: 'tcm_tis_spi_acpi_match' defined but not used [-Wunused-const-variable=] 817 | static const struct acpi_device_id tcm_tis_spi_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~~ drivers/staging/gmjstcm/tcm_tis_spi.c: In function 'cleanup_tis': >> drivers/staging/gmjstcm/tcm_tis_spi.c:249:17: warning: 'inten' may be used uninitialized [-Wmaybe-uninitialized] 249 | tcm_tis_writel(chip->dev, TCM_INT_ENABLE(chip->vendor.locality), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 250 | ~TCM_GLOBAL_INT_ENABLE & inten); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/gmjstcm/tcm_tis_spi.c:237:13: note: 'inten' was declared here 237 | u32 inten; | ^~~~~ drivers/staging/gmjstcm/tcm_tis_spi.c: In function 'tcm_tis_init': >> drivers/staging/gmjstcm/tcm_tis_spi.c:264:21: warning: 'vendor' may be used uninitialized [-Wmaybe-uninitialized] 264 | if ((vendor & 0xffff) != 0x19f5 && (vendor & 0xffff) != 0x1B4E) | ~~~~~~~~^~~~~~~~~ drivers/staging/gmjstcm/tcm_tis_spi.c:260:13: note: 'vendor' was declared here 260 | u32 vendor, intfcaps; | ^~~~~~ vim +/tcm_tis_spi_acpi_match +817 drivers/staging/gmjstcm/tcm_tis_spi.c 816 > 817 static const struct acpi_device_id tcm_tis_spi_acpi_match[] = { 818 {"TCMS0001", 0}, 819 {"SMO0768", 0}, 820 {"ZIC0601", 0}, 821 {} 822 }; 823 MODULE_DEVICE_TABLE(acpi, tcm_tis_spi_acpi_match); 824 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 26784/30000] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:721:43: warning: 'hclge_dbg_tqp_reg' defined but not used
by kernel test robot 22 Jan '24

22 Jan '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 5b9222cde1b41a53fc814d98cd15aea84832aca3 commit: 193e5e1d2edcd566ccf9d920354ac22c3241434e [26784/30000] UNIC: add nfe ras for PFA and TXPM module config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240122/202401222119.vrDbjHb2-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240122/202401222119.vrDbjHb2-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401222119.vrDbjHb2-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_udma.c:19: >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:721:43: warning: 'hclge_dbg_tqp_reg' defined but not used [-Wunused-const-variable=] 721 | static const struct hclge_dbg_dfx_message hclge_dbg_tqp_reg[] = { | ^~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:649:43: warning: 'hclge_dbg_rcb_reg' defined but not used [-Wunused-const-variable=] 649 | static const struct hclge_dbg_dfx_message hclge_dbg_rcb_reg[] = { | ^~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:493:43: warning: 'hclge_dbg_ppp_reg' defined but not used [-Wunused-const-variable=] 493 | static const struct hclge_dbg_dfx_message hclge_dbg_ppp_reg[] = { | ^~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:463:43: warning: 'hclge_dbg_rtc_reg' defined but not used [-Wunused-const-variable=] 463 | static const struct hclge_dbg_dfx_message hclge_dbg_rtc_reg[] = { | ^~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:391:43: warning: 'hclge_dbg_ncsi_reg' defined but not used [-Wunused-const-variable=] 391 | static const struct hclge_dbg_dfx_message hclge_dbg_ncsi_reg[] = { | ^~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:375:43: warning: 'hclge_dbg_rpu_reg_1' defined but not used [-Wunused-const-variable=] 375 | static const struct hclge_dbg_dfx_message hclge_dbg_rpu_reg_1[] = { | ^~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:366:43: warning: 'hclge_dbg_rpu_reg_0' defined but not used [-Wunused-const-variable=] 366 | static const struct hclge_dbg_dfx_message hclge_dbg_rpu_reg_0[] = { | ^~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:301:43: warning: 'hclge_dbg_igu_egu_reg' defined but not used [-Wunused-const-variable=] 301 | static const struct hclge_dbg_dfx_message hclge_dbg_igu_egu_reg[] = { | ^~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:292:43: warning: 'hclge_dbg_ssu_reg_2' defined but not used [-Wunused-const-variable=] 292 | static const struct hclge_dbg_dfx_message hclge_dbg_ssu_reg_2[] = { | ^~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:185:43: warning: 'hclge_dbg_ssu_reg_1' defined but not used [-Wunused-const-variable=] 185 | static const struct hclge_dbg_dfx_message hclge_dbg_ssu_reg_1[] = { | ^~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:113:43: warning: 'hclge_dbg_ssu_reg_0' defined but not used [-Wunused-const-variable=] 113 | static const struct hclge_dbg_dfx_message hclge_dbg_ssu_reg_0[] = { | ^~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:97:43: warning: 'hclge_dbg_bios_common_reg' defined but not used [-Wunused-const-variable=] 97 | static const struct hclge_dbg_dfx_message hclge_dbg_bios_common_reg[] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/hclge_dbg_tqp_reg +721 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h 27cf979a15841e liuzhongzhu 2018-12-15 648 e4b9146849f246 Rikard Falkeborn 2020-09-22 @649 static const struct hclge_dbg_dfx_message hclge_dbg_rcb_reg[] = { 27cf979a15841e liuzhongzhu 2018-12-15 650 {false, "Reserved"}, 27cf979a15841e liuzhongzhu 2018-12-15 651 {true, "FSM_DFX_ST0"}, 27cf979a15841e liuzhongzhu 2018-12-15 652 {true, "FSM_DFX_ST1"}, 27cf979a15841e liuzhongzhu 2018-12-15 653 {true, "FSM_DFX_ST2"}, 27cf979a15841e liuzhongzhu 2018-12-15 654 {true, "FIFO_DFX_ST0"}, 27cf979a15841e liuzhongzhu 2018-12-15 655 {true, "FIFO_DFX_ST1"}, 27cf979a15841e liuzhongzhu 2018-12-15 656 27cf979a15841e liuzhongzhu 2018-12-15 657 {true, "FIFO_DFX_ST2"}, 27cf979a15841e liuzhongzhu 2018-12-15 658 {true, "FIFO_DFX_ST3"}, 27cf979a15841e liuzhongzhu 2018-12-15 659 {true, "FIFO_DFX_ST4"}, 27cf979a15841e liuzhongzhu 2018-12-15 660 {true, "FIFO_DFX_ST5"}, 27cf979a15841e liuzhongzhu 2018-12-15 661 {true, "FIFO_DFX_ST6"}, 27cf979a15841e liuzhongzhu 2018-12-15 662 {true, "FIFO_DFX_ST7"}, 27cf979a15841e liuzhongzhu 2018-12-15 663 27cf979a15841e liuzhongzhu 2018-12-15 664 {true, "FIFO_DFX_ST8"}, 27cf979a15841e liuzhongzhu 2018-12-15 665 {true, "FIFO_DFX_ST9"}, 27cf979a15841e liuzhongzhu 2018-12-15 666 {true, "FIFO_DFX_ST10"}, 27cf979a15841e liuzhongzhu 2018-12-15 667 {true, "FIFO_DFX_ST11"}, 27cf979a15841e liuzhongzhu 2018-12-15 668 {true, "Q_CREDIT_VLD_0"}, 27cf979a15841e liuzhongzhu 2018-12-15 669 {true, "Q_CREDIT_VLD_1"}, 27cf979a15841e liuzhongzhu 2018-12-15 670 27cf979a15841e liuzhongzhu 2018-12-15 671 {true, "Q_CREDIT_VLD_2"}, 27cf979a15841e liuzhongzhu 2018-12-15 672 {true, "Q_CREDIT_VLD_3"}, 27cf979a15841e liuzhongzhu 2018-12-15 673 {true, "Q_CREDIT_VLD_4"}, 27cf979a15841e liuzhongzhu 2018-12-15 674 {true, "Q_CREDIT_VLD_5"}, 27cf979a15841e liuzhongzhu 2018-12-15 675 {true, "Q_CREDIT_VLD_6"}, 27cf979a15841e liuzhongzhu 2018-12-15 676 {true, "Q_CREDIT_VLD_7"}, 27cf979a15841e liuzhongzhu 2018-12-15 677 27cf979a15841e liuzhongzhu 2018-12-15 678 {true, "Q_CREDIT_VLD_8"}, 27cf979a15841e liuzhongzhu 2018-12-15 679 {true, "Q_CREDIT_VLD_9"}, 27cf979a15841e liuzhongzhu 2018-12-15 680 {true, "Q_CREDIT_VLD_10"}, 27cf979a15841e liuzhongzhu 2018-12-15 681 {true, "Q_CREDIT_VLD_11"}, 27cf979a15841e liuzhongzhu 2018-12-15 682 {true, "Q_CREDIT_VLD_12"}, 27cf979a15841e liuzhongzhu 2018-12-15 683 {true, "Q_CREDIT_VLD_13"}, 27cf979a15841e liuzhongzhu 2018-12-15 684 27cf979a15841e liuzhongzhu 2018-12-15 685 {true, "Q_CREDIT_VLD_14"}, 27cf979a15841e liuzhongzhu 2018-12-15 686 {true, "Q_CREDIT_VLD_15"}, 27cf979a15841e liuzhongzhu 2018-12-15 687 {true, "Q_CREDIT_VLD_16"}, 27cf979a15841e liuzhongzhu 2018-12-15 688 {true, "Q_CREDIT_VLD_17"}, 27cf979a15841e liuzhongzhu 2018-12-15 689 {true, "Q_CREDIT_VLD_18"}, 27cf979a15841e liuzhongzhu 2018-12-15 690 {true, "Q_CREDIT_VLD_19"}, 27cf979a15841e liuzhongzhu 2018-12-15 691 27cf979a15841e liuzhongzhu 2018-12-15 692 {true, "Q_CREDIT_VLD_20"}, 27cf979a15841e liuzhongzhu 2018-12-15 693 {true, "Q_CREDIT_VLD_21"}, 27cf979a15841e liuzhongzhu 2018-12-15 694 {true, "Q_CREDIT_VLD_22"}, 27cf979a15841e liuzhongzhu 2018-12-15 695 {true, "Q_CREDIT_VLD_23"}, 27cf979a15841e liuzhongzhu 2018-12-15 696 {true, "Q_CREDIT_VLD_24"}, 27cf979a15841e liuzhongzhu 2018-12-15 697 {true, "Q_CREDIT_VLD_25"}, 27cf979a15841e liuzhongzhu 2018-12-15 698 27cf979a15841e liuzhongzhu 2018-12-15 699 {true, "Q_CREDIT_VLD_26"}, 27cf979a15841e liuzhongzhu 2018-12-15 700 {true, "Q_CREDIT_VLD_27"}, 27cf979a15841e liuzhongzhu 2018-12-15 701 {true, "Q_CREDIT_VLD_28"}, 27cf979a15841e liuzhongzhu 2018-12-15 702 {true, "Q_CREDIT_VLD_29"}, 27cf979a15841e liuzhongzhu 2018-12-15 703 {true, "Q_CREDIT_VLD_30"}, 27cf979a15841e liuzhongzhu 2018-12-15 704 {true, "Q_CREDIT_VLD_31"}, 27cf979a15841e liuzhongzhu 2018-12-15 705 27cf979a15841e liuzhongzhu 2018-12-15 706 {true, "GRO_BD_SERR_CNT"}, 27cf979a15841e liuzhongzhu 2018-12-15 707 {true, "GRO_CONTEXT_SERR_CNT"}, 27cf979a15841e liuzhongzhu 2018-12-15 708 {true, "RX_STASH_CFG_SERR_CNT"}, 27cf979a15841e liuzhongzhu 2018-12-15 709 {true, "AXI_RD_FBD_SERR_CNT"}, 27cf979a15841e liuzhongzhu 2018-12-15 710 {true, "GRO_BD_MERR_CNT"}, 27cf979a15841e liuzhongzhu 2018-12-15 711 {true, "GRO_CONTEXT_MERR_CNT"}, 27cf979a15841e liuzhongzhu 2018-12-15 712 27cf979a15841e liuzhongzhu 2018-12-15 713 {true, "RX_STASH_CFG_MERR_CNT"}, 27cf979a15841e liuzhongzhu 2018-12-15 714 {true, "AXI_RD_FBD_MERR_CNT"}, 27cf979a15841e liuzhongzhu 2018-12-15 715 {false, "Reserved"}, 27cf979a15841e liuzhongzhu 2018-12-15 716 {false, "Reserved"}, 27cf979a15841e liuzhongzhu 2018-12-15 717 {false, "Reserved"}, 27cf979a15841e liuzhongzhu 2018-12-15 718 {false, "Reserved"}, 27cf979a15841e liuzhongzhu 2018-12-15 719 }; 27cf979a15841e liuzhongzhu 2018-12-15 720 e4b9146849f246 Rikard Falkeborn 2020-09-22 @721 static const struct hclge_dbg_dfx_message hclge_dbg_tqp_reg[] = { 27cf979a15841e liuzhongzhu 2018-12-15 722 {true, "q_num"}, 27cf979a15841e liuzhongzhu 2018-12-15 723 {true, "RCB_CFG_RX_RING_TAIL"}, 27cf979a15841e liuzhongzhu 2018-12-15 724 {true, "RCB_CFG_RX_RING_HEAD"}, 27cf979a15841e liuzhongzhu 2018-12-15 725 {true, "RCB_CFG_RX_RING_FBDNUM"}, 27cf979a15841e liuzhongzhu 2018-12-15 726 {true, "RCB_CFG_RX_RING_OFFSET"}, 27cf979a15841e liuzhongzhu 2018-12-15 727 {true, "RCB_CFG_RX_RING_FBDOFFSET"}, 27cf979a15841e liuzhongzhu 2018-12-15 728 27cf979a15841e liuzhongzhu 2018-12-15 729 {true, "RCB_CFG_RX_RING_PKTNUM_RECORD"}, 27cf979a15841e liuzhongzhu 2018-12-15 730 {true, "RCB_CFG_TX_RING_TAIL"}, 27cf979a15841e liuzhongzhu 2018-12-15 731 {true, "RCB_CFG_TX_RING_HEAD"}, 27cf979a15841e liuzhongzhu 2018-12-15 732 {true, "RCB_CFG_TX_RING_FBDNUM"}, 27cf979a15841e liuzhongzhu 2018-12-15 733 {true, "RCB_CFG_TX_RING_OFFSET"}, 27cf979a15841e liuzhongzhu 2018-12-15 734 {true, "RCB_CFG_TX_RING_EBDNUM"}, 27cf979a15841e liuzhongzhu 2018-12-15 735 }; 27cf979a15841e liuzhongzhu 2018-12-15 736 :::::: The code at line 721 was first introduced by commit :::::: e4b9146849f246e77da4787657a3a95c1b6d2833 net: hns3: Constify static structs :::::: TO: Rikard Falkeborn <rikard.falkeborn(a)gmail.com> :::::: CC: David S. Miller <davem(a)davemloft.net> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH openEuler-1.0-LTS] sctp: fix potential deadlock on &net->sctp.addr_wq_lock
by Dong Chenchen 22 Jan '24

22 Jan '24

From: Chengfeng Ye <dg573847474(a)gmail.com> stable inclusion from stable-v4.19.290 commit 0ad0e8b0cb0e28626ab6dffe3da883941b9cbc4b category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8WZLA CVE: CVE-2024-0639 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 6feb37b3b06e9049e20dcf7e23998f92c9c5be9a ] As &net->sctp.addr_wq_lock is also acquired by the timer sctp_addr_wq_timeout_handler() in protocal.c, the same lock acquisition at sctp_auto_asconf_init() seems should disable irq since it is called from sctp_accept() under process context. Possible deadlock scenario: sctp_accept() -> sctp_sock_migrate() -> sctp_auto_asconf_init() -> spin_lock(&net->sctp.addr_wq_lock) <timer interrupt> -> sctp_addr_wq_timeout_handler() -> spin_lock_bh(&net->sctp.addr_wq_lock); (deadlock here) This flaw was found using an experimental static analysis tool we are developing for irq-related deadlock. The tentative patch fix the potential deadlock by spin_lock_bh(). Signed-off-by: Chengfeng Ye <dg573847474(a)gmail.com> Fixes: 34e5b0118685 ("sctp: delay auto_asconf init until binding the first addr") Acked-by: Xin Long <lucien.xin(a)gmail.com> Link: https://lore.kernel.org/r/20230627120340.19432-1-dg573847474@gmail.com Signed-off-by: Paolo Abeni <pabeni(a)redhat.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Dong Chenchen <dongchenchen2(a)huawei.com> --- net/sctp/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 261ff3dd5a94..2a11b464182e 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -380,9 +380,9 @@ static void sctp_auto_asconf_init(struct sctp_sock *sp) struct net *net = sock_net(&sp->inet.sk); if (net->sctp.default_auto_asconf) { - spin_lock(&net->sctp.addr_wq_lock); + spin_lock_bh(&net->sctp.addr_wq_lock); list_add_tail(&sp->auto_asconf_list, &net->sctp.auto_asconf_splist); - spin_unlock(&net->sctp.addr_wq_lock); + spin_unlock_bh(&net->sctp.addr_wq_lock); sp->do_auto_asconf = 1; } } -- 2.25.1

2 1