Re: [PATCH openEuler-21.09 01/24] irqchip/gic-phytium-2500: Add support for GIC of Phytium S2500

On 2021/7/27 15:10, Zheng Zengkai wrote:

diff --git a/include/linux/irqchip/arm-gic-phytium-2500.h b/include/linux/irqchip/arm-gic-phytium-2500.h new file mode 100644 index 000000000000..96c5ca83f44d --- /dev/null +++ b/include/linux/irqchip/arm-gic-phytium-2500.h

I can't see any point of adding such a new header given that ...

+int phytium_its_cpu_init(void); +int phytium_its_init(struct fwnode_handle *handle, struct rdists *rdists,

•     struct irq_domain *domain);
  

... this is the only difference compared with arm-gic-v3.h _and_ if I read it correctly, phytium_its_{cpu_,}init() has exactly the same implementation with the upstream its_{cpu_,}init().

I hadn't looked into the details (as the huge diffstat already killed me ;-) ) so please feel free to ignore my random comments.