[openeuler:OLK-6.6 1799/1799] drivers/net/ethernet/huawei/hibifur/bifur_main.c:175:5: warning: no previous prototype for function 'bifur_enable_disable_vf_all' - Kernel

9 Jan 2025


      tree:   https://gitee.com/openeuler/kernel.git OLK-6.6
head:   89cbe2e2a9d5402e079b95f36d33d4669614e0dc
commit: a544f0ba62857476ae73fd4305dbe293b7ee7532 [1799/1799] Add Huawei Intelligent Network Card Driver:hibifur
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250109/202501091220.UhgFHZVc-lkp@i...)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250109/202501091220.UhgFHZVc-lkp@i...)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot lkp@intel.com
| Closes: https://lore.kernel.org/oe-kbuild-all/202501091220.UhgFHZVc-lkp@intel.com/
All warnings (new ones prefixed by >>):
...
...
drivers/net/ethernet/huawei/hibifur/bifur_main.c:175:5: warning: no previous prototype for function 'bifur_enable_disable_vf_all' [-Wmissing-prototypes]
175 | int bifur_enable_disable_vf_all(bool enable)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_main.c:175:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     175 | int bifur_enable_disable_vf_all(bool enable)
         | ^
         | static 
   1 warning generated.
--
...
...
drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:88:6: warning: no previous prototype for function 'bifur_vf_info_hold' [-Wmissing-prototypes]
88 | void bifur_vf_info_hold(struct bifur_vf_info *dev)
         |      ^
   drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:88:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      88 | void bifur_vf_info_hold(struct bifur_vf_info *dev)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:93:6: warning: no previous prototype for function 'bifur_vf_info_put' [-Wmissing-prototypes]
93 | void bifur_vf_info_put(struct bifur_vf_info *dev)
         |      ^
   drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:93:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      93 | void bifur_vf_info_put(struct bifur_vf_info *dev)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:99:6: warning: no previous prototype for function 'bifur_dev_file_add' [-Wmissing-prototypes]
99 | void bifur_dev_file_add(struct bifur_dev_file_t *dev_file)
         |      ^
   drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:99:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      99 | void bifur_dev_file_add(struct bifur_dev_file_t *dev_file)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:106:6: warning: no previous prototype for function 'bifur_dev_file_del' [-Wmissing-prototypes]
106 | void bifur_dev_file_del(struct bifur_dev_file_t *dev_file)
         |      ^
   drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:106:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     106 | void bifur_dev_file_del(struct bifur_dev_file_t *dev_file)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:113:5: warning: no previous prototype for function 'bifur_proc_open' [-Wmissing-prototypes]
113 | int bifur_proc_open(struct inode *inode, struct file *filp)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:113:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     113 | int bifur_proc_open(struct inode *inode, struct file *filp)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:133:5: warning: no previous prototype for function 'bifur_proc_close' [-Wmissing-prototypes]
133 | int bifur_proc_close(struct inode *inode, struct file *filp)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:133:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     133 | int bifur_proc_close(struct inode *inode, struct file *filp)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:171:5: warning: no previous prototype for function 'bifur_dev_proc_build' [-Wmissing-prototypes]
171 | int bifur_dev_proc_build(struct bifur_vf_info *dev)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:171:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     171 | int bifur_dev_proc_build(struct bifur_vf_info *dev)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:204:5: warning: no previous prototype for function 'bifur_dev_proc_destroy' [-Wmissing-prototypes]
204 | int bifur_dev_proc_destroy(struct bifur_vf_info *dev)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_vf_mgr.c:204:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     204 | int bifur_dev_proc_destroy(struct bifur_vf_info *dev)
         | ^
         | static 
   8 warnings generated.
--
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:43:6: warning: no previous prototype for function 'bifur_global_file_del' [-Wmissing-prototypes]
43 | void bifur_global_file_del(struct bifur_proc_file_t *proc_file)
         |      ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:43:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      43 | void bifur_global_file_del(struct bifur_proc_file_t *proc_file)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:50:5: warning: no previous prototype for function 'bifur_global_dev_close' [-Wmissing-prototypes]
50 | int bifur_global_dev_close(struct inode *inode, struct file *filp)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:50:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      50 | int bifur_global_dev_close(struct inode *inode, struct file *filp)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:62:5: warning: no previous prototype for function 'bifur_global_file_add' [-Wmissing-prototypes]
62 | int bifur_global_file_add(struct bifur_proc_file_t *add_proc_file)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:62:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      62 | int bifur_global_file_add(struct bifur_proc_file_t *add_proc_file)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:83:27: warning: no previous prototype for function 'bifur_alloc_proc_file' [-Wmissing-prototypes]
83 | struct bifur_proc_file_t *bifur_alloc_proc_file(void)
         |                           ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:83:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      83 | struct bifur_proc_file_t *bifur_alloc_proc_file(void)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:95:5: warning: no previous prototype for function 'bifur_global_dev_open' [-Wmissing-prototypes]
95 | int bifur_global_dev_open(struct inode *inode, struct file *filp)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:95:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      95 | int bifur_global_dev_open(struct inode *inode, struct file *filp)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:370:5: warning: no previous prototype for function 'bifur_cmd_exec' [-Wmissing-prototypes]
370 | int bifur_cmd_exec(struct file *file, struct bifur_msg *msg)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:370:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     370 | int bifur_cmd_exec(struct file *file, struct bifur_msg *msg)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:383:5: warning: no previous prototype for function 'bifur_msg_copy_from_usr' [-Wmissing-prototypes]
383 | int bifur_msg_copy_from_usr(const char __user *ubuf, size_t size, struct bifur_msg *usr,
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:383:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     383 | int bifur_msg_copy_from_usr(const char __user *ubuf, size_t size, struct bifur_msg *usr,
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:431:6: warning: no previous prototype for function 'bifur_free_knl_msg_buf' [-Wmissing-prototypes]
431 | void bifur_free_knl_msg_buf(struct bifur_msg *msg)
         |      ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:431:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     431 | void bifur_free_knl_msg_buf(struct bifur_msg *msg)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:437:5: warning: no previous prototype for function 'bifur_msg_copy_to_usr' [-Wmissing-prototypes]
437 | int bifur_msg_copy_to_usr(struct bifur_msg *usr, struct bifur_msg *knl)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:437:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     437 | int bifur_msg_copy_to_usr(struct bifur_msg *usr, struct bifur_msg *knl)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:457:9: warning: no previous prototype for function 'bifur_file_write' [-Wmissing-prototypes]
457 | ssize_t bifur_file_write(struct file *file, const char __user *ubuf, size_t size, loff_t *pos)
         |         ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:457:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     457 | ssize_t bifur_file_write(struct file *file, const char __user *ubuf, size_t size, loff_t *pos)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:488:9: warning: no previous prototype for function 'bifur_proc_write' [-Wmissing-prototypes]
488 | ssize_t bifur_proc_write(struct file *file, const char __user *ubuf, size_t size, loff_t *pos)
         |         ^
   drivers/net/ethernet/huawei/hibifur/bifur_pfile.c:488:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     488 | ssize_t bifur_proc_write(struct file *file, const char __user *ubuf, size_t size, loff_t *pos)
         | ^
         | static 
   11 warnings generated.
--
...
...
drivers/net/ethernet/huawei/hibifur/bifur_event.c:257:6: warning: no previous prototype for function 'bifur_notify_vf_link_status' [-Wmissing-prototypes]
257 | void bifur_notify_vf_link_status(struct hinic3_lld_dev *lld_dev, u8 port_id, u16 vf_id,
         |      ^
   drivers/net/ethernet/huawei/hibifur/bifur_event.c:257:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     257 | void bifur_notify_vf_link_status(struct hinic3_lld_dev *lld_dev, u8 port_id, u16 vf_id,
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_event.c:282:6: warning: no previous prototype for function 'bifur_notify_all_vfs_link_changed' [-Wmissing-prototypes]
282 | void bifur_notify_all_vfs_link_changed(struct hinic3_lld_dev *lld_dev, u32 dbdf, u8 link_status)
         |      ^
   drivers/net/ethernet/huawei/hibifur/bifur_event.c:282:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     282 | void bifur_notify_all_vfs_link_changed(struct hinic3_lld_dev *lld_dev, u32 dbdf, u8 link_status)
         | ^
         | static
...
...
drivers/net/ethernet/huawei/hibifur/bifur_event.c:341:5: warning: no previous prototype for function 'bifur_net_event_callback' [-Wmissing-prototypes]
341 | int bifur_net_event_callback(struct notifier_block *nb, unsigned long event, void *ptr)
         |     ^
   drivers/net/ethernet/huawei/hibifur/bifur_event.c:341:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     341 | int bifur_net_event_callback(struct notifier_block *nb, unsigned long event, void *ptr)
         | ^
         | static 
   3 warnings generated.
vim +/bifur_enable_disable_vf_all +175 drivers/net/ethernet/huawei/hibifur/bifur_main.c
174
...
175	int bifur_enable_disable_vf_all(bool enable)
176	{
   177		int err = 0;
   178		int num_vfs = enable ? BIFUR_VF_NUM : 0;
   179		struct bifur_lld_dev *bifur_dev = NULL;
   180		struct bifur_lld_dev *tmp_dev = NULL;
   181		struct bifur_adapter *adp = bifur_get_adp();
   182		struct list_head *head = &adp->lld_dev_head;
   183	
   184		list_for_each_entry_safe(bifur_dev, tmp_dev, head, list) {
   185			if (bifur_dev->pf_type != BIFUR_RESOURCE_PF)
   186				continue;
   187	
   188			bifur_dev_hold(bifur_dev);
   189			err = bifur_enable_disable_vfs(bifur_dev, num_vfs);
   190			bifur_dev_put(bifur_dev);
   191			if (err)
   192				return err;
   193		}
   194	
   195		return 0;
   196	}
   197
-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki