- Kernel - mailweb.openeuler.org

[PATCH openEuler-22.03-LTS-SP1] dmaengine: idxd: Let probe fail when workqueue cannot be enabled
by Qi Xi 13 Dec '24

13 Dec '24

From: Reinette Chatre <reinette.chatre(a)intel.com> mainline inclusion from mainline-v6.2-rc5 commit b51b75f0604f17c0f6f3b6f68f1a521a5cc6b04f category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IALL6O CVE: CVE-2022-48868 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- The workqueue is enabled when the appropriate driver is loaded and disabled when the driver is removed. When the driver is removed it assumes that the workqueue was enabled successfully and proceeds to free allocations made during workqueue enabling. Failure during workqueue enabling does not prevent the driver from being loaded. This is because the error path within drv_enable_wq() returns success unless a second failure is encountered during the error path. By returning success it is possible to load the driver even if the workqueue cannot be enabled and allocations that do not exist are attempted to be freed during driver remove. Some examples of problematic flows: (a) idxd_dmaengine_drv_probe() -> drv_enable_wq() -> idxd_wq_request_irq(): In above flow, if idxd_wq_request_irq() fails then idxd_wq_unmap_portal() is called on error exit path, but drv_enable_wq() returns 0 because idxd_wq_disable() succeeds. The driver is thus loaded successfully. idxd_dmaengine_drv_remove()->drv_disable_wq()->idxd_wq_unmap_portal() Above flow on driver unload triggers the WARN in devm_iounmap() because the device resource has already been removed during error path of drv_enable_wq(). (b) idxd_dmaengine_drv_probe() -> drv_enable_wq() -> idxd_wq_request_irq(): In above flow, if idxd_wq_request_irq() fails then idxd_wq_init_percpu_ref() is never called to initialize the percpu counter, yet the driver loads successfully because drv_enable_wq() returns 0. idxd_dmaengine_drv_remove()->__idxd_wq_quiesce()->percpu_ref_kill(): Above flow on driver unload triggers a BUG when attempting to drop the initial ref of the uninitialized percpu ref: BUG: kernel NULL pointer dereference, address: 0000000000000010 Fix the drv_enable_wq() error path by returning the original error that indicates failure of workqueue enabling. This ensures that the probe fails when an error is encountered and the driver remove paths are only attempted when the workqueue was enabled successfully. Fixes: 1f2bb40337f0 ("dmaengine: idxd: move wq_enable() to device.c") Signed-off-by: Reinette Chatre <reinette.chatre(a)intel.com> Reviewed-by: Dave Jiang <dave.jiang(a)intel.com> Reviewed-by: Fenghua Yu <fenghua.yu(a)intel.com> Cc: stable(a)vger.kernel.org Link: https://lore.kernel.org/r/e8d8116e5efa0fd14fadc5adae6ffd319f0e5ff1.16704524… Signed-off-by: Vinod Koul <vkoul(a)kernel.org> Signed-off-by: Qi Xi <xiqi2(a)huawei.com> --- drivers/dma/idxd/device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c index 06f5d3783d77..c5523ced2e3a 100644 --- a/drivers/dma/idxd/device.c +++ b/drivers/dma/idxd/device.c @@ -1390,8 +1390,7 @@ int drv_enable_wq(struct idxd_wq *wq) err_irq: idxd_wq_unmap_portal(wq); err_map_portal: - rc = idxd_wq_disable(wq, false); - if (rc < 0) + if (idxd_wq_disable(wq, false)) dev_dbg(dev, "wq %s disable failed\n", dev_name(wq_confdev(wq))); err: return rc; -- 2.33.0

2 1

[PATCH OLK-5.10] dmaengine: idxd: Let probe fail when workqueue cannot be enabled
by Qi Xi 13 Dec '24

13 Dec '24

From: Reinette Chatre <reinette.chatre(a)intel.com> mainline inclusion from mainline-v6.2-rc5 commit b51b75f0604f17c0f6f3b6f68f1a521a5cc6b04f category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IALL6O CVE: CVE-2022-48868 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- The workqueue is enabled when the appropriate driver is loaded and disabled when the driver is removed. When the driver is removed it assumes that the workqueue was enabled successfully and proceeds to free allocations made during workqueue enabling. Failure during workqueue enabling does not prevent the driver from being loaded. This is because the error path within drv_enable_wq() returns success unless a second failure is encountered during the error path. By returning success it is possible to load the driver even if the workqueue cannot be enabled and allocations that do not exist are attempted to be freed during driver remove. Some examples of problematic flows: (a) idxd_dmaengine_drv_probe() -> drv_enable_wq() -> idxd_wq_request_irq(): In above flow, if idxd_wq_request_irq() fails then idxd_wq_unmap_portal() is called on error exit path, but drv_enable_wq() returns 0 because idxd_wq_disable() succeeds. The driver is thus loaded successfully. idxd_dmaengine_drv_remove()->drv_disable_wq()->idxd_wq_unmap_portal() Above flow on driver unload triggers the WARN in devm_iounmap() because the device resource has already been removed during error path of drv_enable_wq(). (b) idxd_dmaengine_drv_probe() -> drv_enable_wq() -> idxd_wq_request_irq(): In above flow, if idxd_wq_request_irq() fails then idxd_wq_init_percpu_ref() is never called to initialize the percpu counter, yet the driver loads successfully because drv_enable_wq() returns 0. idxd_dmaengine_drv_remove()->__idxd_wq_quiesce()->percpu_ref_kill(): Above flow on driver unload triggers a BUG when attempting to drop the initial ref of the uninitialized percpu ref: BUG: kernel NULL pointer dereference, address: 0000000000000010 Fix the drv_enable_wq() error path by returning the original error that indicates failure of workqueue enabling. This ensures that the probe fails when an error is encountered and the driver remove paths are only attempted when the workqueue was enabled successfully. Fixes: 1f2bb40337f0 ("dmaengine: idxd: move wq_enable() to device.c") Signed-off-by: Reinette Chatre <reinette.chatre(a)intel.com> Reviewed-by: Dave Jiang <dave.jiang(a)intel.com> Reviewed-by: Fenghua Yu <fenghua.yu(a)intel.com> Cc: stable(a)vger.kernel.org Link: https://lore.kernel.org/r/e8d8116e5efa0fd14fadc5adae6ffd319f0e5ff1.16704524… Signed-off-by: Vinod Koul <vkoul(a)kernel.org> Signed-off-by: Qi Xi <xiqi2(a)huawei.com> --- drivers/dma/idxd/device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c index 300ee3b5cf63..cd792f3f9873 100644 --- a/drivers/dma/idxd/device.c +++ b/drivers/dma/idxd/device.c @@ -1390,8 +1390,7 @@ int drv_enable_wq(struct idxd_wq *wq) err_irq: idxd_wq_unmap_portal(wq); err_map_portal: - rc = idxd_wq_disable(wq, false); - if (rc < 0) + if (idxd_wq_disable(wq, false)) dev_dbg(dev, "wq %s disable failed\n", dev_name(wq_confdev(wq))); err: return rc; -- 2.33.0

2 1

[PATCH openEuler-22.03-LTS-SP1] dmaengine: idxd: Let probe fail when workqueue cannot be enabled
by Qi Xi 13 Dec '24

13 Dec '24

From: Reinette Chatre <reinette.chatre(a)intel.com> mainline inclusion from mainline-v6.2-rc5 commit b51b75f0604f17c0f6f3b6f68f1a521a5cc6b04f category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IALL6O CVE: CVE-2022-48868 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- The workqueue is enabled when the appropriate driver is loaded and disabled when the driver is removed. When the driver is removed it assumes that the workqueue was enabled successfully and proceeds to free allocations made during workqueue enabling. Failure during workqueue enabling does not prevent the driver from being loaded. This is because the error path within drv_enable_wq() returns success unless a second failure is encountered during the error path. By returning success it is possible to load the driver even if the workqueue cannot be enabled and allocations that do not exist are attempted to be freed during driver remove. Some examples of problematic flows: (a) idxd_dmaengine_drv_probe() -> drv_enable_wq() -> idxd_wq_request_irq(): In above flow, if idxd_wq_request_irq() fails then idxd_wq_unmap_portal() is called on error exit path, but drv_enable_wq() returns 0 because idxd_wq_disable() succeeds. The driver is thus loaded successfully. idxd_dmaengine_drv_remove()->drv_disable_wq()->idxd_wq_unmap_portal() Above flow on driver unload triggers the WARN in devm_iounmap() because the device resource has already been removed during error path of drv_enable_wq(). (b) idxd_dmaengine_drv_probe() -> drv_enable_wq() -> idxd_wq_request_irq(): In above flow, if idxd_wq_request_irq() fails then idxd_wq_init_percpu_ref() is never called to initialize the percpu counter, yet the driver loads successfully because drv_enable_wq() returns 0. idxd_dmaengine_drv_remove()->__idxd_wq_quiesce()->percpu_ref_kill(): Above flow on driver unload triggers a BUG when attempting to drop the initial ref of the uninitialized percpu ref: BUG: kernel NULL pointer dereference, address: 0000000000000010 Fix the drv_enable_wq() error path by returning the original error that indicates failure of workqueue enabling. This ensures that the probe fails when an error is encountered and the driver remove paths are only attempted when the workqueue was enabled successfully. Fixes: 1f2bb40337f0 ("dmaengine: idxd: move wq_enable() to device.c") Signed-off-by: Reinette Chatre <reinette.chatre(a)intel.com> Reviewed-by: Dave Jiang <dave.jiang(a)intel.com> Reviewed-by: Fenghua Yu <fenghua.yu(a)intel.com> Cc: stable(a)vger.kernel.org Link: https://lore.kernel.org/r/e8d8116e5efa0fd14fadc5adae6ffd319f0e5ff1.16704524… Signed-off-by: Vinod Koul <vkoul(a)kernel.org> Signed-off-by: Qi Xi <xiqi2(a)huawei.com> --- drivers/dma/idxd/device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c index 06f5d3783d77..c5523ced2e3a 100644 --- a/drivers/dma/idxd/device.c +++ b/drivers/dma/idxd/device.c @@ -1390,8 +1390,7 @@ int drv_enable_wq(struct idxd_wq *wq) err_irq: idxd_wq_unmap_portal(wq); err_map_portal: - rc = idxd_wq_disable(wq, false); - if (rc < 0) + if (idxd_wq_disable(wq, false)) dev_dbg(dev, "wq %s disable failed\n", dev_name(wq_confdev(wq))); err: return rc; -- 2.33.0

2 1

[PATCH OLK-5.10] dmaengine: idxd: Let probe fail when workqueue cannot be enabled
by Qi Xi 13 Dec '24

13 Dec '24

From: Reinette Chatre <reinette.chatre(a)intel.com> mainline inclusion from mainline-v6.2-rc5 commit b51b75f0604f17c0f6f3b6f68f1a521a5cc6b04f category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IALL6O CVE: CVE-2022-48868 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- The workqueue is enabled when the appropriate driver is loaded and disabled when the driver is removed. When the driver is removed it assumes that the workqueue was enabled successfully and proceeds to free allocations made during workqueue enabling. Failure during workqueue enabling does not prevent the driver from being loaded. This is because the error path within drv_enable_wq() returns success unless a second failure is encountered during the error path. By returning success it is possible to load the driver even if the workqueue cannot be enabled and allocations that do not exist are attempted to be freed during driver remove. Some examples of problematic flows: (a) idxd_dmaengine_drv_probe() -> drv_enable_wq() -> idxd_wq_request_irq(): In above flow, if idxd_wq_request_irq() fails then idxd_wq_unmap_portal() is called on error exit path, but drv_enable_wq() returns 0 because idxd_wq_disable() succeeds. The driver is thus loaded successfully. idxd_dmaengine_drv_remove()->drv_disable_wq()->idxd_wq_unmap_portal() Above flow on driver unload triggers the WARN in devm_iounmap() because the device resource has already been removed during error path of drv_enable_wq(). (b) idxd_dmaengine_drv_probe() -> drv_enable_wq() -> idxd_wq_request_irq(): In above flow, if idxd_wq_request_irq() fails then idxd_wq_init_percpu_ref() is never called to initialize the percpu counter, yet the driver loads successfully because drv_enable_wq() returns 0. idxd_dmaengine_drv_remove()->__idxd_wq_quiesce()->percpu_ref_kill(): Above flow on driver unload triggers a BUG when attempting to drop the initial ref of the uninitialized percpu ref: BUG: kernel NULL pointer dereference, address: 0000000000000010 Fix the drv_enable_wq() error path by returning the original error that indicates failure of workqueue enabling. This ensures that the probe fails when an error is encountered and the driver remove paths are only attempted when the workqueue was enabled successfully. Fixes: 1f2bb40337f0 ("dmaengine: idxd: move wq_enable() to device.c") Signed-off-by: Reinette Chatre <reinette.chatre(a)intel.com> Reviewed-by: Dave Jiang <dave.jiang(a)intel.com> Reviewed-by: Fenghua Yu <fenghua.yu(a)intel.com> Cc: stable(a)vger.kernel.org Link: https://lore.kernel.org/r/e8d8116e5efa0fd14fadc5adae6ffd319f0e5ff1.16704524… Signed-off-by: Vinod Koul <vkoul(a)kernel.org> Signed-off-by: Qi Xi <xiqi2(a)huawei.com> --- drivers/dma/idxd/device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c index 300ee3b5cf63..cd792f3f9873 100644 --- a/drivers/dma/idxd/device.c +++ b/drivers/dma/idxd/device.c @@ -1390,8 +1390,7 @@ int drv_enable_wq(struct idxd_wq *wq) err_irq: idxd_wq_unmap_portal(wq); err_map_portal: - rc = idxd_wq_disable(wq, false); - if (rc < 0) + if (idxd_wq_disable(wq, false)) dev_dbg(dev, "wq %s disable failed\n", dev_name(wq_confdev(wq))); err: return rc; -- 2.33.0

2 1

[PATCH OLK-6.6 0/2] kabi: restrict the KABI fix to a specific architecture and dist
by Xie XiuQi 13 Dec '24

13 Dec '24

Some distributions need to maintain and fix KABI compatibility so that drivers do not need to be recompiled during kernel upgrades. Fixing KABI compatibility is a dangerous and hacking job. Developers need to know clearly what they are doing and the risks they may face. KABI fix actions are closely related to the processor architecture. Fixes may not be appropriate for all architectures. Improper fix may cause kernel panic or unexpected error. Only for expert users, and select N by default. Xie XiuQi (2): kabi: restrict the KABI fix to a specific architecture and dist kabi: enable KABI_COMPAT series by default on x86_64 & ARM64 arch/arm64/configs/openeuler_defconfig | 5 +-- arch/x86/configs/openeuler_defconfig | 5 +-- include/linux/kabi.h | 2 +- init/Kconfig | 49 +++++++++++++++++--------- 4 files changed, 40 insertions(+), 21 deletions(-) -- 2.20.1

1 2

[PATCH OLK-6.6 V1] kabi reserver space for i2c and sched
by Zicheng Qu 13 Dec '24

13 Dec '24

Offering: HULK hulk inclusion category: other bugzilla: https://gitee.com/openeuler/kernel/issues/IBAZ3A -------------------------------- Add two KABI_RESERVE macros for each struct, including i2c_adapter, sched_domain_shared, sched_domain. Signed-off-by: Zicheng Qu <quzicheng(a)huawei.com> --- include/linux/i2c.h | 3 +++ include/linux/sched/topology.h | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 32cf5708d5a5..3fd6932bf8cd 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -746,6 +746,9 @@ struct i2c_adapter { struct irq_domain *host_notify_domain; struct regulator *bus_regulator; + + KABI_RESERVE(1) + KABI_RESERVE(2) }; #define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev) diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 8e4d9bbdaa40..09a2b2625202 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -85,6 +85,8 @@ struct sched_domain_shared { #ifdef CONFIG_SCHED_STEAL struct sparsemask *cfs_overload_cpus; #endif + KABI_RESERVE(1) + KABI_RESERVE(2) }; struct sched_domain { @@ -154,6 +156,9 @@ struct sched_domain { }; struct sched_domain_shared *shared; + KABI_RESERVE(1) + KABI_RESERVE(2) + unsigned int span_weight; /* * Span of all CPUs in this domain. -- 2.34.1

2 1

[PATCH openEuler-1.0-LTS 0/2] CVE-2024-46733
by Yifan Qiao 13 Dec '24

13 Dec '24

Boris Burkov (1): btrfs: fix qgroup reserve leaks in cow_file_range Haisu Wang (1): btrfs: fix the length of reserved qgroup to free fs/btrfs/inode.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.39.2

2 3

[openeuler:OLK-5.10 2579/2579] mm/share_pool.c:738:21: error: implicit declaration of function 'huge_ptep_get'
by kernel test robot 13 Dec '24

13 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: ff5378fff024fcb2552e6da22811cf933fe4a4c0 commit: c18bb367938bb02621f45d904531832df1abed2a [2579/2579] share_pool: Implement sp_walk_page_range() config: arm64-randconfig-004-20241213 (https://download.01.org/0day-ci/archive/20241213/202412131028.JwkewMIN-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241213/202412131028.JwkewMIN-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412131028.JwkewMIN-lkp@intel.com/ All errors (new ones prefixed by >>): mm/share_pool.c: In function 'sp_hugetlb_entry': >> mm/share_pool.c:738:21: error: implicit declaration of function 'huge_ptep_get' [-Werror=implicit-function-declaration] 738 | pte_t pte = huge_ptep_get(ptep); | ^~~~~~~~~~~~~ >> mm/share_pool.c:738:21: error: invalid initializer mm/share_pool.c: At top level: mm/share_pool.c:1116:6: warning: no previous prototype for 'sp_proc_stat_drop' [-Wmissing-prototypes] 1116 | void sp_proc_stat_drop(struct sp_proc_stat *stat) | ^~~~~~~~~~~~~~~~~ mm/share_pool.c:1347:6: warning: no previous prototype for 'spa_overview_show' [-Wmissing-prototypes] 1347 | void spa_overview_show(struct seq_file *seq) | ^~~~~~~~~~~~~~~~~ mm/share_pool.c:1429:6: warning: no previous prototype for 'spg_overview_show' [-Wmissing-prototypes] 1429 | void spg_overview_show(struct seq_file *seq) | ^~~~~~~~~~~~~~~~~ mm/share_pool.c:1561:12: warning: 'proc_overview_show' defined but not used [-Wunused-function] 1561 | static int proc_overview_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~~~~~~ mm/share_pool.c:1518:12: warning: 'proc_stat_show' defined but not used [-Wunused-function] 1518 | static int proc_stat_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~~ mm/share_pool.c:1454:12: warning: 'spa_stat_show' defined but not used [-Wunused-function] 1454 | static int spa_stat_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~ mm/share_pool.c:490:21: warning: 'spa_file' defined but not used [-Wunused-function] 490 | static struct file *spa_file(struct sp_area *spa) | ^~~~~~~~ mm/share_pool.c:485:22: warning: 'spa_size' defined but not used [-Wunused-function] 485 | static unsigned long spa_size(struct sp_area *spa) | ^~~~~~~~ mm/share_pool.c:409:13: warning: 'free_spg_stat' defined but not used [-Wunused-function] 409 | static void free_spg_stat(int spg_id) | ^~~~~~~~~~~~~ mm/share_pool.c:386:12: warning: 'sp_init_spg_stat' defined but not used [-Wunused-function] 386 | static int sp_init_spg_stat(struct sp_group *spg) | ^~~~~~~~~~~~~~~~ mm/share_pool.c:345:30: warning: 'sp_init_process_stat' defined but not used [-Wunused-function] 345 | static struct spg_proc_stat *sp_init_process_stat(struct task_struct *tsk, | ^~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:267:13: warning: 'update_spg_proc_stat_k2u' defined but not used [-Wunused-function] 267 | static void update_spg_proc_stat_k2u(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:253:13: warning: 'update_spg_proc_stat_alloc' defined but not used [-Wunused-function] 253 | static void update_spg_proc_stat_alloc(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:223:13: warning: 'update_spg_stat_k2u' defined but not used [-Wunused-function] 223 | static void update_spg_stat_k2u(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~ mm/share_pool.c:201:13: warning: 'update_spg_stat_alloc' defined but not used [-Wunused-function] 201 | static void update_spg_stat_alloc(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~~~ In file included from mm/share_pool.c:27: mm/share_pool.c:105:19: warning: 'sp_group_id_ida' defined but not used [-Wunused-variable] 105 | static DEFINE_IDA(sp_group_id_ida); | ^~~~~~~~~~~~~~~ include/linux/idr.h:253:44: note: in definition of macro 'DEFINE_IDA' 253 | #define DEFINE_IDA(name) struct ida name = IDA_INIT(name) | ^~~~ mm/share_pool.c:99:19: warning: 'sp_group_idr' defined but not used [-Wunused-variable] 99 | static DEFINE_IDR(sp_group_idr); | ^~~~~~~~~~~~ include/linux/idr.h:56:44: note: in definition of macro 'DEFINE_IDR' 56 | #define DEFINE_IDR(name) struct idr name = IDR_INIT(name) | ^~~~ mm/share_pool.c:82:18: warning: 'mdc_default_group_id' defined but not used [-Wunused-const-variable=] 82 | static const int mdc_default_group_id = 1; | ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for PGP_KEY_PARSER Depends on [n]: CRYPTO [=y] && ASYMMETRIC_KEY_TYPE [=y] && ASYMMETRIC_PUBLIC_KEY_SUBTYPE [=n] Selected by [y]: - PGP_PRELOAD [=y] && CRYPTO [=y] && ASYMMETRIC_KEY_TYPE [=y] vim +/huge_ptep_get +738 mm/share_pool.c 733 734 static int sp_hugetlb_entry(pte_t *ptep, unsigned long hmask, 735 unsigned long addr, unsigned long next, 736 struct mm_walk *walk) 737 { > 738 pte_t pte = huge_ptep_get(ptep); 739 struct page *page = pte_page(pte); 740 struct sp_walk_data *sp_walk_data; 741 742 if (unlikely(!pte_present(pte))) { 743 pr_debug("the page of addr %lx unexpectedly not in RAM\n", (unsigned long)addr); 744 return -EFAULT; 745 } 746 747 sp_walk_data = walk->private; 748 get_page(page); 749 sp_walk_data->pages[sp_walk_data->page_count++] = page; 750 return 0; 751 } 752 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 2579/2579] mm/share_pool.c:1215:12: warning: 'spa_stat_show' defined but not used
by kernel test robot 13 Dec '24

13 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: ff5378fff024fcb2552e6da22811cf933fe4a4c0 commit: d83dcc99d770b53e4839791fa2319c953fc6e42d [2579/2579] share_pool: Add proc interfaces to show sp info config: arm64-randconfig-004-20241213 (https://download.01.org/0day-ci/archive/20241213/202412130822.tSyyPsoM-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241213/202412130822.tSyyPsoM-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412130822.tSyyPsoM-lkp@intel.com/ All warnings (new ones prefixed by >>): mm/share_pool.c:877:6: warning: no previous prototype for 'sp_proc_stat_drop' [-Wmissing-prototypes] 877 | void sp_proc_stat_drop(struct sp_proc_stat *stat) | ^~~~~~~~~~~~~~~~~ mm/share_pool.c:1108:6: warning: no previous prototype for 'spa_overview_show' [-Wmissing-prototypes] 1108 | void spa_overview_show(struct seq_file *seq) | ^~~~~~~~~~~~~~~~~ mm/share_pool.c:1190:6: warning: no previous prototype for 'spg_overview_show' [-Wmissing-prototypes] 1190 | void spg_overview_show(struct seq_file *seq) | ^~~~~~~~~~~~~~~~~ mm/share_pool.c:1322:12: warning: 'proc_overview_show' defined but not used [-Wunused-function] 1322 | static int proc_overview_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~~~~~~ mm/share_pool.c:1279:12: warning: 'proc_stat_show' defined but not used [-Wunused-function] 1279 | static int proc_stat_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~~ >> mm/share_pool.c:1215:12: warning: 'spa_stat_show' defined but not used [-Wunused-function] 1215 | static int spa_stat_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~ mm/share_pool.c:489:21: warning: 'spa_file' defined but not used [-Wunused-function] 489 | static struct file *spa_file(struct sp_area *spa) | ^~~~~~~~ mm/share_pool.c:484:22: warning: 'spa_size' defined but not used [-Wunused-function] 484 | static unsigned long spa_size(struct sp_area *spa) | ^~~~~~~~ mm/share_pool.c:408:13: warning: 'free_spg_stat' defined but not used [-Wunused-function] 408 | static void free_spg_stat(int spg_id) | ^~~~~~~~~~~~~ mm/share_pool.c:385:12: warning: 'sp_init_spg_stat' defined but not used [-Wunused-function] 385 | static int sp_init_spg_stat(struct sp_group *spg) | ^~~~~~~~~~~~~~~~ mm/share_pool.c:344:30: warning: 'sp_init_process_stat' defined but not used [-Wunused-function] 344 | static struct spg_proc_stat *sp_init_process_stat(struct task_struct *tsk, | ^~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:266:13: warning: 'update_spg_proc_stat_k2u' defined but not used [-Wunused-function] 266 | static void update_spg_proc_stat_k2u(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:252:13: warning: 'update_spg_proc_stat_alloc' defined but not used [-Wunused-function] 252 | static void update_spg_proc_stat_alloc(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:222:13: warning: 'update_spg_stat_k2u' defined but not used [-Wunused-function] 222 | static void update_spg_stat_k2u(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~ mm/share_pool.c:200:13: warning: 'update_spg_stat_alloc' defined but not used [-Wunused-function] 200 | static void update_spg_stat_alloc(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~~~ In file included from mm/share_pool.c:27: mm/share_pool.c:104:19: warning: 'sp_group_id_ida' defined but not used [-Wunused-variable] 104 | static DEFINE_IDA(sp_group_id_ida); | ^~~~~~~~~~~~~~~ include/linux/idr.h:253:44: note: in definition of macro 'DEFINE_IDA' 253 | #define DEFINE_IDA(name) struct ida name = IDA_INIT(name) | ^~~~ mm/share_pool.c:98:19: warning: 'sp_group_idr' defined but not used [-Wunused-variable] 98 | static DEFINE_IDR(sp_group_idr); | ^~~~~~~~~~~~ include/linux/idr.h:56:44: note: in definition of macro 'DEFINE_IDR' 56 | #define DEFINE_IDR(name) struct idr name = IDR_INIT(name) | ^~~~ mm/share_pool.c:81:18: warning: 'mdc_default_group_id' defined but not used [-Wunused-const-variable=] 81 | static const int mdc_default_group_id = 1; | ^~~~~~~~~~~~~~~~~~~~ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for PGP_KEY_PARSER Depends on [n]: CRYPTO [=y] && ASYMMETRIC_KEY_TYPE [=y] && ASYMMETRIC_PUBLIC_KEY_SUBTYPE [=n] Selected by [y]: - PGP_PRELOAD [=y] && CRYPTO [=y] && ASYMMETRIC_KEY_TYPE [=y] vim +/spa_stat_show +1215 mm/share_pool.c 1214 > 1215 static int spa_stat_show(struct seq_file *seq, void *offset) 1216 { 1217 spg_overview_show(seq); 1218 spa_overview_show(seq); 1219 /* print the file header */ 1220 seq_printf(seq, "%-10s %-16s %-16s %-10s %-7s %-5s %-8s %-8s\n", 1221 "Group ID", "va_start", "va_end", "Size(KB)", "Type", "Huge", "PID", "Ref"); 1222 rb_spa_stat_show(seq); 1223 return 0; 1224 } 1225 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 2579/2579] include/acpi/processor.h:221:9: error: unknown type name 'phys_cpuid_t'
by kernel test robot 13 Dec '24

13 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: ff5378fff024fcb2552e6da22811cf933fe4a4c0 commit: c3fe0dc62217d6faa76128ed26d64e421767919e [2579/2579] cpufreq: Add SEEP governor for hardware-managed P-states config: arm64-randconfig-002-20241213 (https://download.01.org/0day-ci/archive/20241213/202412130652.MbID3V5Y-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241213/202412130652.MbID3V5Y-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412130652.MbID3V5Y-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from include/acpi/cppc_acpi.h:17, from drivers/cpufreq/cpufreq_seep.c:13: >> include/acpi/processor.h:221:9: error: unknown type name 'phys_cpuid_t' 221 | phys_cpuid_t phys_id; /* CPU hardware ID such as APIC ID for x86 */ | ^~~~~~~~~~~~ include/acpi/processor.h:350:1: error: unknown type name 'phys_cpuid_t' 350 | phys_cpuid_t acpi_get_phys_id(acpi_handle, int type, u32 acpi_id); | ^~~~~~~~~~~~ include/acpi/processor.h:351:1: error: unknown type name 'phys_cpuid_t' 351 | phys_cpuid_t acpi_map_madt_entry(u32 acpi_id); | ^~~~~~~~~~~~ include/acpi/processor.h:352:20: error: unknown type name 'phys_cpuid_t' 352 | int acpi_map_cpuid(phys_cpuid_t phys_id, u32 acpi_id); | ^~~~~~~~~~~~ include/acpi/processor.h:354:1: error: unknown type name 'phys_cpuid_t' 354 | phys_cpuid_t acpi_id_to_phys_cpuid(u32 acpi_id); | ^~~~~~~~~~~~ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for CPPC_CPUFREQ_SYSFS_INTERFACE Depends on [n]: CPU_FREQ [=y] && (ARM || ARM64 [=y]) && ACPI_CPPC_CPUFREQ [=n] Selected by [y]: - CPU_FREQ_GOV_SEEP [=y] && CPU_FREQ [=y] && (ACPI_CPPC_CPUFREQ [=n] || ARM64 [=y]) vim +/phys_cpuid_t +221 include/acpi/processor.h ^1da177e4c3f415 Linus Torvalds 2005-04-16 217 ^1da177e4c3f415 Linus Torvalds 2005-04-16 218 struct acpi_processor { ^1da177e4c3f415 Linus Torvalds 2005-04-16 219 acpi_handle handle; ^1da177e4c3f415 Linus Torvalds 2005-04-16 220 u32 acpi_id; 828aef376d7a129 Catalin Marinas 2015-03-24 @221 phys_cpuid_t phys_id; /* CPU hardware ID such as APIC ID for x86 */ af8f3f514d193eb Hanjun Guo 2015-01-04 222 u32 id; /* CPU logical ID allocated by OS */ ^1da177e4c3f415 Linus Torvalds 2005-04-16 223 u32 pblk; ^1da177e4c3f415 Linus Torvalds 2005-04-16 224 int performance_platform_limit; 01854e697a77a43 Luming Yu 2007-05-26 225 int throttling_platform_limit; ff55a9cebab0240 Len Brown 2007-06-02 226 /* 0 - states 0..n-th state available */ 01854e697a77a43 Luming Yu 2007-05-26 227 ^1da177e4c3f415 Linus Torvalds 2005-04-16 228 struct acpi_processor_flags flags; ^1da177e4c3f415 Linus Torvalds 2005-04-16 229 struct acpi_processor_power power; ^1da177e4c3f415 Linus Torvalds 2005-04-16 230 struct acpi_processor_performance *performance; ^1da177e4c3f415 Linus Torvalds 2005-04-16 231 struct acpi_processor_throttling throttling; ^1da177e4c3f415 Linus Torvalds 2005-04-16 232 struct acpi_processor_limit limit; d9460fd227ed2ce Zhang Rui 2008-01-17 233 struct thermal_cooling_device *cdev; ac212b6980d8d5e Rafael J. Wysocki 2013-05-03 234 struct device *dev; /* Processor device. */ 3000ce3c52f8b8d Rafael J. Wysocki 2019-10-16 235 struct freq_qos_request perflib_req; 3000ce3c52f8b8d Rafael J. Wysocki 2019-10-16 236 struct freq_qos_request thermal_req; ^1da177e4c3f415 Linus Torvalds 2005-04-16 237 }; ^1da177e4c3f415 Linus Torvalds 2005-04-16 238 :::::: The code at line 221 was first introduced by commit :::::: 828aef376d7a129547bc4ebb949965040177e3da ACPI / processor: Introduce phys_cpuid_t for CPU hardware ID :::::: TO: Catalin Marinas <catalin.marinas(a)arm.com> :::::: CC: Will Deacon <will.deacon(a)arm.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0